Leahnaya/PKHeX
1
0
Fork 0
mirror of https://github.com/kwsch/PKHeX.git synced 2026-04-24 23:57:12 -05:00
Code Issues Actions Packages Projects Releases Wiki Activity

Don't add tickets on full pouch

Browse Source 
-1 for first empty index => full
clean up initial sanity checks
https://projectpokemon.org/home/forums/topic/63498-pkhex-230603/?do=findComment&comment=283990
This commit is contained in:
Kurt 2023-06-13 10:18:58 -07:00
parent 6964d48adb
commit e06368ea1d
1 changed files with 5 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
PKHeX.WinForms/Subforms/Save Editors/Gen3/SAV_Misc3.cs
View File

@ -119,21 +119,14 @@ private void SaveJoyful(IGen3Joyful j)
private void B_GetTickets_Click(object sender, EventArgs e)
{
var Pouches = SAV.Inventory;
var itemlist = GameInfo.Strings.GetItemStrings(SAV.Context, SAV.Version).ToArray();
for (int i = 0; i < itemlist.Length; i++)
{
if (string.IsNullOrEmpty(itemlist[i]))
itemlist[i] = $"(Item #{i:000})";
}
var itemlist = GameInfo.Strings.GetItemStrings(SAV.Context, SAV.Version);
var tickets = TicketItemIDs;
if (!SAV.Japanese && DialogResult.Yes != WinFormsUtil.Prompt(MessageBoxButtons.YesNo, $"Non Japanese save file. Add {itemlist[ItemIDOldSeaMap]} (unreleased)?"))
var p = Pouches.First(z => z.Type == InventoryType.KeyItems);
bool hasOldSea = Array.Exists(p.Items, static z => z.Index == ItemIDOldSeaMap);
if (!hasOldSea && !SAV.Japanese && DialogResult.Yes != WinFormsUtil.Prompt(MessageBoxButtons.YesNo, $"Non Japanese save file. Add {itemlist[ItemIDOldSeaMap]} (unreleased)?"))
tickets = tickets[..^1]; // remove old sea map
var p = Pouches.FirstOrDefault(z => z.Type == InventoryType.KeyItems);
if (p == null)
throw new ArgumentException(nameof(InventoryType));
// check for missing tickets
Span<ushort> have = stackalloc ushort[tickets.Length]; int h = 0;
Span<ushort> missing = stackalloc ushort[tickets.Length]; int m = 0;
@ -157,7 +150,7 @@ private void B_GetTickets_Click(object sender, EventArgs e)
// check for space
int end = Array.FindIndex(p.Items, static z => z.Index == 0);
if (end + missing.Length >= p.Items.Length)
if (end == -1 || end + missing.Length >= p.Items.Length)
{
WinFormsUtil.Alert("Not enough space in pouch.", "Please use the InventoryEditor.");
B_GetTickets.Enabled = false;