Leahnaya/PKHeX
1
0
Fork 0
mirror of https://github.com/kwsch/PKHeX.git synced 2026-09-12 17:35:21 -05:00
Code Issues Actions Packages Projects Releases Wiki Activity

Get lineage using the source generation of the pokemon (#769)

Browse Source 
* Added function get max species by source game of a pokemon
* Tweak get lineage function to take into account the source generation of the pokemon
This commit is contained in:
javierhimura
2017-01-29 18:11:48 +01:00
committed by Kaphotics
parent 80386bf667
commit dfc518faab
3 changed files with 38 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
PKHeX/Legality/Checks.cs
View File

@@ -369,7 +369,7 @@ private CheckResult verifyEncounter()
if (pkm.VC)
{
int baseSpecies = Legal.getEvolutionChain(pkm, null).Min(entry => entry.Species);
int baseSpecies = Legal.getBaseSpecies(pkm);
if ((pkm.VC1 && baseSpecies > Legal.MaxSpeciesID_1) ||
(pkm.VC2 && baseSpecies > Legal.MaxSpeciesID_2))
return new CheckResult(Severity.Invalid, "VC: Unobtainable species.", CheckIdentifier.Encounter);

34
PKHeX/Legality/Core.cs
View File

@@ -365,6 +365,40 @@ private static EvolutionTree getEvolutionTable(PKM pkm)
return Evolves6;
}
}
private static int getMaxSpeciesOrigin(int generation)
{
switch (generation)
{
case 1:
return Legal.MaxSpeciesID_1;
case 2:
return Legal.MaxSpeciesID_2;
case 3:
return Legal.MaxSpeciesID_3;
case 4:
return Legal.MaxSpeciesID_4;
case 5:
return Legal.MaxSpeciesID_5;
case 6:
return Legal.MaxSpeciesID_6;
case 7:
return Legal.MaxSpeciesID_7;
default:
return Legal.MaxSpeciesID_7;
}
}
internal static int getMaxSpeciesOrigin(PKM pkm)
{
if (pkm.Format == 1 || pkm.VC1) //Gen1 VC could not trade with gen 2 yet
return getMaxSpeciesOrigin(1);
else if (pkm.Format == 2 || pkm.VC2)
return getMaxSpeciesOrigin(2);
else
return getMaxSpeciesOrigin(pkm.GenNumber);
}
internal static IEnumerable<MysteryGift> getValidGifts(PKM pkm)
{
switch (pkm.GenNumber)

3
PKHeX/Legality/Structures/EvolutionTree.cs
View File

@@ -354,6 +354,7 @@ public void Insert(EvolutionStage evo)
public IEnumerable<DexLevel> getExplicitLineage(PKM pkm, int lvl, bool skipChecks, int maxSpecies)
{
int maxSpeciesOrigin = Legal.getMaxSpeciesOrigin(pkm);
List<DexLevel> dl = new List<DexLevel> { new DexLevel { Species = pkm.Species, Level = lvl, Form = pkm.AltForm } };
for (int i = Chain.Count-1; i >= 0; i--) // reverse evolution!
{
@@ -376,6 +377,8 @@ public IEnumerable<DexLevel> getExplicitLineage(PKM pkm, int lvl, bool skipCheck
if (!oneValid)
break;
}
if (dl.Any(d=>d.Species <= maxSpeciesOrigin) && dl.Last().Species > maxSpeciesOrigin)
dl.RemoveAt(dl.Count - 1);//remove future gen preevolutions, no munchlax in a gen3 snorlax, no pichu in a gen1 vc raichu, etc
return dl;
}
}