Leahnaya/PKHeX
1
0
Fork 0
mirror of https://github.com/kwsch/PKHeX.git synced 2026-05-09 04:24:36 -05:00
Code Issues Actions Packages Projects Releases Wiki Activity

Handle KOR Arcanine with PID=1 type

Browse Source 
Revise some logic flow and add comments indicating why
There is no wc.Gender==3 for any gift; that's not how things are specified in GameFreak's internal tool (suspected).
This commit is contained in:
Kurt 2020-08-29 14:33:51 -07:00
parent 1ee459a46c
commit c738857010
1 changed files with 19 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
PKHeX.Core/MysteryGifts/PCD.cs
View File

@ -166,10 +166,26 @@ protected override bool IsMatchExact(PKM pkm, DexLevel evo)
if (wc.Ball != pkm.Ball) return false;
if (wc.OT_Gender < 3 && wc.OT_Gender != pkm.OT_Gender) return false;
if (wc.PID == 1 && pkm.IsShiny) return false;
if (wc.Gender != 3 && wc.Gender != pkm.Gender) return false;
if (pkm is IContestStats s && s.IsContestBelow(wc))
if (wc.PID == 1)
{
// Random PID, never shiny
// PID=0 was never used (pure random).
if (pkm.IsShiny)
return false;
// Don't check gender. All gifts that have PID=1 are genderless, with one exception.
// The KOR Arcanine can end up with either gender, even though the template may have a specified gender.
}
else
{
// Fixed PID
if (wc.Gender != pkm.Gender)
return false;
}
// Milotic is the only gift to come with Contest stats.
if (wc.Species == (int)Core.Species.Milotic && pkm is IContestStats s && s.IsContestBelow(wc))
return false;
return true;