Leahnaya/PKHeX
1
0
Fork 0
mirror of https://github.com/kwsch/PKHeX.git synced 2026-09-13 10:46:12 -05:00
Code Issues Actions Packages Projects Releases Wiki Activity

PBR: Fix SetStringUnicodeBR maxLength (#4843)

Browse Source 
maxLength is the maximum length in terms of characters, not bytes
This commit is contained in:
abcboy101
2026-07-27 12:14:13 -04:00
committed by GitHub
parent 9ccc5fdc45
commit b916b06c03
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
PKHeX.Core/PKM/Strings/StringConverter4GC.cs
View File

@@ -208,17 +208,17 @@ public static int LoadStringUnicodeBR(ReadOnlySpan<byte> data, Span<char> result
public static int SetStringUnicodeBR(ReadOnlySpan<char> value, Span<byte> destBuffer, int maxLength = -1, StringConverterOption option = StringConverterOption.ClearZero)
{
if (maxLength < 0)
maxLength = destBuffer.Length - 2;
maxLength = (destBuffer.Length / 2) - 1;
if (option is StringConverterOption.ClearZero)
destBuffer.Clear();
int count = 0;
for (int i = 0; i < value.Length && count < maxLength; i++)
for (int i = 0; i < value.Length && count < maxLength * 2; i++)
{
var c = value[i];
if (c is LineBreak or Proportional or PokemonName)
{
if (count + 2 >= maxLength)
if (count + 2 >= maxLength * 2)
break;
WriteUInt16BigEndian(destBuffer[count..], VariableChar);
count += 2;