Leahnaya/PKHeX
1
0
Fork 0
mirror of https://github.com/kwsch/PKHeX.git synced 2026-09-08 21:45:56 -05:00
Code Issues Actions Packages Projects Releases Wiki Activity

Remove unnecessary comparison

Browse Source 
in Array.Resize, an array is only created if the size is not equivalent
we're just repeating the same logic; let the jit optimize out the null check
This commit is contained in:
Kurt
2020-07-19 16:35:31 -05:00
parent 40ce63873d
commit 9f20aa2f4f
2 changed files with 10 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
PKHeX.Core/PKM/PKM.cs
View File

@@ -22,17 +22,10 @@ public abstract class PKM : ITrainerID, ILangNick, IGameValueLimit, INature
public int Box { get; set; } = -1; // Batch Editor
public int Slot { get; set; } = -1; // Batch Editor
public virtual byte[] EncryptedPartyData => Truncate(Encrypt(), SIZE_PARTY);
public virtual byte[] EncryptedBoxData => Truncate(Encrypt(), SIZE_STORED);
public virtual byte[] DecryptedPartyData => Truncate(Write(), SIZE_PARTY);
public virtual byte[] DecryptedBoxData => Truncate(Write(), SIZE_STORED);
private static byte[] Truncate(byte[] data, int newSize)
{
if (data.Length != newSize)
Array.Resize(ref data, newSize);
return data;
}
public virtual byte[] EncryptedPartyData => ArrayUtil.Truncate(Encrypt(), SIZE_PARTY);
public virtual byte[] EncryptedBoxData => ArrayUtil.Truncate(Encrypt(), SIZE_STORED);
public virtual byte[] DecryptedPartyData => ArrayUtil.Truncate(Write(), SIZE_PARTY);
public virtual byte[] DecryptedBoxData => ArrayUtil.Truncate(Write(), SIZE_STORED);
public virtual bool Valid { get => ChecksumValid && Sanity == 0; set { if (!value) return; Sanity = 0; RefreshChecksum(); } }

6
PKHeX.Core/Util/ArrayUtil.cs
View File

@@ -21,6 +21,12 @@ public static class ArrayUtil
return true;
}
public static byte[] Truncate(byte[] data, int newSize)
{
Array.Resize(ref data, newSize);
return data;
}
public static byte[] Slice(this byte[] src, int offset, int length)
{
byte[] data = new byte[length];