Leahnaya/PKHeX
1
0
Fork 0
mirror of https://github.com/kwsch/PKHeX.git synced 2026-09-12 01:55:13 -05:00
Code Issues Actions Packages Projects Releases Wiki Activity

Prevent egg generator from yielding unbreedable species-forms

Browse Source 
The "IsPresentInGame" will likely have to be refactored out as an interface, as future games (BDSP) will likely have partial national dex content
This commit is contained in:
Kurt
2021-09-06 10:48:32 -07:00
parent 4cb525aac1
commit 99231b978e
1 changed files with 16 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
PKHeX.Core/Legality/Breeding.cs
View File

@@ -110,14 +110,23 @@ public static bool CanHatchAsEgg(int species, int form, int generation)
if (FormInfo.IsTotemForm(species, form, generation))
return false;
if (species == (int)Pichu)
return false; // can't get Spiky Ear Pichu eggs
if (species is (int)Sinistea or (int)Polteageist)
return false; // can't get Antique eggs
return true;
return IsBreedableForm(species, form);
}
/// <summary>
/// Some species can have forms that cannot exist as egg (event/special forms). Same idea as <see cref="FormInfo.IsTotemForm(int,int,int)"/>
/// </summary>
/// <returns>True if can be bred.</returns>
private static bool IsBreedableForm(int species, int form) => species switch
{
(int)Pikachu or (int)Eevee => false, // can't get these forms as egg
(int)Pichu => false, // can't get Spiky Ear Pichu eggs
(int)Floette when form == 5 => false, // can't get Eternal Flower from egg
(int)Sinistea or (int)Polteageist => false, // can't get Antique eggs
_ => true,
};
/// <summary>
/// Checks if the <see cref="species"/>-<see cref="form"/> can exist as a hatched egg in the requested <see cref="game"/>.
/// </summary>
@@ -130,6 +139,8 @@ public static bool CanHatchAsEgg(int species, int form, GameVersion game)
// Sanity check form for origin
var pt = GameData.GetPersonal(game);
var entry = pt.GetFormEntry(species, form);
if (entry is PersonalInfoSWSH { IsPresentInGame: false })
return false;
return form < entry.FormCount || (species == (int)Rotom && form <= 5);
}