Leahnaya/PKHeX
1
0
Fork 0
mirror of https://github.com/kwsch/PKHeX.git synced 2026-08-25 17:04:10 -05:00
Code Issues Actions Packages Projects Releases Wiki Activity

Minor clean

Browse Source 
invert nesting, add missing if( space, group OT checks together
This commit is contained in:
Kurt
2022-05-02 23:48:25 -07:00
parent d58aed109d
commit 7c8f52cbbf
4 changed files with 22 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

35
PKHeX.Core/Editing/Bulk/Suggestion/BatchModifications.cs
View File

@@ -30,26 +30,25 @@ public static ModifyResult SetSuggestedRelearnData(BatchInfo info, string propVa
public static ModifyResult SetSuggestedMasteryData(BatchInfo info, string propValue)
{
var pk = info.Entity;
if (pk is IMoveShop8Mastery t)
if (pk is not IMoveShop8Mastery t)
return ModifyResult.Invalid;
if (IsAll(propValue))
{
if (IsAll(propValue))
{
t.SetMoveShopFlags();
t.SetMoveShopFlagsMastered();
}
else if (!IsNone(propValue))
{
// whatever fit the current moves
t.SetMoveShopFlags(pk.Moves);
t.SetMoveShopFlagsMastered();
}
else
{
t.ClearMoveShopFlags();
}
return ModifyResult.Modified;
t.SetMoveShopFlags();
t.SetMoveShopFlagsMastered();
}
return ModifyResult.Invalid;
else if (!IsNone(propValue))
{
// whatever fit the current moves
t.SetMoveShopFlags(pk.Moves);
t.SetMoveShopFlagsMastered();
}
else
{
t.ClearMoveShopFlags();
}
return ModifyResult.Modified;
}
public static ModifyResult SetSuggestedRibbons(BatchInfo info, string value)

2
PKHeX.Core/Legality/Encounters/EncounterSlot/EncounterSlot8.cs
View File

@@ -122,7 +122,7 @@ public override EncounterMatchRating GetMatchRating(PKM pkm)
return EncounterMatchRating.DeferredErrors;
// Galar Mine hidden encounters can only be found via Curry or Fishing.
if(Location is (30 or 54) && SlotType is AreaSlotType8.HiddenMain && !m.RibbonMarkCurry && !SlotType.CanEncounterViaFishing(Weather))
if (Location is (30 or 54) && SlotType is AreaSlotType8.HiddenMain && !m.RibbonMarkCurry && !SlotType.CanEncounterViaFishing(Weather))
return EncounterMatchRating.DeferredErrors;
}

5
PKHeX.Core/Legality/Verifiers/TrainerNameVerifier.cs
View File

@@ -46,10 +46,11 @@ public override void Verify(LegalityAnalysis data)
{
if (WordFilter.IsFiltered(ot, out string bad))
data.AddLine(GetInvalid($"Wordfilter: {bad}"));
if (WordFilter.IsFiltered(pkm.HT_Name, out bad))
data.AddLine(GetInvalid($"Wordfilter: {bad}"));
if (ContainsTooManyNumbers(ot, data.Info.Generation))
data.AddLine(GetInvalid("Wordfilter: Too many numbers."));
if (WordFilter.IsFiltered(pkm.HT_Name, out bad))
data.AddLine(GetInvalid($"Wordfilter: {bad}"));
}
}

2
PKHeX.WinForms/Subforms/PKM Editors/BatchEditor.cs
View File

@@ -264,7 +264,7 @@ private void ProcessSAV(IList<SlotCache> data, IReadOnlyList<StringInstruction>
if (entry.Source is SlotInfoBox info && SAV.GetSlotFlags(info.Box, info.Slot).IsOverwriteProtected())
editor.AddSkipped();
else if(!BatchEditing.IsFilterMatchMeta(filterMeta, entry))
else if (!BatchEditing.IsFilterMatchMeta(filterMeta, entry))
editor.AddSkipped();
else
editor.Process(pk, Filters, Instructions);