Leahnaya/PKHeX
1
0
Fork 0
mirror of https://github.com/kwsch/PKHeX.git synced 2026-09-14 20:25:50 -05:00
Code Issues Actions Packages Projects Releases Wiki Activity

Refactoring

Browse Source 
split up slot resetting to smaller methods, use non-box reset when
toggling FlagIllegal
Closes #1446
This commit is contained in:
Kurt
2017-09-06 22:11:08 -07:00
parent d7b982728c
commit 62f99bf5b8
1 changed files with 73 additions and 59 deletions
Download Patch File Download Diff File Expand all files Collapse all files

132
PKHeX.WinForms/Controls/SAV Editor/SAVEditor.cs
View File

@@ -35,6 +35,7 @@ public bool FlagIllegal
{
Box.FlagIllegal = value && !HaX;
UpdateBoxViewers(all: true);
ResetNonBoxSlots();
}
}
@@ -145,66 +146,28 @@ public void SetPKMBoxes()
if (SAV.HasBox)
Box.ResetSlots();
// Reload Party
if (SAV.HasParty)
{
for (int i = 0; i < 6; i++)
GetSlotFiller(SAV.GetPartyOffset(i), SlotPictureBoxes[i + 30]);
}
ResetNonBoxSlots();
// Reload Battle Box
if (SAV.HasBattleBox)
{
for (int i = 0; i < 6; i++)
GetSlotFiller(SAV.BattleBox + SAV.SIZE_STORED * i, SlotPictureBoxes[i + 36]);
}
// Reload Daycare
if (SAV.HasDaycare)
{
Label[] L_SlotOccupied = { L_DC1, L_DC2 };
TextBox[] TB_SlotEXP = { TB_Daycare1XP, TB_Daycare2XP };
Label[] L_SlotEXP = { L_XP1, L_XP2 };
for (int i = 0; i < 2; i++)
{
GetSlotFiller(SAV.GetDaycareSlotOffset(SAV.DaycareIndex, i), SlotPictureBoxes[i + 42]);
uint? exp = SAV.GetDaycareEXP(SAV.DaycareIndex, i);
TB_SlotEXP[i].Visible = L_SlotEXP[i].Visible = exp != null;
TB_SlotEXP[i].Text = exp.ToString();
bool? occ = SAV.IsDaycareOccupied(SAV.DaycareIndex, i);
L_SlotOccupied[i].Visible = occ != null;
if (occ == true) // If Occupied
L_SlotOccupied[i].Text = $"{i + 1}: ✓";
else
{
L_SlotOccupied[i].Text = $"{i + 1}: ✘";
SlotPictureBoxes[i + 42].Image = ImageUtil.ChangeOpacity(SlotPictureBoxes[i + 42].Image, 0.6);
}
}
bool? egg = SAV.IsDaycareHasEgg(SAV.DaycareIndex);
DayCare_HasEgg.Visible = egg != null;
DayCare_HasEgg.Checked = egg == true;
var seed = SAV.GetDaycareRNGSeed(SAV.DaycareIndex);
L_DaycareSeed.Visible = TB_RNGSeed.Visible = seed != null;
if (seed != null)
{
TB_RNGSeed.MaxLength = SAV.DaycareSeedSize;
TB_RNGSeed.Text = seed;
}
}
// GTS
if (SAV.HasGTS)
// Recoloring of a storage box slot (to not show for other storage boxes)
if (M?.colorizedslot >= 30)
SlotPictureBoxes[M.colorizedslot].BackgroundImage = M.colorizedcolor;
}
private void ResetNonBoxSlots()
{
ResetParty();
ResetBattleBox();
ResetDaycare();
ResetMiscSlots();
}
private void ResetMiscSlots()
{
if (SAV.HasGTS) // GTS
GetSlotFiller(SAV.GTS, SlotPictureBoxes[44]);
// Fused
if (SAV.HasFused)
if (SAV.HasFused) // Fused
GetSlotFiller(SAV.Fused, SlotPictureBoxes[45]);
// SUBE
if (SAV.HasSUBE)
if (SAV.HasSUBE) // SUBE
for (int i = 0; i < 3; i++)
{
int offset = SAV.SUBE + i * (SAV.SIZE_STORED + 4);
@@ -212,10 +175,61 @@ public void SetPKMBoxes()
GetSlotFiller(offset, SlotPictureBoxes[46 + i]);
else SlotPictureBoxes[46 + i].Image = null;
}
}
// Recoloring of a storage box slot (to not show for other storage boxes)
if (M?.colorizedslot >= 30)
SlotPictureBoxes[M.colorizedslot].BackgroundImage = M.colorizedcolor;
private void ResetParty()
{
if (!SAV.HasParty)
return;
for (int i = 0; i < 6; i++)
GetSlotFiller(SAV.GetPartyOffset(i), SlotPictureBoxes[i + 30]);
}
private void ResetBattleBox()
{
if (!SAV.HasBattleBox)
return;
for (int i = 0; i < 6; i++)
GetSlotFiller(SAV.BattleBox + SAV.SIZE_STORED * i, SlotPictureBoxes[i + 36]);
}
private void ResetDaycare()
{
if (!SAV.HasDaycare)
return;
Label[] L_SlotOccupied = {L_DC1, L_DC2};
TextBox[] TB_SlotEXP = {TB_Daycare1XP, TB_Daycare2XP};
Label[] L_SlotEXP = {L_XP1, L_XP2};
for (int i = 0; i < 2; i++)
{
GetSlotFiller(SAV.GetDaycareSlotOffset(SAV.DaycareIndex, i), SlotPictureBoxes[i + 42]);
uint? exp = SAV.GetDaycareEXP(SAV.DaycareIndex, i);
TB_SlotEXP[i].Visible = L_SlotEXP[i].Visible = exp != null;
TB_SlotEXP[i].Text = exp.ToString();
bool? occ = SAV.IsDaycareOccupied(SAV.DaycareIndex, i);
L_SlotOccupied[i].Visible = occ != null;
if (occ == true) // If Occupied
L_SlotOccupied[i].Text = $"{i + 1}: ✓";
else
{
L_SlotOccupied[i].Text = $"{i + 1}: ✘";
SlotPictureBoxes[i + 42].Image = ImageUtil.ChangeOpacity(SlotPictureBoxes[i + 42].Image, 0.6);
}
}
bool? egg = SAV.IsDaycareHasEgg(SAV.DaycareIndex);
DayCare_HasEgg.Visible = egg != null;
DayCare_HasEgg.Checked = egg == true;
var seed = SAV.GetDaycareRNGSeed(SAV.DaycareIndex);
if (seed != null)
{
TB_RNGSeed.MaxLength = SAV.DaycareSeedSize;
TB_RNGSeed.Text = seed;
}
L_DaycareSeed.Visible = TB_RNGSeed.Visible = seed != null;
}
public void SetParty()
{