Leahnaya/PKHeX
1
0
Fork 0
mirror of https://github.com/kwsch/PKHeX.git synced 2026-08-22 06:57:42 -05:00
Code Issues Actions Packages Projects Releases Wiki Activity

Disallow lang=2 for dp trades

Browse Source 
DP English origin are Japanese language; since we 1=>2, we still needed to disallow 2.
This commit is contained in:
Kurt
2021-03-21 10:34:00 -07:00
parent d6dc8a0410
commit 5ce3d64996
1 changed files with 11 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
PKHeX.Core/Legality/Verifiers/NicknameVerifier.cs
View File

@@ -330,11 +330,18 @@ private static void VerifyTrade4(LegalityAnalysis data, EncounterTrade t)
break;
default:
if (lang == 1 && (pkm.Version is (int)GameVersion.D or (int)GameVersion.P))
if (pkm.Version is (int)GameVersion.D or (int)GameVersion.P && t is EncounterTrade4PID) // mainline DP
{
// DP English origin are Japanese lang
if (pkm.OT_Name != t.GetOT(1)) // not japanese
lang = 2; // English
// DP English origin are Japanese lang. Can't have LanguageID 2
if (lang == 2)
{
data.AddLine(GetInvalid(string.Format(LOTLanguage, Japanese, English), CheckIdentifier.Language));
break;
}
// Since two locales (JPN/ENG) can have the same LanguageID, check which we should be validating with.
if (lang == 1 && pkm.OT_Name != t.GetOT(1)) // not Japanese
lang = 2; // verify strings with English locale instead.
}
break;
}