Fix arrays not being cloned

don't use the existing data array silly -- i was paranoid long ago for a
reason
all other SAV clone methods don't return the Data array, only these
#1764 additional behavior noted
This commit is contained in:
Kurt 2018-01-18 14:05:34 -08:00
parent c015c5a337
commit 2063cef3e4
4 changed files with 4 additions and 4 deletions

View File

@ -43,7 +43,7 @@ public SAV4(byte[] data = null, GameVersion versionOverride = GameVersion.Any)
}
// Configuration
public override SaveFile Clone() { return new SAV4(Data, Version); }
public override SaveFile Clone() { return new SAV4((byte[])Data.Clone(), Version); }
public override int SIZE_STORED => PKX.SIZE_4STORED;
protected override int SIZE_PARTY => PKX.SIZE_4PARTY;

View File

@ -102,7 +102,7 @@ public SAV5(byte[] data = null, GameVersion versionOverride = GameVersion.Any)
}
// Configuration
public override SaveFile Clone() { return new SAV5(Data, Version); }
public override SaveFile Clone() { return new SAV5((byte[])Data.Clone(), Version); }
public override int SIZE_STORED => PKX.SIZE_5STORED;
protected override int SIZE_PARTY => PKX.SIZE_5PARTY;

View File

@ -32,7 +32,7 @@ public SAV6(byte[] data = null)
}
// Configuration
public override SaveFile Clone() { return new SAV6(Data); }
public override SaveFile Clone() { return new SAV6((byte[])Data.Clone()); }
public override int SIZE_STORED => PKX.SIZE_6STORED;
protected override int SIZE_PARTY => PKX.SIZE_6PARTY;

View File

@ -49,7 +49,7 @@ public SAV7(byte[] data = null)
}
// Configuration
public override SaveFile Clone() { return new SAV7(Data); }
public override SaveFile Clone() { return new SAV7((byte[])Data.Clone()); }
public override int SIZE_STORED => PKX.SIZE_6STORED;
protected override int SIZE_PARTY => PKX.SIZE_6PARTY;