Leahnaya/PKHeX
1
0
Fork 0
mirror of https://github.com/kwsch/PKHeX.git synced 2026-08-25 02:55:36 -05:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix block dump changing type on load

Browse Source 
Loading the window and assigning the datasource fired the index changed event, changing the first block (array) to the (selected index of type), which was bool1. Exporting the save caused a bad block type write, yielding a bad size.

Only add the event after the constructor is finished, so that it only fires via user interaction.

Similarly reported but not exactly noticed in #2658
Closes #2663

Gonna update the release with a hotfix
This commit is contained in:
Kurt
2020-01-26 09:24:00 -08:00
parent 4ef48a4e79
commit 1ba271db50
2 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
PKHeX.WinForms/Subforms/Save Editors/Gen8/SAV_BlockDump8.Designer.cs generated
View File

@@ -265,7 +265,6 @@ private void InitializeComponent()
this.CB_TypeToggle.Size = new System.Drawing.Size(97, 21);
this.CB_TypeToggle.TabIndex = 12;
this.CB_TypeToggle.Visible = false;
this.CB_TypeToggle.SelectedIndexChanged += new System.EventHandler(this.CB_TypeToggle_SelectedIndexChanged);
//
// Tab_Compare
//

2
PKHeX.WinForms/Subforms/Save Editors/Gen8/SAV_BlockDump8.cs
View File

@@ -37,6 +37,8 @@ public SAV_BlockDump8(SaveFile sav)
};
CB_TypeToggle.InitializeBinding();
CB_TypeToggle.DataSource = boolToggle;
CB_TypeToggle.SelectedIndexChanged += CB_TypeToggle_SelectedIndexChanged;
}
private void CB_Key_SelectedIndexChanged(object sender, EventArgs e)