Remove duplicate line returns

No functional change, just an OCD nitpick
This commit is contained in:
Kurt
2025-12-01 22:53:27 -06:00
parent 3e1499bdf4
commit 01dc5aa331
10 changed files with 0 additions and 11 deletions

View File

@@ -163,7 +163,6 @@ public void AddExternal(SlotCache first, CheckIdentifier id, int index1, ushort
public void AddExternal(SlotCache first, SlotCache second, CheckIdentifier id, int index1, int index2, ushort identity, ushort argument = 0, Severity s = Severity.Invalid)
=> AddLine(first, second, id, index1, index2, LegalityCheckResultCode.External, identity, argument, s);
private static LegalityAnalysis[] GetIndividualAnalysis(ReadOnlySpan<SlotCache> list)
{
var result = new LegalityAnalysis[list.Length];

View File

@@ -30,7 +30,6 @@ public static uint GetShinyPID(in ushort tid, in ushort sid, in uint pid, in uin
[MethodImpl(MethodImplOptions.AggressiveInlining)]
public static bool GetIsShiny6(in uint id32, in uint pid) => GetShinyXor(id32, pid) < 16;
/// <summary>
/// Checks if the PID is shiny using criteria from Generation 3-5.
/// </summary>

View File

@@ -139,7 +139,6 @@ private void CheckFlagsTM(LegalityAnalysis data, PA9 pa9)
}
}
private void CheckFlagsPlus(LegalityAnalysis la, PA9 pk)
{
var permit = (IPermitPlus)la.PersonalInfo;
@@ -153,7 +152,6 @@ private void CheckFlagsPlus(LegalityAnalysis la, PA9 pk)
var currentLevel = pk.CurrentLevel;
CheckPlusMoveFlags(la, pk, permit, plus, currentLevel);
// Check for indexes set that cannot be set via TM or NPC.
int max = permit.PlusCountUsed;
var evos = la.Info.EvoChainsAllGens.Gen9a;

View File

@@ -47,7 +47,6 @@ private void VerifyEntity(LegalityAnalysis data)
ReadOnlySpan<ushort> moves = [pk.Move1, pk.Move2, pk.Move3, pk.Move4];
ReadOnlySpan<int> pp = [pk.Move1_PP, pk.Move2_PP, pk.Move3_PP, pk.Move4_PP];
if (!Legal.IsPPUpAvailable(pk)) // No PP Ups for format
{
for (int i = 0; i < ups.Length; i++)

View File

@@ -86,7 +86,6 @@ public sealed class SaveBlockAccessor9ZA(SAV9ZA sav) : SCBlockAccessor
private const uint KObstruction = 0x4C26C29B; // (u64, u64-state, u64-unused)[2000]
private const uint KFieldObjectInteractable = 0x7147C953; // (u64,u64,u64,value)[5000] (mega crystal, prize medals)
public const uint KTicketPointsZARoyale = 0x9A730DE1; // u32
public const uint KTicketPointsZARoyaleInfinite = 0x1D7EE369; // u32

View File

@@ -589,7 +589,6 @@ public override int LoadString(ReadOnlySpan<byte> data, Span<char> destBuffer)
public override int SetString(Span<byte> destBuffer, ReadOnlySpan<char> value, int maxLength, StringConverterOption option)
=> StringConverter1.SetString(destBuffer, value, maxLength, Japanese, option);
public static bool IsYellow(ReadOnlySpan<byte> data, bool japanese) => japanese ? IsYellowJPN(data) : IsYellowINT(data);
public static bool IsYellowINT(ReadOnlySpan<byte> data) => IsYellow(data[0x29C3], data[0x271C]);
public static bool IsYellowJPN(ReadOnlySpan<byte> data) => IsYellow(data[0x29B9], data[0x2712]);

View File

@@ -48,7 +48,6 @@ public sealed class PKHeXSettings : IProgramSettings
[Browsable(false)]
public SlotExportSettings SlotExport { get; set; } = new();
[Browsable(false), JsonIgnore]
IStartupSettings IProgramSettings.Startup => Startup;

View File

@@ -161,7 +161,6 @@ private IFashionBlockEditor GetEditor(TabPage selectedTab)
}
}
public IFashionBlockEditor Create(SCBlockAccessor accesor, uint blockLoc, string name, bool hair = false)
{
var tab = GetTab(name);

View File

@@ -75,7 +75,6 @@ private void B_Save_Click(object sender, EventArgs e)
Close();
}
private void ChangeSAV()
{
if (TB_NewSAV.Text.Length != 0 && TB_OldSAV.Text.Length != 0)

View File

@@ -127,7 +127,6 @@ private static void DisplayPluginList(List<IPlugin> plugins)
text.AppendLine($"- {p.Plugin.Name}");
}
WinFormsUtil.Alert(text.ToString());
}