Each run just needs a simple list of things that point to it.
refactor: PointerRuns don't need the model at construction time.
refactor: use a base class to remove duplicate code (IFormattedRun)
-> note that I had to remove EditOnlyNotifiesCollectionChangeOnceWhenScrolling(),
that test is no longer true. Changes to pointers and anchors can change data
elsewhere on screen.
... This additionally requires that the FileName shares its oldValue when it changes.
- All TabContents are ViewModels
- ViewPort should notify when its FileName changes
an argument for closing tabs
- don't do threading work in collection change callbacks. Instead,
do thread switching as early as possible, as soon as I realize that work
needs to be done (in WindowsFileSystem).
- if ConsiderReload is called because of a file change and the file is now
missing, then do nothing.
- if ConsiderReload is called because the file got shorter, update the
Selection.
... because you can have the same file open in two tabs.
- Allow HexContent's ContentChanged to come from a background thread
... important for when the notification comes from a file change
- Allow MainWindow to track deferred work
- Allow Tabs to request delayed work
- Allow EditorViewModel to request delayed work
... because sometimes windows notifies about a file change before the
other application lets go of the file handle.
- IViewPort should actually expose its FileName
... EditorViewModel needs to know a ViewPort's file to setup / tear down
the file watch in IFileSystem
- Implement the reload in ViewPort
... note that the reload can fail if the file is still being edited.
if this happens, then ask the app to retry next time the user clicks.
- 2 more unit tests to capture the desired behavior of requesting delayed work.
first pass at implementing the windows version of the new interface methods
IViewPort now has a public method to call whenever you want to notify it that its underlying file has been changed.
Added 3 tests showing how the Editor and ViewPort should behave with this new functionality.
- Editor should hook up ViewPorts whenever a new tab is opened
- Editor should clear out ViewPorts whenever a tab is closed
- ViewPort should reload when the file is changed and it is not.
Note that the model isn't implemented yet. This is just some failing tests.
Pull out command implementations into helper.
Single-source the list of commands that need to be refreshed on tab change.
Refactor ViewPort constructor.
Pull out command implemenatations into helper.
Use CanAlwaysExecute instead of arg => true
Move CanAlwaysExecute to command extensions.
Change 'EditorNotifiesCanExecuteChangedOnTabChange' to a theory,
so I can more easily add new commands to test for in the future.
Bug fix: EditorViewModel should notify copy/delete commands when tab changes.
CompositeViewPort has correct headers
Find closes after run
CompositeViewPort can scroll now (max scroll is right, notifies work correctly)
Goto and Find Control Visibiilty notify change _after_ updating other control visibilities.
so the control you care about (the one you actively chose to show/hide) gets notified last.
this makes focus work as expected.
Double-clicking in a HexContent follows data links
currently used to open full data when find-tab is double-clicked
added lots of keyboard / menuitem stuff to MainWindow.xaml
