Address review

This commit is contained in:
Miepee 2024-05-30 14:01:29 +02:00
parent 691a5e0baa
commit 6a57490e07
2 changed files with 9 additions and 11 deletions

View File

@ -13,13 +13,11 @@ jobs:
run: dnf install -y gtk3-devel zip
- name: Build
run: ./make-linux.sh
- name: Zip to Archive
run: zip -9 ./linux-x64.zip ./flips
- name: Upload Artifacts
uses: actions/upload-artifact@v4.3.1
with:
name: linux-x64-gui.zip
path: ./linux-x64.zip
path: ./flips
windows:
@ -28,10 +26,8 @@ jobs:
- uses: actions/checkout@v4
- name: Build
run: bash ./make-windows.sh
- name: Zip to Archive
run: 7z a -tzip ./windows-x64.zip ./flips.exe
- name: Upload Artifacts
uses: actions/upload-artifact@v4.3.1
with:
name: windows-x64-gui.zip
path: ./windows-x64.zip
path: ./flips.exe

View File

@ -5,6 +5,11 @@ export LANG=C.UTF-8
echo "This script creates a heavily optimized Windows binary. For debugging you're better off using the Makefile directly."
# Set Windows (with gcc) specific optimization flags. These may need to be revisited when the project is build using MVSC.
FLAGS='-Wall -O3 -flto -fuse-linker-plugin -fomit-frame-pointer -fmerge-all-constants -fvisibility=hidden'
FLAGS=$FLAGS' -fno-exceptions -fno-unwind-tables -fno-asynchronous-unwind-tables'
FLAGS=$FLAGS' -ffunction-sections -fdata-sections -Wl,--gc-sections -fprofile-dir=obj/'
rm floating.zip
rm -r obj/* || true
@ -21,12 +26,9 @@ echo 'Windows (3/3)'
rm flips.exe; make CFLAGS="$FLAGS -fprofile-use -s"
# CI currently has invalid dependencies. Unsure if ok or not.
ERROR_CODE_ON_INVALID_DEPENDENCIES=1
if [ -z ${IGNORE_ON_INVALID_DEPENDENCIES} ]; then ERROR_CODE_ON_INVALID_DEPENDENCIES=0; fi
#verify that there are no unexpected dependencies
objdump -p flips.exe | grep 'DLL Name' | \
grep -Pvi '(msvcrt|advapi32|comctl32|comdlg32|gdi32|kernel32|shell32|user32)' && \
echo "Invalid dependency" && exit $ERROR_CODE_ON_INVALID_DEPENDENCIES
grep -Pvi '(msvcrt|advapi32|comctl32|comdlg32|gdi32|kernel32|shell32|user32|api-ms-win-crt)' && \
echo "Invalid dependency" && exit 1