38 Commits

Author	SHA1	Message	Date
BruebachL	c4316c40e9	[CI] Remove Qt5 (#7071) ... * [CI] Remove Qt5 Took 10 minutes Took 9 minutes * Revert CI failure and fix up comments Took 4 minutes --------- Co-authored-by: Lukas Brübach <Bruebach.Lukas@bdosecurity.de>	2026-08-08 22:04:50 +02:00
BruebachL	59d90db3c7	Define Cockatrice as an editor/handler for .cod files and cockatrice:// protocol on all platforms (#6775) ... * [Application] Add single instance guard and mime types. Took 2 hours 39 minutes Took 18 minutes Took 5 minutes Took 12 seconds Took 11 seconds * Rework Took 30 minutes Took 50 seconds * Only enforce single instance if launched with arguments. Took 5 minutes * Prototype intents Took 53 minutes Took 6 seconds * Connect/disconnect and join game/room intents. Took 3 hours 14 minutes Took 2 seconds Took 15 seconds * Fix include. Took 1 minute Took 23 seconds Took 2 seconds * Mac handling. Took 10 minutes Took 12 seconds Took 3 minutes * Lint. Took 3 minutes * Rebase. Took 3 minutes Took 17 seconds * Implement UrlSchemeEventFilter Took 10 minutes Took 7 seconds * Qt Moc Took 3 minutes * Modern PList. Took 21 minutes Took 1 minute * Debug output. Took 6 minutes Took 19 minutes * Watch file:// prefix. Took 15 minutes Took 7 seconds * Better handler. Took 6 minutes * Don't store reference in member Took 5 minutes * Move impl to cpp, fix lifetime issues. Took 11 minutes Took 2 minutes * Better single-instance handoff, url intent harded copy game link context-menu Polish for installers Took 35 minutes Took 8 seconds --------- Co-authored-by: Lukas Brübach <Bruebach.Lukas@bdosecurity.de>	2026-08-08 19:02:19 +02:00
BruebachL	27fb5e51de	[Security] Redact sensitive user data from client-visible responses (#7077) ... The getUserInfo command for a user that is not currently online returned the full database record, including the account id, the email address and the stored client id, to any logged-in requester. Mirror the redaction already applied to online users via copyUserInfo(): the id and email are only ever exposed to the account owner, and the client id only to moderators. The buddy/ignore add-to-list event likewise returned the target user's email address and client id to the requester. The list entry only needs the public profile fields, so strip the email and client id from it as well. Co-authored-by: Lukas Brübach <Bruebach.Lukas@bdosecurity.de>	2026-08-08 17:32:39 +02:00
BruebachL	61b9d7abf6	[Networking] Doxygen (#7030) ... * [Networking] Doxygen * Lint cause my autolinter is broken lol * Update. * Update Doxyfile Co-authored-by: tooomm <tooomm@users.noreply.github.com> * Alphabetical ordering Co-authored-by: tooomm <tooomm@users.noreply.github.com> * Add new card art rule comment * move filter program into doxygen folder * [Networking] Doxygen Took 49 seconds * [Networking] Doxygen Took 2 hours 0 minutes Took 58 minutes Took 8 seconds Took 29 seconds Took 4 minutes Took 1 minute Took 4 minutes * [Networking] Fix Doxyfile Took 2 hours 0 minutes Took 58 minutes Took 8 seconds Took 29 seconds Took 4 minutes Took 1 minute Took 6 minutes * [Networking] Fix Doxyfile Took 2 hours 0 minutes Took 58 minutes Took 8 seconds Took 29 seconds Took 4 minutes Took 1 minute Took 3 minutes * [Networking] Fix Doxyfile again Took 2 hours 0 minutes Took 58 minutes Took 8 seconds Took 29 seconds Took 4 minutes Took 1 minute Took 2 minutes --------- Co-authored-by: Lukas Brübach <lukas.bruebach@bdosecurity.de> Co-authored-by: tooomm <tooomm@users.noreply.github.com> Co-authored-by: Lukas Brübach <Bruebach.Lukas@bdosecurity.de>	2026-07-27 11:27:00 +02:00
DawnFire42	18b23b19a7	Split trice_limits.h into dedicated headers (#7025) ... * Split trice_limits.h into dedicated headers * Updated docstrings	2026-06-29 14:37:52 -07:00
DawnFire42	05ae6f47a6	Unify counter clamp arithmetic into shared addClamped() helper (#7009) ... * Unify counter clamp arithmetic into shared addClamped() helper - Add addClamped() in new header clamped_arithmetic.h; uses a 64-bit intermediate so the addition cannot overflow int. - Use it in Server_Card::incrementCounter() (clamps [0, MAX_COUNTERS_ON_CARD]) and Server_Counter::incrementCount() (clamps [INT_MIN, INT_MAX]), removing the duplicated overflow-safe logic and its keep-in-sync TODO. - Inline incrementCount() into server_counter.h; server_counter.cpp now holds only the constructor and getInfo(). - Clarify the card-counter bounds comment in trice_limits.h. * Rename MAX_COUNTERS_ON_CARD to MAX_COUNTER_VALUE The constant caps the counter's value, not how many counters can be on the card * Add direct unit tests for addClamped() helper * Harden offsetCardCounter() against signed-int overflow Replace the raw oldValue + offset sum with addClamped(), clamping to [0, MAX_COUNTER_VALUE] without overflow. * Comment update * Remove class names from addClamped() docstring	2026-06-28 16:10:57 -07:00
BruebachL	2914874720	[Room][UserList] Introduce style delegate (#6981) ... * [Room] Additionally show a tab for friends and ignored users instead of just all online users. Took 21 minutes Took 12 minutes * [Room][UserList] Introduce style delegate for user list - Allow users to set a card name and parameters as their background banner - Allow mods to white/blacklist cards - Allow toggling back to the old display style Took 7 minutes Took 28 seconds Took 2 minutes Took 2 minutes * Right checkstate. Took 14 minutes Took 2 minutes * Utility for test. Took 9 minutes Took 8 seconds Took 2 seconds * Lint. Took 10 minutes * Algorithm for sql schema migration Took 13 minutes * Use {prefix}, bound card name, return errors. Took 27 seconds * Convert queue to while loop. Took 19 seconds * Hover popup. Took 36 minutes Took 1 minute * More granular signals, popup for user info. Took 25 minutes Took 8 seconds Took 16 minutes --------- Co-authored-by: Lukas Brübach <Bruebach.Lukas@bdosecurity.de>	2026-06-26 20:52:24 -04:00
BruebachL	23da49ee5b	[Game] [Arrows] Use arrowData/registry and generate unique server-side ids (#6973) ... * [Game] [Arrows] Track creatorId, use arrowData in arrowItem, use registry, generate unique arrow id's on server side and delete-on-exist inserts. Took 2 minutes Took 1 minute * Fix emitting slot instead of signal. Took 15 minutes * Clear arrows locally in special circumstances i.e. teardown. Took 28 minutes --------- Co-authored-by: Lukas Brübach <Bruebach.Lukas@bdosecurity.de>	2026-06-07 21:11:02 +02:00
BruebachL	90ab663212	[Server][Game][Arrows] Properly notify clients when deleting arrows on card move and transform into (#6936) ... * [Server][Game][Arrows] Properly notify clients when deleting arrows on card move and transform into Took 15 minutes * Observe "not found" response Took 18 minutes Took 4 seconds --------- Co-authored-by: Lukas Brübach <Bruebach.Lukas@bdosecurity.de>	2026-05-25 08:19:17 +02:00
DawnFire42	8dca14933c	Centralize counter API with server-side bounds and no-op filtering (#6879) ... * Refactor server counter API to own overflow protection and filter no-op events Counter modifications now clamp to int bounds server-side and return change status, allowing command handlers to skip network broadcasts when values don't actually change. * Centralize MAX_COUNTERS_ON_CARD and enforce [0, 999] bounds on server - Move MAX_COUNTERS_ON_CARD to trice_limits.h - Server clamps values in setCounter() and incrementCounter() - Client uses clamped comparison to allow recovery from invalid states - Add tests for clamping behavior * move incrementCount() implementation from header to cpp	2026-05-21 20:39:35 -07:00
DawnFire42	33e0f8699b	Standardize Doxygen documentation (#6885)	2026-05-21 22:58:07 +02:00
RickyRister	10b9a65f17	[Server][Game] Make undo draw failure visible in chat (#6889) ... * [Server][Game] Make undo draw failure visible in chat * genericize the proto	2026-05-20 02:23:02 -07:00
ebbit1q	20cd7ce73d	fix arch compiling (#6895)	2026-05-16 19:39:34 +02:00
DawnFire42	aadee34238	style: Add braces to all control flow statements (#6887) ... * style: Add braces to all control flow statements Standardize code style by adding explicit braces to all single-statement control flow blocks (if, else, for, while) across the entire codebase. Also documents the InsertBraces clang-format option (requires v15+) for future automated enforcement. * InsertBraces-check-enabled	2026-05-16 19:19:53 +02:00
ebbit1q	45ab2602c6	ensure judges are omniscient when not spectating (#6831)	2026-04-30 14:31:28 +02:00
Vorliz	a20f3c0fb4	Fix #6659: Correct logging for bottom-of-library card moves (#6764) ... * Fix #6659: Correct logging for bottom-of-library card moves Cause: - This issue happens due to logic of moving the card from the top of the deck being reused when moving from the bottom of the deck, in a way that makes it impossible to check if the card came from the bottom. Resolution: - Updated the logging logic in the client for card moves. - Added a gRPC parameter ('is_from_bottom') for card moves. - Updates the server logic to reverse the order of the card move if the 'is_from_bottom' parameter is true. - Added a test to show the expected behaviour of the fix. NOTE: While the changes in this patch seem big, this is due to changing the loop in the moveCard function to a helper function, in order to make the bug fix change. The only change to the loop was to pass a variable attribution to the moveCard function because it was redundant to be in the loop. * chore: run format on test * refactor: new way to check if a move is from the bottom of the deck * refactor: change isFromBottom check to static function * update comments Co-authored-by: ebbit1q <ebbit1q@gmail.com> --------- Co-authored-by: ebbit1q <ebbit1q@gmail.com>	2026-04-21 19:05:31 +02:00
ebbit1q	3ec9ae9772	fix compiling on arch (#6768) ... * fix compiling on arch * redo all the logging in affected files	2026-04-05 21:52:46 +02:00
DawnFire42	9e2276a59f	Refactor zone names (#6686) ... * Add ZoneNames constants for protocol zone identifiers. Introduce a centralized ZoneNames namespace providing constexpr constants for zone identifiers used in the client-server protocol. This establishes a single source of truth for zone names like TABLE, GRAVE, EXILE, HAND, DECK, SIDEBOARD, and STACK. The protocol values remain unchanged (e.g., EXILE maps to rfg for backwards compatibility) while providing meaningful constant names. * refactor(server): use ZoneNames constants in server game logic Replace hardcoded zone name strings with ZoneNames:: constants in: - server_player.cpp: zone setup, draw, shuffle, mulligan operations - server_abstract_player.cpp: card movement and token destruction - server_game.cpp: returning cards when players leave No functional changes - purely mechanical string literal replacement. * refactor(client): use ZoneNames constants in core player/zone logic Update the foundational player and zone classes to use ZoneNames:: constants instead of string literals. Changes include: - player.h/cpp: zone initialization and builtinZones set - card_zone_logic.cpp: zone name translation for UI display - table_zone.cpp: table zone operations No functional changes - purely mechanical string literal replacement. * refactor(client): use ZoneNames constants in player actions and events Replace zone name strings with ZoneNames:: constants in the player action and event handling code. player_actions.cpp contains the most extensive changes (~90+ replacements) covering all card movement commands. No functional changes - purely mechanical string literal replacement. * refactor(client): use ZoneNames constants in zone menu handlers Update all zone-specific menu files to use ZoneNames:: constants for QAction data values and zone targeting. This covers context menus for cards, graveyard, hand, and exile (RFG) zones. No functional changes - purely mechanical string literal replacement. * refactor(client): use ZoneNames constants in game scene components Update remaining game scene components to use ZoneNames:: constants: - arrow_item.cpp: arrow drawing between cards - game_scene.cpp: zone view positioning - message_log_widget.cpp: removes duplicate local static constants that were previously defining zone names redundantly - phases_toolbar.cpp: phase actions (untap all) Notable: message_log_widget.cpp previously had its own local constants (TABLE_ZONE_NAME, GRAVE_ZONE_NAME, etc.) which are now removed in favor of the centralized ZoneNames:: constants. * formatting fix	2026-03-12 00:34:05 +01:00
RickyRister	2828854d32	[Server] Support face-down cards in all public zones (#6539) ... * [Server] Support face-down cards in all public zones * add null check * Check using zone names instead * add comment	2026-03-03 23:17:35 +01:00
ebbit1q	afdb385770	move returning cards to server_game (#6561) ... lock the game mutex instead of player mutex when returning cards	2026-01-24 12:54:29 -05:00
RickyRister	731c487ccb	[ServerGame] null check participant in getPlayer (#6493)	2026-01-05 01:43:40 -05:00
RickyRister	2d5e8deb75	[Server_AbstractParticipant] Rename bool getters (#6492) ... * [Server_AbstractParticipant] Rename bool getters * reformat	2026-01-05 00:34:32 -05:00
RickyRister	70f9982c29	Bump minimum Qt version from 5.8 to 5.15 (#6442) ... * Bump minimum Qt version from 5.8 to 5.15 * remove version check * remove version checks	2025-12-23 09:58:23 -08:00
tooomm	8485bbe575	Docs: Use Doxygen \todo comments (#6421) ... * format todo comments for doxygen * Mention Todo List & link search	2025-12-15 00:13:16 +01:00
RickyRister	2e2682aad4	[DeckList] Refactor and cleanup methods that iterate over nodes (#6407) ... * remove helpers * create getZoneNodes method * replace direct calls to getRoot and forEachCard * remove more non-const uses of forEachCard * make node getter return const lists * one more usage * address comment * address comment again * fix hash * fix hashes (for real this time)	2025-12-12 12:37:44 -08:00
RickyRister	d57bec8ec6	[DeckList] Move decklist node classes into new folder (#6381) ... * [DeckList] Move decklist node classes into new folder * reformat * fix	2025-11-30 13:05:49 +01:00
BruebachL	c5fde071e7	[Cleanup] Unused #includes (#6367) ... * [Cleanup] Unused #includes Took 44 minutes * [Cleanup] More unused #includes Took 55 minutes * [Cleanup] Include QSet Took 4 minutes * [Cleanup] Include QDebug in deck_list.cpp Took 3 minutes * [Cleanup] Include protocol stuff in servatrice_database_interface.h Took 3 minutes * [Cleanup] Include QDialogButtonBox Took 8 minutes * [Cleanup] Include QUrl Took 8 minutes * [Cleanup] Include QTextOption in header. Took 3 minutes * [Cleanup] Include QMap in user_list_manager.h Took 8 minutes * [Cleanup] Adjust qjson Took 8 minutes * [Cleanup] include button box. Took 3 minutes * [Cleanup] Redo fwd declarations. * [Cleanup] Redo last removed fwd declarations. --------- Co-authored-by: Lukas Brübach <Bruebach.Lukas@bdosecurity.de>	2025-11-29 18:53:11 +01:00
BruebachL	8abd04dab1	[Fix-Warnings] Remove more redundant empty declarations. (extra semicolons) (#6374)	2025-11-29 14:19:11 +01:00
ebbit1q	65aef396fb	do not allow other players to know which cards are in a player's hand (#6125)	2025-11-26 09:16:50 -05:00
ebbit1q	a21e45ed36	add phase to delete arrows in to protocol (#6159) ... * protocol changes * servatrice changes * add new setting * implement client side with static 4 phases * reading the code explains the code * add subphases to phase.cpp * use new subphase definition	2025-11-26 09:16:10 -05:00
BruebachL	73763b5ee6	Mark more functions as [[nodiscard]] (#6320) ... * Fix local variable double declaration. Took 44 seconds * Mark functions as [[nodiscard]] Took 31 minutes --------- Co-authored-by: Lukas Brübach <Bruebach.Lukas@bdosecurity.de>	2025-11-16 01:39:24 +01:00
BruebachL	5df00de246	Avoid repeating type by using auto. (#6321) ... Took 19 minutes Took 22 seconds Co-authored-by: Lukas Brübach <Bruebach.Lukas@bdosecurity.de>	2025-11-15 14:06:53 +01:00
ebbit1q	648f028a63	fix use of wrong parent when removing arrows for a player (#6308)	2025-11-12 04:48:26 +01:00
ebbit1q	840ee1379f	fix crash on force starting, kicking players (#6307) ... * fix crash on force starting, kicking players * Update server_game.cpp --------- Co-authored-by: Zach H <zahalpern+github@gmail.com>	2025-11-12 04:44:58 +01:00
BruebachL	7d2700ca65	Clean up link targets. (#6304) ... Took 38 minutes Co-authored-by: Lukas Brübach <Bruebach.Lukas@bdosecurity.de>	2025-11-11 14:04:14 +01:00
BruebachL	a8a3fca8c9	Clean up inter-library dependencies with interfaces (#6280) ... * Have CardDatabase::getPreferredPrintingInfo respect card provider ID overrides (pinned printings) Took 13 minutes Took 37 seconds Took 10 seconds Took 10 seconds # Commit time for manual adjustment: # Took 30 seconds Took 15 seconds Took 8 minutes Took 21 seconds * Move settings cache and settings card preference provider out of libcockatrice_settings and into cockatrice Took 52 minutes Took 9 minutes Took 1 minute * Temp cache. Took 16 minutes * Dependency Injection for SettingsCache * Turn SettingsCache into a QSharedPointer. * Implement interfaces for settings that need it Took 2 hours 38 minutes * Adjust oracle. Took 5 minutes * Move abstract/noop interfaces to libcockatrice_interfaces so they can be linked against independently. Took 52 minutes * Clean up some links. Took 3 minutes * Cleanup two includes. Took 3 minutes * More fixes. Took 7 minutes * More includes that slipped past. Took 3 minutes * Stop mocking and start injecting for tests. Took 15 minutes * I don't know why remote_client was including main. Took 4 minutes * Include. Took 3 minutes * Lint. Took 2 minutes * Don't use Qt pointers. Took 1 hour 7 minutes * Make parser use CardSettingsInterface Took 13 minutes * Also adjust constructor lol. Took 8 minutes * Lint. Took 32 minutes * Revert "Lint." This reverts commit ecb596c39e. Took 3 minutes * Test. Took 3 minutes --------- Co-authored-by: Lukas Brübach <Bruebach.Lukas@bdosecurity.de>	2025-11-08 22:19:40 +01:00
ebbit1q	d206a70b8a	update format.sh (#6240) ... * update format.sh add shellcheck to format.sh add statement macros to .clang-format add no clang format to format.sh add changed file list to format.sh diff rename --cf-version to --print-version in format.sh lint files * enable --shell on ci runs * remove useless semicolons removes the semicolons after empty function definitions these semicolons are optional, they don't do anything this will have functions be consistently formatted if we want to keep the option to have these on the same line like they were before we should use the option AllowShortFunctionsOnASingleLine: None * fix script * update echo line in lint_cpp.sh which doesn't lint cpp only at all	2025-11-07 15:00:39 +01:00
BruebachL	1ef07309d6	Turn Card, Deck_List, Protocol, RNG, Network (Client, Server), Settings and Utility into libraries and remove cockatrice_common. (#6212) ... --------- Co-authored-by: Lukas Brübach <Bruebach.Lukas@bdosecurity.de> Co-authored-by: ebbit1q <ebbit1q@gmail.com>	2025-10-09 07:36:12 +02:00