Leahnaya/Cockatrice
1
0
Fork 0
mirror of https://github.com/Cockatrice/Cockatrice.git synced 2026-08-20 07:45:17 -05:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

[Refactor] Batch CardDatabaseModel enabled-sets rebuild into one model reset (#7113)

Browse Source 
Co-authored-by: Lukas Brübach <Bruebach.Lukas@bdosecurity.de>
This commit is contained in:
BruebachL
2026-08-14 09:03:24 +02:00
committed by GitHub
parent d93f63050c
commit 1eca89d75a
1 changed files with 38 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

45
libcockatrice_models/libcockatrice/models/database/card_database_model.cpp
View File

@@ -111,19 +111,50 @@ bool CardDatabaseModel::checkCardHasAtLeastOneEnabledSet(const CardInfoPtr &card
void CardDatabaseModel::cardDatabaseEnabledSetsChanged()
{
// remove all the cards no more present in at least one enabled set
// Build the new card list in a single pass.
QList<CardInfoPtr> newCardList;
newCardList.reserve(cardList.size());
for (const CardInfoPtr &card : cardList) {
if (!checkCardHasAtLeastOneEnabledSet(card)) {
cardRemoved(card);
if (checkCardHasAtLeastOneEnabledSet(card)) {
newCardList.append(card);
}
}
for (const CardInfoPtr &card : db->getCardList()) {
if (!cardListSet.contains(card) && checkCardHasAtLeastOneEnabledSet(card)) {
newCardList.append(card);
}
}
// re-check all the card currently not shown, maybe their part of a newly-enabled set
for (const CardInfoPtr &card : db->getCardList()) {
if (!cardListSet.contains(card)) {
cardAdded(card);
if (newCardList == cardList) {
return;
}
// Rebuild the whole list inside a single model reset instead of emitting
// per-card insert/remove notifications. With tens of thousands of cards the
// per-card path is the dominant cost of constructing a CardDatabaseModel.
QSet<CardInfoPtr> oldCardListSet = cardListSet;
QSet<CardInfoPtr> newCardListSet(newCardList.begin(), newCardList.end());
beginResetModel();
// Disconnect cards that are no longer shown.
for (const CardInfoPtr &card : cardList) {
if (!newCardListSet.contains(card)) {
disconnect(card.data(), nullptr, this, nullptr);
}
}
cardList = newCardList;
cardListSet = newCardListSet;
// Connect cards that are now shown for the first time.
for (const CardInfoPtr &card : cardList) {
if (!oldCardListSet.contains(card)) {
connect(card.data(), &CardInfo::cardInfoChanged, this, &CardDatabaseModel::cardInfoChanged);
}
}
endResetModel();
}
void CardDatabaseModel::cardAdded(const CardInfoPtr &card)