Leahnaya/Cockatrice
1
0
Fork 0
mirror of https://github.com/Cockatrice/Cockatrice.git synced 2026-03-21 17:55:21 -05:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

[VDS] Try to fix memory leak by properly parenting widgets (#6498)

Browse Source 
* [VDS] Try to fix memory leak by properly parenting widgets

* format
This commit is contained in:
RickyRister 2026-01-06 02:42:35 -08:00 committed by GitHub
parent b86853b65c
commit 0a2fdb05ad
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
cockatrice/src/interface/widgets/cards/card_info_picture_widget.cpp
View File

@ -47,7 +47,7 @@ CardInfoPictureWidget::CardInfoPictureWidget(QWidget *parent, const bool _hoverT
originalPos = this->pos();
// Create the animation
animation = new QPropertyAnimation(this, "pos");
animation = new QPropertyAnimation(this, "pos", this);
animation->setDuration(200); // 200ms animation duration
animation->setEasingCurve(QEasingCurve::OutQuad);

2
cockatrice/src/interface/widgets/visual_deck_storage/deck_preview/deck_preview_widget.cpp
View File

@ -92,7 +92,7 @@ void DeckPreviewWidget::initializeUi(const bool deckLoadSuccess)
bannerCardComboBox->setSizePolicy(QSizePolicy::Minimum, QSizePolicy::Minimum);
bannerCardComboBox->setObjectName("bannerCardComboBox");
bannerCardComboBox->setCurrentText(deckLoader->getDeck().deckList.getBannerCard().name);
bannerCardComboBox->installEventFilter(new NoScrollFilter());
bannerCardComboBox->installEventFilter(new NoScrollFilter(bannerCardComboBox));
connect(bannerCardComboBox, QOverload<int>::of(&QComboBox::currentIndexChanged), this,
&DeckPreviewWidget::setBannerCard);

5
cockatrice/src/interface/widgets/visual_deck_storage/deck_preview/deck_preview_widget.h
View File

@ -82,6 +82,11 @@ private slots:
class NoScrollFilter : public QObject
{
Q_OBJECT
public:
explicit NoScrollFilter(QObject *parent = nullptr) : QObject(parent)
{
}
protected:
bool eventFilter(QObject *obj, QEvent *event) override
{