From f85f86825804b24dedd5503a84e809bfde4c0668 Mon Sep 17 00:00:00 2001 From: MikeIsAStar <99037623+MikeIsAStar@users.noreply.github.com> Date: Sat, 16 Dec 2023 16:00:00 -0500 Subject: [PATCH] SAKE: Don't panic when invalid XML is received --- sake/storage.go | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/sake/storage.go b/sake/storage.go index 571c253..6ca5028 100644 --- a/sake/storage.go +++ b/sake/storage.go @@ -123,13 +123,12 @@ func handleStorageRequest(moduleName string, w http.ResponseWriter, r *http.Requ panic(err) } - // logging.Notice(moduleName, string(body)) - // Parse the SOAP request XML soap := StorageRequestEnvelope{} err = xml.Unmarshal(body, &soap) if err != nil { - panic(err) + logging.Error(moduleName, "Received invalid XML") + return } response := StorageResponseEnvelope{ @@ -172,7 +171,6 @@ func handleStorageRequest(moduleName string, w http.ResponseWriter, r *http.Requ } payload := append([]byte(``), out...) - // logging.Notice(moduleName, string(payload)) w.Header().Set("Content-Type", "text/xml") w.Header().Set("Content-Length", strconv.Itoa(len(payload)))