Leahnaya/splatoon3.ink
1
0
Fork 0
mirror of https://github.com/misenhower/splatoon3.ink.git synced 2026-04-27 08:17:00 -05:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Remove inline base64 image embedding from iCal output

Browse Source 
No major calendar client renders these inline binary attachments.
The ATTACH URL is kept, which links to the publicly hosted image.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Matt Isenhower 2026-02-22 09:44:04 -08:00
parent e6e96ac8f9
commit 7125f30bfc
1 changed files with 5 additions and 31 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
app/data/updaters/DataUpdater.mjs
View File

@ -89,13 +89,13 @@ export default class DataUpdater
await this.updateLocalizations(this.defaultLocale, data); await this.updateLocalizations(this.defaultLocale, data);
// Download any new images // Download any new images
const images = await this.downloadImages(data); await this.downloadImages(data);
// Write the data to disk // Write the data to disk
await this.saveData(data); await this.saveData(data);
// Update iCal data // Update iCal data
await this.updateCalendarEvents(data, images); await this.updateCalendarEvents(data);
this.console.info('Done'); this.console.info('Done');
} }
@ -223,11 +223,11 @@ export default class DataUpdater
// Calendar output // Calendar output
async updateCalendarEvents(data, images) { async updateCalendarEvents(data) {
const events = this.getCalendarEntries(data); const events = this.getCalendarEntries(data);
if (!events) return; if (!events) return;
const ical = await this.getiCalData(events, images); const ical = await this.getiCalData(events);
await this.writeFile(this.getCalendarPath(this.calendarFilename ?? this.filename), ical); await this.writeFile(this.getCalendarPath(this.calendarFilename ?? this.filename), ical);
} }
@ -239,7 +239,7 @@ export default class DataUpdater
// //
} }
async getiCalData(events, images) { async getiCalData(events) {
// Create a calendar object // Create a calendar object
const calendar = ical({ const calendar = ical({
name: this.calendarName ?? this.name, name: this.calendarName ?? this.name,
@ -252,9 +252,6 @@ export default class DataUpdater
timezone: 'UTC', timezone: 'UTC',
}); });
// Create a map of image URLs to image data
const imageData = {};
// Add event entries // Add event entries
for (let event of events) { for (let event of events) {
let calEvent = calendar.createEvent({ let calEvent = calendar.createEvent({
@ -265,34 +262,11 @@ export default class DataUpdater
url: event.url, url: event.url,
}); });
calEvent.createAttachment(event.imageUrl); calEvent.createAttachment(event.imageUrl);
const filename = images[event.imageUrl];
if (filename) {
try {
const data = await fs.readFile(this.imageProcessor.localPath(filename));
imageData[event.imageUrl] = data;
} catch {
// Image not available locally (may only exist in S3); skip inline embed
}
}
} }
// Convert the calendar to an ICS string // Convert the calendar to an ICS string
let ics = calendar.toString(); let ics = calendar.toString();
// Embed image attachments
ics = ics.replaceAll(/^ATTACH:((.|\r\n )*)$/gm, (match, url) => {
url = url.replaceAll('\r\n ', '');
const filename = images[url];
const data = imageData[url];
if (!filename || !data) return match;
const ical = `ATTACH;ENCODING=BASE64;VALUE=BINARY;X-APPLE-FILENAME=${path.basename(filename)}:${data.toString('base64')}`;
return ical.replace(/(.{72})/g, '$1\r\n ').trim();
});
return ics; return ics;
} }
} }