mirror of
https://github.com/Sendouc/sendou.ink.git
synced 2026-05-11 05:05:07 -05:00
2da0738dc6
* Added Ability Chunks Required section in Build Analyzer * Renamed a variable to be more precisely correct * Added reference * Removed some extra Javadoc comments * Prettier fix * We now only render the AbilityChunksRequired section only if the main abilities array contains a value other than "UNKNOWN" * Improved React keys naming for performance reasons * Ability Chunks map is now converted to an array & sorted by value (descending) before it gets rendered as visual components * Fixed typing error * Moved logical function to a new file in the analyzer module called abilityChunksCalc.ts - Refactored for loop content to be cleaner - Removed & changed some comments * More for loop refactoring * We now pass the entire build into abilityChunksCalc.ts * Refactored map() to flatMap() so we avoid unknowns/null/undefined * Refactored code to process mainAbilities and subAbilities * Fixed subability list construction logic & typing in updateAbilityChunksMap() * Got my first unit test working * Added working unit tests, also changed sort order slightly * Added a "real" build for testing * Removed residual console.warn() call * Moved constants to abilityChunksCalc.ts * Ability chunk calculation is now correct for sub abilities * Uncommented tests & improved their descriptions * Rearranged expected output to match sorted order for clarity (even though it doesn't have to be) * Fixed Prettier error * Spacing * Moved comments around * More spacing * Prettier error on test file * Improved check in the tests * Added a second "real" build to tests for good measure * Added error message to empty array test * Updated comments again * More comments updated * Update test name * Ability Chunks section is now shown if we have at least one selected ability (handles edge case for primary slot-only abilities being the only chosen ability) |
||
|---|---|---|
| .. | ||
| ability-values.json | ||
| abilityChunksCalc.test.ts | ||
| abilityChunksCalc.ts | ||
| constants.ts | ||
| index.ts | ||
| object-dmg.json | ||
| objectDamage.test.ts | ||
| objectDamage.ts | ||
| objectHitPoints.ts | ||
| specialEffects.test.ts | ||
| specialEffects.ts | ||
| stats.test.ts | ||
| stats.ts | ||
| types.ts | ||
| useAnalyzeBuild.ts | ||
| useObjectDamage.ts | ||
| utils.test.ts | ||
| utils.ts | ||
| weapon-params.json | ||