From f574a1985c36a078e274c358b0cac455f28bf4b1 Mon Sep 17 00:00:00 2001
From: "Kalle (Sendou)" <38327916+Sendouc@users.noreply.github.com>
Date: Mon, 6 Dec 2021 12:45:08 +0200
Subject: [PATCH] Show alert if team full

---
 app/components/Alert.tsx                      |   2 +-
 .../manage-roster.tsx                         | 112 ++++++++++--------
 app/styles/global.css                         |   5 +
 3 files changed, 66 insertions(+), 53 deletions(-)

diff --git a/app/components/Alert.tsx b/app/components/Alert.tsx
index a555a0244..3e05634ac 100644
--- a/app/components/Alert.tsx
+++ b/app/components/Alert.tsx
@@ -2,7 +2,7 @@ import { AlertIcon } from "./icons/Alert";
 
 export function Alert(props: {
   children: React.ReactNode;
-  type: "warning";
+  type: "warning" | "info";
   "data-cy"?: string;
 }) {
   return (
diff --git a/app/routes/to/$organization.$tournament/manage-roster.tsx b/app/routes/to/$organization.$tournament/manage-roster.tsx
index e11a3dbc2..903b0e46a 100644
--- a/app/routes/to/$organization.$tournament/manage-roster.tsx
+++ b/app/routes/to/$organization.$tournament/manage-roster.tsx
@@ -125,69 +125,77 @@ export default function ManageRosterPage() {
 
   return (
     <div className="tournament__manage-roster">
-      {ownTeam.members.length < 4 && (
+      {ownTeam.members.length < TOURNAMENT_TEAM_ROSTER_MIN_SIZE && (
         // TODO: show alert when team is full
         <Alert type="warning" data-cy="team-size-alert">
           You need at least {TOURNAMENT_TEAM_ROSTER_MIN_SIZE} players in your
           roster to play (max {TOURNAMENT_TEAM_ROSTER_MAX_SIZE})
         </Alert>
       )}
+      {ownTeam.members.length >= TOURNAMENT_TEAM_ROSTER_MAX_SIZE && (
+        // TODO: show alert when team is full
+        <Alert type="info" data-cy="team-size-alert">
+          Your team is full - more players can't be added
+        </Alert>
+      )}
       <div className="tournament__manage-roster__roster-container">
         <TeamRoster team={ownTeam} />
       </div>
-      <div className="tournament__manage-roster__actions">
-        <div className="tournament__manage-roster__actions__section">
-          <label htmlFor="inviteCodeInput">
-            Share this URL to invite players to your team
-          </label>
-          <input
-            id="inviteCodeInput"
-            className="tournament__manage-roster__input"
-            disabled
-            value={urlWithInviteCode}
-          />
-          <button
-            className="tournament__manage-roster__input__button"
-            onClick={() => {
-              navigator.clipboard.writeText(urlWithInviteCode);
-              setShowCopied(true);
-            }}
-            type="button"
-          >
-            {showCopied ? "Copied!" : "Copy to clipboard"}
-          </button>
-        </div>
-        {trustingUsers.length > 0 && (
+      {ownTeam.members.length < TOURNAMENT_TEAM_ROSTER_MAX_SIZE && (
+        <div className="tournament__manage-roster__actions">
           <div className="tournament__manage-roster__actions__section">
-            <MyForm hiddenFields={{ teamId: ownTeam.id }}>
-              <label htmlFor="userId">
-                Add players you previously played with
-              </label>
-              <select
-                className="tournament__manage-roster__select"
-                name="userId"
-                id="userId"
-                defaultValue={actionData?.fields?.userId}
-              >
-                {trustingUsers.map(({ trustGiver }) => (
-                  <option key={trustGiver.id} value={trustGiver.id}>
-                    {trustGiver.discordName}
-                  </option>
-                ))}
-              </select>
-              <ErrorMessage errorMsg={actionData?.fieldErrors?.userId} />
-              <Button
-                className="tournament__manage-roster__input__button"
-                type="submit"
-                loadingText="Adding..."
-                loading={transition.state !== "idle"}
-              >
-                Add to roster
-              </Button>
-            </MyForm>
+            <label htmlFor="inviteCodeInput">
+              Share this URL to invite players to your team
+            </label>
+            <input
+              id="inviteCodeInput"
+              className="tournament__manage-roster__input"
+              disabled
+              value={urlWithInviteCode}
+            />
+            <button
+              className="tournament__manage-roster__input__button"
+              onClick={() => {
+                navigator.clipboard.writeText(urlWithInviteCode);
+                setShowCopied(true);
+              }}
+              type="button"
+            >
+              {showCopied ? "Copied!" : "Copy to clipboard"}
+            </button>
           </div>
-        )}
-      </div>
+          {trustingUsers.length > 0 && (
+            <div className="tournament__manage-roster__actions__section">
+              <MyForm hiddenFields={{ teamId: ownTeam.id }}>
+                <label htmlFor="userId">
+                  Add players you previously played with
+                </label>
+                <select
+                  className="tournament__manage-roster__select"
+                  name="userId"
+                  id="userId"
+                  defaultValue={actionData?.fields?.userId}
+                >
+                  {trustingUsers.map(({ trustGiver }) => (
+                    <option key={trustGiver.id} value={trustGiver.id}>
+                      {trustGiver.discordName}
+                    </option>
+                  ))}
+                </select>
+                <ErrorMessage errorMsg={actionData?.fieldErrors?.userId} />
+                <Button
+                  className="tournament__manage-roster__input__button"
+                  type="submit"
+                  loadingText="Adding..."
+                  loading={transition.state !== "idle"}
+                >
+                  Add to roster
+                </Button>
+              </MyForm>
+            </div>
+          )}
+        </div>
+      )}
     </div>
   );
 }
diff --git a/app/styles/global.css b/app/styles/global.css
index 7ba3899f1..a74e84bd2 100644
--- a/app/styles/global.css
+++ b/app/styles/global.css
@@ -6,6 +6,7 @@
   --text-lighter: rgb(255 255 255 / 55%);
   --theme-error: rgb(219 70 65);
   --theme-warning: #f5f587;
+  --theme-info: #a3a6ff;
   --theme: hsl(255deg 66.7% 55.3%);
   --theme-transparent: hsl(255deg 66.7% 55.3% / 40%);
   --theme-secondary: hsl(85deg 66.7% 55.3%);
@@ -213,3 +214,7 @@ select::selection {
 .alert[data-type="warning"] > svg {
   fill: var(--theme-warning);
 }
+
+.alert[data-type="info"] > svg {
+  fill: var(--theme-info);
+}