From f26e04023874a318f46ceca304c852c9cf60a40b Mon Sep 17 00:00:00 2001 From: William Lam Date: Sun, 25 Aug 2024 02:10:09 -0400 Subject: [PATCH] Enable Biome rule "noSvgWithoutTitle" (#1849) * Turn off noSvgWithoutTitle rule & see how many errors pop up in linting * Commit with .tsx files containing elements now have tags in them (with English localization) * Fixed tabbing in some files --- app/components/icons/Admin.tsx | 1 + app/components/icons/Alert.tsx | 1 + app/components/icons/ArchiveBox.tsx | 1 + app/components/icons/ArrowLeft.tsx | 1 + app/components/icons/ArrowLongLeft.tsx | 1 + app/components/icons/ArrowRight.tsx | 1 + app/components/icons/ArrowsPointingIn.tsx | 1 + app/components/icons/Battlefy.tsx | 1 + app/components/icons/Beaker.tsx | 1 + app/components/icons/BeakerFilled.tsx | 1 + app/components/icons/Calendar.tsx | 1 + app/components/icons/ChartBar.tsx | 1 + app/components/icons/Chat.tsx | 1 + app/components/icons/CheckIn.tsx | 1 + app/components/icons/Checkmark.tsx | 1 + app/components/icons/Clipboard.tsx | 1 + app/components/icons/Clock.tsx | 1 + app/components/icons/Cross.tsx | 1 + app/components/icons/Discord.tsx | 1 + app/components/icons/Download.tsx | 1 + app/components/icons/Edit.tsx | 1 + app/components/icons/Error.tsx | 1 + app/components/icons/Eye.tsx | 1 + app/components/icons/EyeSlash.tsx | 1 + app/components/icons/Filter.tsx | 1 + app/components/icons/Fire.tsx | 1 + app/components/icons/GitHub.tsx | 1 + app/components/icons/Heart.tsx | 1 + app/components/icons/Info.tsx | 1 + app/components/icons/Link.tsx | 1 + app/components/icons/Lock.tsx | 1 + app/components/icons/LogIn.tsx | 1 + app/components/icons/LogOut.tsx | 1 + app/components/icons/Map.tsx | 1 + app/components/icons/Microphone.tsx | 1 + app/components/icons/MicrophoneFilled.tsx | 1 + app/components/icons/Minus.tsx | 1 + app/components/icons/Patreon.tsx | 2 +- app/components/icons/Pick.tsx | 1 + app/components/icons/Plus.tsx | 1 + app/components/icons/Puzzle.tsx | 1 + app/components/icons/Refresh.tsx | 1 + app/components/icons/RefreshArrows.tsx | 1 + app/components/icons/Scale.tsx | 1 + app/components/icons/Search.tsx | 1 + app/components/icons/Sort.tsx | 1 + app/components/icons/Speaker.tsx | 1 + app/components/icons/SpeakerFilled.tsx | 1 + app/components/icons/SpeakerX.tsx | 1 + app/components/icons/SpeechBubble.tsx | 1 + app/components/icons/Star.tsx | 1 + app/components/icons/StarFilled.tsx | 1 + app/components/icons/Success.tsx | 1 + app/components/icons/Trash.tsx | 1 + app/components/icons/Twitch.tsx | 1 + app/components/icons/Twitter.tsx | 1 + app/components/icons/Undo.tsx | 1 + app/components/icons/Unlock.tsx | 1 + app/components/icons/Upload.tsx | 1 + app/components/icons/User.tsx | 1 + app/components/icons/Users.tsx | 1 + app/components/icons/YouTube.tsx | 1 + biome.json | 3 +-- 63 files changed, 63 insertions(+), 3 deletions(-) diff --git a/app/components/icons/Admin.tsx b/app/components/icons/Admin.tsx index 0a22b8917..4860e265c 100644 --- a/app/components/icons/Admin.tsx +++ b/app/components/icons/Admin.tsx @@ -6,6 +6,7 @@ export function AdminIcon({ className }: { className?: string }) { viewBox="0 0 20 20" fill="currentColor" > + <title>Admin Icon + Alert Icon + Archive Box Icon + Arrow Left Icon + Arrow Long Left Icon + Arrow Right Icon + Arrows Pointing In Icon + Battlefy Icon + Beaker Icon + Beaker Filled Icon + Calendar Icon + Chart Bar Icon + Chat Icon + Check-In Icon diff --git a/app/components/icons/Checkmark.tsx b/app/components/icons/Checkmark.tsx index 05699e1fe..df50823eb 100644 --- a/app/components/icons/Checkmark.tsx +++ b/app/components/icons/Checkmark.tsx @@ -16,6 +16,7 @@ export function CheckmarkIcon({ data-testid={testId} onClick={onClick} > + Checkmark Icon + Clipboard Icon + Clock Icon + Cross Icon + Discord Icon ); diff --git a/app/components/icons/Download.tsx b/app/components/icons/Download.tsx index 8830b3403..e0eecec29 100644 --- a/app/components/icons/Download.tsx +++ b/app/components/icons/Download.tsx @@ -8,6 +8,7 @@ export function DownloadIcon({ className }: { className?: string }) { stroke="currentColor" className={className} > + Download Icon + Edit Icon + Error Icon + Eye Icon + Eye Slash Icon + Filter Icon + Fire Icon + GitHub Icon ); diff --git a/app/components/icons/Heart.tsx b/app/components/icons/Heart.tsx index 4094f700b..86b999a09 100644 --- a/app/components/icons/Heart.tsx +++ b/app/components/icons/Heart.tsx @@ -6,6 +6,7 @@ export function HeartIcon({ className }: { className?: string }) { fill="currentColor" className={className} > + Heart Icon ); diff --git a/app/components/icons/Info.tsx b/app/components/icons/Info.tsx index f6636df5a..fba577479 100644 --- a/app/components/icons/Info.tsx +++ b/app/components/icons/Info.tsx @@ -6,6 +6,7 @@ export function InfoIcon({ className }: { className?: string }) { fill="currentColor" className={className} > + Info Icon + Link Icon + Lock Icon + Login Icon + LogOut Icon + Map Icon + Microphone Icon + Microphone Filled Icon diff --git a/app/components/icons/Minus.tsx b/app/components/icons/Minus.tsx index 577fb74ef..bac304da3 100644 --- a/app/components/icons/Minus.tsx +++ b/app/components/icons/Minus.tsx @@ -7,6 +7,7 @@ export function MinusIcon({ className }: { className?: string }) { viewBox="0 0 24 24" stroke="currentColor" > + Minus Icon - + <title>Patreon Icon ); diff --git a/app/components/icons/Pick.tsx b/app/components/icons/Pick.tsx index e104f9c3c..c4aa5a210 100644 --- a/app/components/icons/Pick.tsx +++ b/app/components/icons/Pick.tsx @@ -8,6 +8,7 @@ export function PickIcon({ className }: { className?: string }) { stroke="currentColor" className={className} > + Pick Icon + Plus Icon + Puzzle Icon ); diff --git a/app/components/icons/Refresh.tsx b/app/components/icons/Refresh.tsx index 399830992..9f67172e3 100644 --- a/app/components/icons/Refresh.tsx +++ b/app/components/icons/Refresh.tsx @@ -7,6 +7,7 @@ export function RefreshIcon({ className }: { className?: string }) { viewBox="0 0 24 24" stroke="currentColor" > + Refresh Icon + Refresh Arrows Icon + Scale Icon + Search Icon + Sort Icon + Speaker Icon + Speaker Filled Icon diff --git a/app/components/icons/SpeakerX.tsx b/app/components/icons/SpeakerX.tsx index 445a1c3df..ab6f96d85 100644 --- a/app/components/icons/SpeakerX.tsx +++ b/app/components/icons/SpeakerX.tsx @@ -8,6 +8,7 @@ export function SpeakerXIcon({ className }: { className?: string }) { stroke="currentColor" className={className} > + Speaker X Icon + Speech Bubble Icon + Star Icon + Star Filled Icon + Success Icon + Trash Icon + Twitch Icon ); diff --git a/app/components/icons/Twitter.tsx b/app/components/icons/Twitter.tsx index 6dfa78756..f55668dc9 100644 --- a/app/components/icons/Twitter.tsx +++ b/app/components/icons/Twitter.tsx @@ -9,6 +9,7 @@ export function TwitterIcon({ className }: { className?: string }) { viewBox="0 0 16 16" xmlns="http://www.w3.org/2000/svg" > + Twitter Icon ); diff --git a/app/components/icons/Undo.tsx b/app/components/icons/Undo.tsx index 4ee8b77b5..9ceb32133 100644 --- a/app/components/icons/Undo.tsx +++ b/app/components/icons/Undo.tsx @@ -6,6 +6,7 @@ export default function UndoIcon({ className }: { className?: string }) { fill="currentColor" className={className} > + Undo Icon + Unlock Icon ); diff --git a/app/components/icons/Upload.tsx b/app/components/icons/Upload.tsx index 7fdef2942..fa329c996 100644 --- a/app/components/icons/Upload.tsx +++ b/app/components/icons/Upload.tsx @@ -8,6 +8,7 @@ export function UploadIcon({ className }: { className?: string }) { stroke="currentColor" className={className} > + Upload Icon + User Icon + Users Icon ); diff --git a/app/components/icons/YouTube.tsx b/app/components/icons/YouTube.tsx index a48a4d5f8..4dde26187 100644 --- a/app/components/icons/YouTube.tsx +++ b/app/components/icons/YouTube.tsx @@ -8,6 +8,7 @@ export function YouTubeIcon({ className }: { className?: string }) { xmlns="http://www.w3.org/2000/svg" className={className} > + YouTube Icon ); diff --git a/biome.json b/biome.json index ae60033c0..9d1ef873d 100644 --- a/biome.json +++ b/biome.json @@ -31,8 +31,7 @@ } }, "a11y": { - "useKeyWithClickEvents": "off", - "noSvgWithoutTitle": "off" + "useKeyWithClickEvents": "off" }, "complexity": { "useLiteralKeys": {