From eb3b5a1cfe08034514e99c5bf0299dcaf2fa5c96 Mon Sep 17 00:00:00 2001
From: Kalle <38327916+Sendouc@users.noreply.github.com>
Date: Sun, 7 Aug 2022 11:41:29 +0300
Subject: [PATCH] Don't put hidden team report winners to DOM

---
 app/routes/calendar/$id/report-winners.tsx | 34 +++++++++++-----------
 1 file changed, 17 insertions(+), 17 deletions(-)

diff --git a/app/routes/calendar/$id/report-winners.tsx b/app/routes/calendar/$id/report-winners.tsx
index 388116b4a..6c5322399 100644
--- a/app/routes/calendar/$id/report-winners.tsx
+++ b/app/routes/calendar/$id/report-winners.tsx
@@ -272,22 +272,22 @@ function Team({
     setResults({ ...results, placement: e.target.value });
   };
 
+  if (hidden) return null;
+
   return (
-    <div className={clsx("stack md items-start", { hidden })}>
-      {!hidden && (
-        <input
-          type="hidden"
-          name="team"
-          value={JSON.stringify({
-            ...results,
-            players: results.players.filter(
-              (player) =>
-                (typeof player === "string" && player !== "") ||
-                (typeof player === "object" && player.id !== 0)
-            ),
-          })}
-        />
-      )}
+    <div className={clsx("stack md items-start")}>
+      <input
+        type="hidden"
+        name="team"
+        value={JSON.stringify({
+          ...results,
+          players: results.players.filter(
+            (player) =>
+              (typeof player === "string" && player !== "") ||
+              (typeof player === "object" && player.id !== 0)
+          ),
+        })}
+      />
       <div className="stack horizontal md flex-wrap">
         <div>
           <Label htmlFor={teamNameId}>Team name</Label>
@@ -295,7 +295,7 @@ function Team({
             id={teamNameId}
             value={results.teamName}
             onChange={handleTeamNameChange}
-            required={!hidden}
+            required
             maxLength={CALENDAR_EVENT_RESULT.MAX_TEAM_NAME_LENGTH}
           />
         </div>
@@ -306,7 +306,7 @@ function Team({
             value={results.placement}
             type="number"
             onChange={handlePlacementChange}
-            required={!hidden}
+            required
             max={CALENDAR_EVENT_RESULT.MAX_TEAM_PLACEMENT}
             className="w-24"
           />