From dc0bbaa271318c67b5bf3c380dfd292a1ac370af Mon Sep 17 00:00:00 2001
From: Kalle <38327916+Sendouc@users.noreply.github.com>
Date: Sun, 26 Apr 2026 15:02:56 +0300
Subject: [PATCH] Fix TODO about BracketsManager types mismatch

---
 .../core/brackets-manager/crud.server.ts      | 24 ++++++++++++++++++-
 .../core/brackets-manager/manager.server.ts   |  2 --
 2 files changed, 23 insertions(+), 3 deletions(-)

diff --git a/app/features/tournament-bracket/core/brackets-manager/crud.server.ts b/app/features/tournament-bracket/core/brackets-manager/crud.server.ts
index 45a11a960..4e1075887 100644
--- a/app/features/tournament-bracket/core/brackets-manager/crud.server.ts
+++ b/app/features/tournament-bracket/core/brackets-manager/crud.server.ts
@@ -1,8 +1,16 @@
 // @ts-nocheck TODO
 
+import type {
+	CrudInterface,
+	DataTypes,
+	OmitId,
+	Table,
+} from "~/modules/brackets-manager/types";
 import { Group, Match, Round, Stage } from "./crud-db.server";
 
-export class SqlDatabase {
+export class SqlDatabase implements CrudInterface {
+	insert<T extends Table>(table: T, value: OmitId<DataTypes[T]>): number;
+	insert<T extends Table>(table: T, values: OmitId<DataTypes[T]>[]): boolean;
 	insert(table, arg) {
 		switch (table) {
 			case "participant":
@@ -55,6 +63,12 @@ export class SqlDatabase {
 		}
 	}
 
+	select<T extends Table>(table: T): Array<DataTypes[T]> | null;
+	select<T extends Table>(table: T, id: number): DataTypes[T] | null;
+	select<T extends Table>(
+		table: T,
+		filter: Partial<DataTypes[T]>,
+	): Array<DataTypes[T]> | null;
 	select(table, arg) {
 		switch (table) {
 			case "participant":
@@ -194,6 +208,12 @@ export class SqlDatabase {
 		return null;
 	}
 
+	update<T extends Table>(table: T, id: number, value: DataTypes[T]): boolean;
+	update<T extends Table>(
+		table: T,
+		filter: Partial<DataTypes[T]>,
+		value: Partial<DataTypes[T]>,
+	): boolean;
 	update(table, query, update) {
 		switch (table) {
 			case "stage":
@@ -264,6 +284,8 @@ export class SqlDatabase {
 		return false;
 	}
 
+	delete<T extends Table>(table: T): boolean;
+	delete<T extends Table>(table: T, filter: Partial<DataTypes[T]>): boolean;
 	delete(_table, _filter) {
 		throw new Error("not implemented");
 		// switch (table) {
diff --git a/app/features/tournament-bracket/core/brackets-manager/manager.server.ts b/app/features/tournament-bracket/core/brackets-manager/manager.server.ts
index 2199f2465..ce23cce3d 100644
--- a/app/features/tournament-bracket/core/brackets-manager/manager.server.ts
+++ b/app/features/tournament-bracket/core/brackets-manager/manager.server.ts
@@ -3,8 +3,6 @@ import { SqlDatabase } from "./crud.server";
 
 export function getServerTournamentManager() {
 	const storage = new SqlDatabase();
-	// TODO: fix this ts-expect-error comment
-	// @ts-expect-error interface mismatch
 	const manager = new BracketsManager(storage);
 
 	return manager;