From bb25ba3d8f7bef280c1aa874dc2fad1fcbdc0cf3 Mon Sep 17 00:00:00 2001 From: Kalle <38327916+Sendouc@users.noreply.github.com> Date: Sun, 24 May 2026 15:19:57 +0300 Subject: [PATCH] Improve misleading text in follow up bracket Closes #3098 --- .../routes/to.$id.brackets.tsx | 18 ++++++++++++++---- locales/da/tournament.json | 1 + locales/de/tournament.json | 1 + locales/en/tournament.json | 1 + locales/es-ES/tournament.json | 1 + locales/es-US/tournament.json | 1 + locales/fr-CA/tournament.json | 1 + locales/fr-EU/tournament.json | 1 + locales/he/tournament.json | 1 + locales/it/tournament.json | 1 + locales/ja/tournament.json | 1 + locales/ko/tournament.json | 1 + locales/nl/tournament.json | 1 + locales/pl/tournament.json | 1 + locales/pt-BR/tournament.json | 1 + locales/ru/tournament.json | 1 + locales/zh/tournament.json | 1 + 17 files changed, 30 insertions(+), 4 deletions(-) diff --git a/app/features/tournament-bracket/routes/to.$id.brackets.tsx b/app/features/tournament-bracket/routes/to.$id.brackets.tsx index a065cad67..4bcd36a02 100644 --- a/app/features/tournament-bracket/routes/to.$id.brackets.tsx +++ b/app/features/tournament-bracket/routes/to.$id.brackets.tsx @@ -114,8 +114,18 @@ export default function TournamentBracketsPage() { bracket.preview && isHydrated; - const waitingForTeamsText = () => { - if (bracketIdx > 0 || tournament.regularCheckInStartInThePast) { + const waitingForTeamsText = (bracket: BracketType, bracketIdx: number) => { + if (bracketIdx > 0) { + return bracket.requiresCheckIn + ? t("tournament:bracket.waiting.checkin", { + count: TOURNAMENT.ENOUGH_TEAMS_TO_START, + }) + : t("tournament:bracket.waiting.advanced", { + count: TOURNAMENT.ENOUGH_TEAMS_TO_START, + }); + } + + if (tournament.regularCheckInStartInThePast) { return t("tournament:bracket.waiting.checkin", { count: TOURNAMENT.ENOUGH_TEAMS_TO_START, }); @@ -550,7 +560,7 @@ function BracketTabContent({ }: { bracket: BracketType; bracketIdx: number; - waitingForTeamsText: () => string; + waitingForTeamsText: (bracket: BracketType, bracketIdx: number) => string; teamsSourceText: () => string | null; }) { return ( @@ -560,7 +570,7 @@ function BracketTabContent({ ) : (
- {waitingForTeamsText()} + {waitingForTeamsText(bracket, bracketIdx)}
{bracket.sources ? (
diff --git a/locales/da/tournament.json b/locales/da/tournament.json index 9ba2af01a..cc3179d91 100644 --- a/locales/da/tournament.json +++ b/locales/da/tournament.json @@ -101,6 +101,7 @@ "team.placement.footer": "", "bracket.waiting": "Her vil turneringsplanen blive vist, så snart{{count}} hold har registreret sig", "bracket.waiting.checkin": "Her vil turneringsplanen blive vist, så snart{{count}} hold er tjekket ind", + "bracket.waiting.advanced": "", "bracket.wip": "Denne turneringsplan er en forhåndsvisning og kan blive ændret", "bracket.progress.thanksForPlaying": "Tak fordi du deltog i {{eventName}}!", "bracket.progress.match": "Nuværende modstander: {{opponent}}", diff --git a/locales/de/tournament.json b/locales/de/tournament.json index 26ac4f412..7d69fd259 100644 --- a/locales/de/tournament.json +++ b/locales/de/tournament.json @@ -101,6 +101,7 @@ "team.placement.footer": "", "bracket.waiting": "Bracket wird hier angezeigt, sobald mindestens {{count}} Teams registriert sind", "bracket.waiting.checkin": "Bracket wird hier angezeigt, sobald mindestens {{count}} Teams eingecheckt sind", + "bracket.waiting.advanced": "", "bracket.wip": "Dieses Bracket ist eine Vorschau und kann sich ändern", "bracket.progress.thanksForPlaying": "Danke fürs Spielen von {{eventName}}!", "bracket.progress.match": "Aktueller Gegner: {{opponent}}", diff --git a/locales/en/tournament.json b/locales/en/tournament.json index 6086b711b..2467744dc 100644 --- a/locales/en/tournament.json +++ b/locales/en/tournament.json @@ -101,6 +101,7 @@ "team.placement.footer": "Overall/Bracket", "bracket.waiting": "Bracket will be shown here when at least {{count}} teams have registered", "bracket.waiting.checkin": "Bracket will be shown here when at least {{count}} teams have checked in", + "bracket.waiting.advanced": "Bracket will be shown here when at least {{count}} teams have advanced", "bracket.wip": "This bracket is a preview and subject to change", "bracket.progress.thanksForPlaying": "Thanks for playing in {{eventName}}!", "bracket.progress.match": "Current opponent: {{opponent}}", diff --git a/locales/es-ES/tournament.json b/locales/es-ES/tournament.json index c6cacaf9a..487b2344b 100644 --- a/locales/es-ES/tournament.json +++ b/locales/es-ES/tournament.json @@ -103,6 +103,7 @@ "team.placement.footer": "General/Cuadro", "bracket.waiting": "Cuadro se muestra aquí cuando al menos {{count}} equipos sean registrados", "bracket.waiting.checkin": "Cuadro se muestra aquí cuando al menos {{count}} equipos se hagan check-in", + "bracket.waiting.advanced": "", "bracket.wip": "Este cuadro es temporal y puede cambiar", "bracket.progress.thanksForPlaying": "¡Gracias por participar en {{eventName}}!", "bracket.progress.match": "Oponente actual: {{opponent}}", diff --git a/locales/es-US/tournament.json b/locales/es-US/tournament.json index 21703ea2f..a33ef910e 100644 --- a/locales/es-US/tournament.json +++ b/locales/es-US/tournament.json @@ -103,6 +103,7 @@ "team.placement.footer": "", "bracket.waiting": "Cuadro se muestra aquí cuando al menos {{count}} equipos sean registrados", "bracket.waiting.checkin": "Cuadro se muestra aquí cuando al menos {{count}} equipos se hagan check-in", + "bracket.waiting.advanced": "", "bracket.wip": "Este cuadro es temporal y puede cambiar", "bracket.progress.thanksForPlaying": "¡Gracias por participar en {{eventName}}!", "bracket.progress.match": "Oponente actual: {{opponent}}", diff --git a/locales/fr-CA/tournament.json b/locales/fr-CA/tournament.json index 995750846..586be43e5 100644 --- a/locales/fr-CA/tournament.json +++ b/locales/fr-CA/tournament.json @@ -103,6 +103,7 @@ "team.placement.footer": "", "bracket.waiting": "Le bracket sera affiché ici quand au moins {{count}} équipes seront inscrites", "bracket.waiting.checkin": "", + "bracket.waiting.advanced": "", "bracket.wip": "Ce bracket est un aperçu et sujet à changement", "bracket.progress.thanksForPlaying": "Merci d'avoir participé à {{eventName}} !", "bracket.progress.match": "Adversaire actuel: {{opponent}}", diff --git a/locales/fr-EU/tournament.json b/locales/fr-EU/tournament.json index 87a860c1a..93f0ac731 100644 --- a/locales/fr-EU/tournament.json +++ b/locales/fr-EU/tournament.json @@ -103,6 +103,7 @@ "team.placement.footer": "", "bracket.waiting": "Le bracket sera affiché ici quand au moins {{count}} équipes seront inscrites", "bracket.waiting.checkin": "Le bracket sera affiché ici lorsqu'au moins {{count}} équipes se seront enregistrées", + "bracket.waiting.advanced": "", "bracket.wip": "Ce bracket est un aperçu et sujet à changement", "bracket.progress.thanksForPlaying": "Merci d'avoir participé à {{eventName}} !", "bracket.progress.match": "Adversaire actuel: {{opponent}}", diff --git a/locales/he/tournament.json b/locales/he/tournament.json index 224704ecb..a0c65b9fb 100644 --- a/locales/he/tournament.json +++ b/locales/he/tournament.json @@ -103,6 +103,7 @@ "team.placement.footer": "", "bracket.waiting": "מערכים יופיעו כאן כאשר לפחות {{count}} צוותים נרשמו", "bracket.waiting.checkin": "", + "bracket.waiting.advanced": "", "bracket.wip": "מערך זה הוא תצוגה מקדימה ונתון לשינויים", "bracket.progress.thanksForPlaying": "תודה ששיחקתם ב-{{eventName}}!", "bracket.progress.match": "יריב נוכחי: {{opponent}}", diff --git a/locales/it/tournament.json b/locales/it/tournament.json index ff9c8d87c..d577434cd 100644 --- a/locales/it/tournament.json +++ b/locales/it/tournament.json @@ -103,6 +103,7 @@ "team.placement.footer": "", "bracket.waiting": "Il bracket verrà mostrato qui una volta che {{count}} team si saranno iscritti", "bracket.waiting.checkin": "Il bracket verrà mostrato qui una volta che {{count}} team avranno completato il check-in", + "bracket.waiting.advanced": "", "bracket.wip": "Questo bracket è un anteprima ed è soggetto a cambiamenti", "bracket.progress.thanksForPlaying": "Grazie per aver giocato in {{eventName}}!", "bracket.progress.match": "Avversario attuale: {{opponent}}", diff --git a/locales/ja/tournament.json b/locales/ja/tournament.json index 2ba92a734..46d02c00b 100644 --- a/locales/ja/tournament.json +++ b/locales/ja/tournament.json @@ -97,6 +97,7 @@ "team.placement.footer": "", "bracket.waiting": "ブラケットは、少なくとも {{count}} チームが登録した時点で表示されます", "bracket.waiting.checkin": "ブラケットは最低{{count}}チームがチェックインしてから表示されるよ", + "bracket.waiting.advanced": "", "bracket.wip": "このブラケットはまだプレビューで、変更される可能性があります", "bracket.progress.thanksForPlaying": "{{eventName}} への参加ありがとうございます!", "bracket.progress.match": "現在の対戦者: {{opponent}}", diff --git a/locales/ko/tournament.json b/locales/ko/tournament.json index f8d0530bc..fa53e97d9 100644 --- a/locales/ko/tournament.json +++ b/locales/ko/tournament.json @@ -97,6 +97,7 @@ "team.placement.footer": "", "bracket.waiting": "", "bracket.waiting.checkin": "", + "bracket.waiting.advanced": "", "bracket.wip": "", "bracket.progress.thanksForPlaying": "", "bracket.progress.match": "", diff --git a/locales/nl/tournament.json b/locales/nl/tournament.json index 9e330e608..f3d484043 100644 --- a/locales/nl/tournament.json +++ b/locales/nl/tournament.json @@ -101,6 +101,7 @@ "team.placement.footer": "", "bracket.waiting": "", "bracket.waiting.checkin": "", + "bracket.waiting.advanced": "", "bracket.wip": "", "bracket.progress.thanksForPlaying": "", "bracket.progress.match": "", diff --git a/locales/pl/tournament.json b/locales/pl/tournament.json index f7103b530..88a7c42b3 100644 --- a/locales/pl/tournament.json +++ b/locales/pl/tournament.json @@ -105,6 +105,7 @@ "team.placement.footer": "", "bracket.waiting": "", "bracket.waiting.checkin": "", + "bracket.waiting.advanced": "", "bracket.wip": "", "bracket.progress.thanksForPlaying": "", "bracket.progress.match": "", diff --git a/locales/pt-BR/tournament.json b/locales/pt-BR/tournament.json index af8c98c53..264bd212d 100644 --- a/locales/pt-BR/tournament.json +++ b/locales/pt-BR/tournament.json @@ -103,6 +103,7 @@ "team.placement.footer": "", "bracket.waiting": "O bracket será mostrado aqui quando ao menos {{count}} times estiverem registrados", "bracket.waiting.checkin": "O bracket será mostrado aqui quando pelo menos {{count}} times tiverem feito o check-in", + "bracket.waiting.advanced": "", "bracket.wip": "Esse bracket é uma prévia e poderá mudar", "bracket.progress.thanksForPlaying": "Obrigado por participar do(a) {{eventName}}!", "bracket.progress.match": "Oponente atual: {{opponent}}", diff --git a/locales/ru/tournament.json b/locales/ru/tournament.json index 9f6cfdf65..0c112136e 100644 --- a/locales/ru/tournament.json +++ b/locales/ru/tournament.json @@ -105,6 +105,7 @@ "team.placement.footer": "", "bracket.waiting": "Сетка будет показана как только {{count}} команд зарегистрируется", "bracket.waiting.checkin": "Сетка будет показана как только {{count}} команд пройдут чек-ин", + "bracket.waiting.advanced": "", "bracket.wip": "Данная сетка является предварительной и может быть изменена.", "bracket.progress.thanksForPlaying": "Спасибо за участие в {{eventName}}!", "bracket.progress.match": "Текущий противник: {{opponent}}", diff --git a/locales/zh/tournament.json b/locales/zh/tournament.json index 34a628190..8f4799665 100644 --- a/locales/zh/tournament.json +++ b/locales/zh/tournament.json @@ -97,6 +97,7 @@ "team.placement.footer": "", "bracket.waiting": "至少 {{count}} 支队伍报名后，对战表将显示在这里", "bracket.waiting.checkin": "对战表会在至少 {{count}} 支队伍签到后显示", + "bracket.waiting.advanced": "", "bracket.wip": "此对战表为可调整的预览", "bracket.progress.thanksForPlaying": "感谢您参与 {{eventName}}！", "bracket.progress.match": "当前对手: {{opponent}}",