From 9013833707e10150afa8a6d029d03d5cce004bd8 Mon Sep 17 00:00:00 2001 From: Kalle <38327916+Sendouc@users.noreply.github.com> Date: Sun, 23 Feb 2025 12:15:25 +0200 Subject: [PATCH] Always use bracket specific settings I left the tournament settings there for backwards compability reasons. But now it seems they are causing a problem because the bracket progression selector is using bracket settings. So there was a bug where 3rd place match is disabled, but still showed up (because using different settings) --- app/features/tournament-bracket/core/Tournament.ts | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/app/features/tournament-bracket/core/Tournament.ts b/app/features/tournament-bracket/core/Tournament.ts index 278bf628b..b45e0a261 100644 --- a/app/features/tournament-bracket/core/Tournament.ts +++ b/app/features/tournament-bracket/core/Tournament.ts @@ -570,10 +570,7 @@ export class Tournament { } return { - consolationFinal: - selectedSettings?.thirdPlaceMatch ?? - this.ctx.settings.thirdPlaceMatch ?? - true, + consolationFinal: selectedSettings?.thirdPlaceMatch ?? true, }; } case "double_elimination": { @@ -584,7 +581,6 @@ export class Tournament { case "round_robin": { const teamsPerGroup = selectedSettings?.teamsPerGroup ?? - this.ctx.settings.teamsPerGroup ?? TOURNAMENT.DEFAULT_TEAM_COUNT_PER_RR_GROUP; return { @@ -602,7 +598,7 @@ export class Tournament { groupCount: selectedSettings.groupCount, roundCount: selectedSettings.roundCount, } - : this.ctx.settings.swiss, + : undefined, }; } default: {