From 73cdfb731447ed91024dcb71d69906bb137dbae7 Mon Sep 17 00:00:00 2001
From: Kalle <38327916+Sendouc@users.noreply.github.com>
Date: Sat, 2 Jul 2022 10:49:52 +0300
Subject: [PATCH] Improve menu a11y

---
 app/components/layout/Menu.tsx | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/app/components/layout/Menu.tsx b/app/components/layout/Menu.tsx
index 8c5272a8b..908a62201 100644
--- a/app/components/layout/Menu.tsx
+++ b/app/components/layout/Menu.tsx
@@ -11,7 +11,7 @@ export function Menu({
   closeMenu: () => void;
 }) {
   return (
-    <div className={clsx("layout__menu", { expanded })}>
+    <nav className={clsx("layout__menu", { expanded })} aria-hidden={!expanded}>
       <div className="layout__menu__links">
         {navItems.map((navItem, i) => (
           <Link
@@ -23,6 +23,7 @@ export function Menu({
             to={navItem.url ?? navItem.name}
             onClick={closeMenu}
             data-cy={`menu-link-${navItem.name}`}
+            tabIndex={!expanded ? -1 : undefined}
           >
             <img
               className="layout__menu__link__icon"
@@ -33,6 +34,6 @@ export function Menu({
           </Link>
         ))}
       </div>
-    </div>
+    </nav>
   );
 }