From 6732b6c59bdd8aa6783ab2aeb8bfc21978a9425e Mon Sep 17 00:00:00 2001
From: Kalle <38327916+Sendouc@users.noreply.github.com>
Date: Sat, 27 Jun 2026 11:14:47 +0300
Subject: [PATCH] Fix & add tier list maker E2E test

---
 .../tier-list-maker/components/ItemPool.tsx   |  1 +
 e2e/tier-list-maker.spec.ts                   | 26 ++++++++++++++++++-
 2 files changed, 26 insertions(+), 1 deletion(-)

diff --git a/app/features/tier-list-maker/components/ItemPool.tsx b/app/features/tier-list-maker/components/ItemPool.tsx
index f815b0b45..979c177ff 100644
--- a/app/features/tier-list-maker/components/ItemPool.tsx
+++ b/app/features/tier-list-maker/components/ItemPool.tsx
@@ -45,6 +45,7 @@ function ClickableItem({
 	return (
 		<button
 			type="button"
+			data-item-id={tierListItemId(item)}
 			className={styles.clickableItem}
 			onClick={onClick}
 			disabled={disabled}
diff --git a/e2e/tier-list-maker.spec.ts b/e2e/tier-list-maker.spec.ts
index 25e9022af..6c2a2a0d2 100644
--- a/e2e/tier-list-maker.spec.ts
+++ b/e2e/tier-list-maker.spec.ts
@@ -8,12 +8,14 @@ test.describe("Tier List Maker", () => {
 	}) => {
 		await navigate({ page, url: TIER_LIST_MAKER_URL });
 
+		await page.getByText("Drag & drop").click();
+
 		const emptyTiers = page.getByText("Drop items here");
 
 		await expect(emptyTiers).toHaveCount(5);
 
 		// Test that toggles are clickable (just verify they work)
-		await page.getByText("Allow duplicates").click();
+		await page.getByText("No duplicates").click();
 		await page.getByText("Show tier headers").click();
 		await page.getByText("Hide alt kits").click();
 		await page.getByText("Hide alt skins").click();
@@ -39,10 +41,32 @@ test.describe("Tier List Maker", () => {
 		// Reload the page
 		await page.reload();
 
+		// Placement mode is not persisted, so re-enter drag & drop mode
+		await page.getByText("Drag & drop").click();
+
 		// Verify items persisted in the tier list (not in the pool)
 		// Should have fewer than 5 "Drop items here" (meaning at least 1 tier is filled)
 		await expect(emptyTiers).toHaveCount(3);
 	});
+
+	test("click to place mode adds items to the selected tier", async ({
+		page,
+	}) => {
+		await navigate({ page, url: TIER_LIST_MAKER_URL });
+
+		// Click to place is the default mode
+		const emptyTiers = page.getByText("Click items to add here");
+		await expect(emptyTiers).toHaveCount(5);
+
+		// The first tier is selected by default, clicking a weapon places it there
+		await page.locator('button[data-item-id^="main-weapon:"]').first().click();
+		await expect(emptyTiers).toHaveCount(4);
+
+		// Selecting another tier and clicking a weapon places it there
+		await emptyTiers.first().click();
+		await page.locator('button[data-item-id^="main-weapon:"]').first().click();
+		await expect(emptyTiers).toHaveCount(3);
+	});
 });
 
 async function dragItemToTier(page: Page, item: Locator) {