diff --git a/app/routes/plus/voting/results.tsx b/app/routes/plus/voting/results.tsx index c43f91a4b..60bc59bdb 100644 --- a/app/routes/plus/voting/results.tsx +++ b/app/routes/plus/voting/results.tsx @@ -74,7 +74,7 @@ export default function PlusVotingResultsPage() { didn't pass )}{" "} the +{result.tier} voting - {result.score + {typeof result.score === "number" ? `, your score was ${result.score}% (at least 50% required to pass)` : ""} diff --git a/cypress/e2e/plus.cy.ts b/cypress/e2e/plus.cy.ts index a02e61ca5..b93b49b57 100644 --- a/cypress/e2e/plus.cy.ts +++ b/cypress/e2e/plus.cy.ts @@ -62,19 +62,20 @@ describe("Plus voting results page", () => { cy.seed(); }); - it("does not see results but sees own percentage as a failed suggest", () => { + it("sees own % and results as a failed suggest", () => { cy.auth(200); cy.visit("/plus/voting/results"); - cy.contains("Sendou").should("not.exist"); + cy.contains("Sendou"); cy.contains("your score was"); }); - it("views full results as member who passed", () => { + it("views results without % as member who passed", () => { cy.auth(1); cy.visit("/plus/voting/results"); cy.contains("Sendou"); + cy.contains("passed"); }); // xxx: figure out a good way to do plus server tests with serverside isVotingActive or delete existing tests diff --git a/package-lock.json b/package-lock.json index 852462693..3897d1636 100644 --- a/package-lock.json +++ b/package-lock.json @@ -35,7 +35,7 @@ "@typescript-eslint/eslint-plugin": "^5.30.5", "@typescript-eslint/parser": "^5.30.5", "cross-env": "^7.0.3", - "cypress": "^10.2.0", + "cypress": "^10.3.0", "dotenv": "^16.0.1", "eslint": "^8.19.0", "eslint-plugin-react": "^7.30.1", @@ -5313,9 +5313,9 @@ "dev": true }, "node_modules/cypress": { - "version": "10.2.0", - "resolved": "https://registry.npmjs.org/cypress/-/cypress-10.2.0.tgz", - "integrity": "sha512-+i9lY5ENlfi2mJwsggzR+XASOIgMd7S/Gd3/13NCpv596n3YSplMAueBTIxNLcxDpTcIksp+9pM3UaDrJDpFqA==", + "version": "10.3.0", + "resolved": "https://registry.npmjs.org/cypress/-/cypress-10.3.0.tgz", + "integrity": "sha512-txkQWKzvBVnWdCuKs5Xc08gjpO89W2Dom2wpZgT9zWZT5jXxqPIxqP/NC1YArtkpmp3fN5HW8aDjYBizHLUFvg==", "dev": true, "hasInstallScript": true, "dependencies": { @@ -19401,9 +19401,9 @@ "dev": true }, "cypress": { - "version": "10.2.0", - "resolved": "https://registry.npmjs.org/cypress/-/cypress-10.2.0.tgz", - "integrity": "sha512-+i9lY5ENlfi2mJwsggzR+XASOIgMd7S/Gd3/13NCpv596n3YSplMAueBTIxNLcxDpTcIksp+9pM3UaDrJDpFqA==", + "version": "10.3.0", + "resolved": "https://registry.npmjs.org/cypress/-/cypress-10.3.0.tgz", + "integrity": "sha512-txkQWKzvBVnWdCuKs5Xc08gjpO89W2Dom2wpZgT9zWZT5jXxqPIxqP/NC1YArtkpmp3fN5HW8aDjYBizHLUFvg==", "dev": true, "requires": { "@cypress/request": "^2.88.10", diff --git a/package.json b/package.json index 7f842a6ac..9ffc0247a 100644 --- a/package.json +++ b/package.json @@ -54,7 +54,7 @@ "@typescript-eslint/eslint-plugin": "^5.30.5", "@typescript-eslint/parser": "^5.30.5", "cross-env": "^7.0.3", - "cypress": "^10.2.0", + "cypress": "^10.3.0", "dotenv": "^16.0.1", "eslint": "^8.19.0", "eslint-plugin-react": "^7.30.1",