From 1e4eedd65a7a065aa676f29952604126a5be734e Mon Sep 17 00:00:00 2001 From: Kalle <38327916+Sendouc@users.noreply.github.com> Date: Fri, 7 Aug 2026 18:49:28 +0300 Subject: [PATCH] Remove TODOs --- .../scanner-ingest/ScannerIngestRepository.server.ts | 1 - app/features/scanner-ingest/actions/scanner-ingest.server.ts | 4 ---- app/features/scanner/capture/sampler.ts | 2 +- app/styles/vars.css | 5 ----- 4 files changed, 1 insertion(+), 11 deletions(-) diff --git a/app/features/scanner-ingest/ScannerIngestRepository.server.ts b/app/features/scanner-ingest/ScannerIngestRepository.server.ts index b293db6a9..e6f4f4085 100644 --- a/app/features/scanner-ingest/ScannerIngestRepository.server.ts +++ b/app/features/scanner-ingest/ScannerIngestRepository.server.ts @@ -108,7 +108,6 @@ export function sendouqGamesPlayedByUserSince(params: { * time: their team is in a match whose `startedAt` is close enough before * `at`. When several qualify (rare) the latest-started one wins. */ -// xxx: change it to more generic. user id + stage + mode + startedAt -> what scrim, sq, tournament if any? export async function tournamentIdAt({ userId, at, diff --git a/app/features/scanner-ingest/actions/scanner-ingest.server.ts b/app/features/scanner-ingest/actions/scanner-ingest.server.ts index 006bfac50..1c3b69727 100644 --- a/app/features/scanner-ingest/actions/scanner-ingest.server.ts +++ b/app/features/scanner-ingest/actions/scanner-ingest.server.ts @@ -15,10 +15,6 @@ import { ingestBodySchema, } from "../scanner-ingest-schemas"; -// xxx: dont only attach scoreboard on ingest, also when score is reported (for e.g. tournament stuff) -// xxx: check why http://localhost:7001/to/4066/matches/139247?tab=result layout bad -// xxx: check why http://localhost:7001/to/4066/matches/139247?tab=result first game not uploaded -// xxx: this needs some thinking and documentation to cover all the cases that can be ingested export const action: ActionFunction = async ({ request }) => { const user = requireUser(); diff --git a/app/features/scanner/capture/sampler.ts b/app/features/scanner/capture/sampler.ts index eb4a35c9d..883891ddf 100644 --- a/app/features/scanner/capture/sampler.ts +++ b/app/features/scanner/capture/sampler.ts @@ -24,7 +24,7 @@ export async function listVideoInputs(): Promise { export type FrameHandler = (bitmap: ImageBitmap, t: number) => void; -// XXX: hidden tabs can still be frozen/discarded outright, which suspends the +// xxx: hidden tabs can still be frozen/discarded outright, which suspends the // workers too. A silent looping