From 1747e2fd12dd1fb625a02b0922d7a73636e767ff Mon Sep 17 00:00:00 2001
From: Kalle <38327916+Sendouc@users.noreply.github.com>
Date: Sun, 24 Sep 2023 23:51:32 +0300
Subject: [PATCH] Move own roster to left column on desktop Closes #1509

---
 app/components/Chat.tsx                   |  12 +++
 app/components/NewTabs.tsx                |   3 +
 app/features/sendouq/routes/q.looking.tsx | 124 ++++++++++++----------
 3 files changed, 81 insertions(+), 58 deletions(-)

diff --git a/app/components/Chat.tsx b/app/components/Chat.tsx
index 33c008953..51158e3de 100644
--- a/app/components/Chat.tsx
+++ b/app/components/Chat.tsx
@@ -23,6 +23,8 @@ export interface ChatProps {
   messagesContainerClassName?: string;
   hidden?: boolean;
   onNewMessage?: (message: ChatMessage) => void;
+  onMount?: () => void;
+  onUnmount?: () => void;
 }
 
 export function ConnectedChat(props: ChatProps) {
@@ -38,6 +40,8 @@ export function Chat({
   messagesContainerClassName,
   hidden = false,
   chat,
+  onMount,
+  onUnmount,
 }: ChatProps & { chat: ReturnType<typeof useChat> }) {
   const messagesContainerRef = React.useRef<HTMLOListElement>(null);
   const inputRef = React.useRef<HTMLInputElement>(null);
@@ -64,6 +68,14 @@ export function Chat({
     messagesContainer.scrollTop = messagesContainer.scrollHeight;
   }, [messages]);
 
+  React.useEffect(() => {
+    onMount?.();
+
+    return () => {
+      onUnmount?.();
+    };
+  }, [onMount, onUnmount]);
+
   return (
     <section className={clsx("chat__container", className, { hidden })}>
       {rooms.length > 1 ? (
diff --git a/app/components/NewTabs.tsx b/app/components/NewTabs.tsx
index 85edb4ea1..8d8f6769e 100644
--- a/app/components/NewTabs.tsx
+++ b/app/components/NewTabs.tsx
@@ -24,11 +24,14 @@ export function NewTabs({
   selectedIndex,
   setSelectedIndex,
 }: NewTabsProps) {
+  const cantSwitchTabs = tabs.filter((t) => !t.hidden).length <= 1;
+
   return (
     <Tab.Group selectedIndex={selectedIndex} onChange={setSelectedIndex}>
       <Tab.List
         className={clsx("tab__buttons-container", {
           "overflow-x-auto": scrolling,
+          invisible: cantSwitchTabs,
         })}
       >
         {tabs
diff --git a/app/features/sendouq/routes/q.looking.tsx b/app/features/sendouq/routes/q.looking.tsx
index c8bce62f8..4cfa8cd88 100644
--- a/app/features/sendouq/routes/q.looking.tsx
+++ b/app/features/sendouq/routes/q.looking.tsx
@@ -439,7 +439,7 @@ function Groups() {
   const isMounted = useIsMounted();
 
   const [_unseenMessages, setUnseenMessages] = React.useState(0);
-  const [selectedIndex, setSelectedIndex] = React.useState(1);
+  const [chatVisible, setChatVisible] = React.useState(false);
   const { width } = useWindowSize();
 
   const chatUsers = React.useMemo(() => {
@@ -463,32 +463,16 @@ function Groups() {
 
   const chat = useChat({ rooms, onNewMessage });
 
-  // reset to own group tab when the roster changes
-  const memberIdsJoined = data.groups.own.members
-    ?.map((m) => m.id)
-    .sort((a, b) => a - b)
-    .join(",");
-  React.useEffect(() => {
-    if (memberIdsJoined && memberIdsJoined.split(",").length === 1) return;
-    setSelectedIndex(0);
-  }, [memberIdsJoined]);
+  const onChatMount = React.useCallback(() => {
+    setChatVisible(true);
+  }, []);
 
-  const CHAT_TAB_INDEX = 3;
-  // the way of doing it seems a bit backwards but trying to work
-  // around React dep arrays triggering unintended effects from
-  // running in the Chat component
-  const handleTabChange = React.useCallback(
-    (newIndex: number) => {
-      const currentTabIndex = selectedIndex;
-      if (currentTabIndex === CHAT_TAB_INDEX) {
-        setUnseenMessages(0);
-      }
+  const onChatUnmount = React.useCallback(() => {
+    setChatVisible(false);
+    setUnseenMessages(0);
+  }, []);
 
-      setSelectedIndex(newIndex);
-    },
-    [selectedIndex],
-  );
-  const unseenMessages = selectedIndex !== CHAT_TAB_INDEX ? _unseenMessages : 0;
+  const unseenMessages = chatVisible ? 0 : _unseenMessages;
 
   if (!isMounted) return null;
 
@@ -506,6 +490,25 @@ function Groups() {
           messagesContainerClassName="q__chat-messages-container"
           onNewMessage={onNewMessage}
           chat={chat}
+          onMount={onChatMount}
+          onUnmount={onChatUnmount}
+        />
+      ) : null}
+    </div>
+  );
+
+  const ownGroupElement = (
+    <div className="stack md">
+      <GroupCard
+        group={data.groups.own}
+        mapListPreference={data.groups.own.mapListPreference}
+        ownRole={data.role}
+        ownGroup
+      />
+      {ownGroup.inviteCode ? (
+        <MemberAdder
+          inviteCode={ownGroup.inviteCode}
+          trustedPlayers={data.trustedPlayers}
         />
       ) : null}
     </div>
@@ -517,17 +520,38 @@ function Groups() {
         "q__groups-container__mobile": isMobile,
       })}
     >
-      {!isMobile ? chatElement : null}
+      {!isMobile ? (
+        <div>
+          <NewTabs
+            tabs={[
+              {
+                label: "Roster",
+                number: data.groups.own.members!.length,
+              },
+              {
+                label: "Chat",
+                hidden: !data.chatCode,
+                number: unseenMessages,
+              },
+            ]}
+            content={[
+              {
+                key: "own",
+                element: ownGroupElement,
+              },
+              {
+                key: "chat",
+                element: chatElement,
+                hidden: !data.chatCode,
+              },
+            ]}
+          />
+        </div>
+      ) : null}
       <div className="q__groups-inner-container">
         <NewTabs
           scrolling={isMobile}
-          selectedIndex={selectedIndex}
-          setSelectedIndex={handleTabChange}
           tabs={[
-            {
-              label: "Roster",
-              number: data.groups.own.members!.length,
-            },
             {
               label: "Groups",
               number: data.groups.neutral.length,
@@ -537,35 +561,18 @@ function Groups() {
               number: data.groups.likesReceived.length,
               hidden: !isMobile,
             },
+            {
+              label: "Roster",
+              number: data.groups.own.members!.length,
+              hidden: !isMobile,
+            },
             {
               label: "Chat",
               hidden: !isMobile || !data.chatCode,
               number: unseenMessages,
             },
-            // {
-            //   label: "Filter",
-            // },
           ]}
           content={[
-            {
-              key: "own",
-              element: (
-                <div className="stack md">
-                  <GroupCard
-                    group={data.groups.own}
-                    mapListPreference={data.groups.own.mapListPreference}
-                    ownRole={data.role}
-                    ownGroup
-                  />
-                  {ownGroup.inviteCode ? (
-                    <MemberAdder
-                      inviteCode={ownGroup.inviteCode}
-                      trustedPlayers={data.trustedPlayers}
-                    />
-                  ) : null}
-                </div>
-              ),
-            },
             {
               key: "groups",
               element: (
@@ -617,15 +624,16 @@ function Groups() {
                 </div>
               ),
             },
+            {
+              key: "own",
+              hidden: !isMobile,
+              element: ownGroupElement,
+            },
             {
               key: "chat",
               element: chatElement,
               hidden: !isMobile || !data.chatCode,
             },
-            // {
-            //   key: "filters",
-            //   element: <div>filters</div>,
-            // },
           ]}
         />
       </div>