From 0e4356516149fc886fe77a8b82be3e860fe3313a Mon Sep 17 00:00:00 2001
From: Kalle <38327916+Sendouc@users.noreply.github.com>
Date: Mon, 3 Aug 2026 09:51:16 +0300
Subject: [PATCH] Progress

---
 .../map-list-generator-search-params.ts             |  9 +--------
 .../tier-list-maker-search-params.ts                | 13 ++-----------
 app/modules/search-params/search-params.ts          |  2 --
 3 files changed, 3 insertions(+), 21 deletions(-)

diff --git a/app/features/map-list-generator/map-list-generator-search-params.ts b/app/features/map-list-generator/map-list-generator-search-params.ts
index 7b633fe23..3c59acd21 100644
--- a/app/features/map-list-generator/map-list-generator-search-params.ts
+++ b/app/features/map-list-generator/map-list-generator-search-params.ts
@@ -3,13 +3,6 @@ import * as SearchParams from "~/modules/search-params/search-params";
 import { SP } from "~/modules/search-params/search-params";
 import { MapPool } from "./core/map-pool";
 
-// xxx: consider where we really need to support legacy
-const presenceBoolean = z.codec(z.string(), z.boolean(), {
-	// legacy decode fallback: bare `?readonly` (empty value) counts as true
-	decode: (value) => value === "" || value === "true",
-	encode: (value) => String(value),
-});
-
 export const mapListGeneratorSearchParams = SearchParams.define({
 	pool: SP.param(z.string(), {
 		default: MapPool.ANARCHY.serialized,
@@ -21,5 +14,5 @@ export const mapListGeneratorSearchParams = SearchParams.define({
 		resets: ["pool"],
 		loader: false,
 	}),
-	readonly: SP.custom(presenceBoolean, { default: false, loader: false }),
+	readonly: SP.param(z.boolean(), { default: false, loader: false }),
 });
diff --git a/app/features/tier-list-maker/tier-list-maker-search-params.ts b/app/features/tier-list-maker/tier-list-maker-search-params.ts
index 1b4c3c96f..9438bd734 100644
--- a/app/features/tier-list-maker/tier-list-maker-search-params.ts
+++ b/app/features/tier-list-maker/tier-list-maker-search-params.ts
@@ -2,7 +2,6 @@ import { z } from "zod";
 import { rankedModesShort } from "~/modules/in-game-lists/modes";
 import * as SearchParams from "~/modules/search-params/search-params";
 import { SP } from "~/modules/search-params/search-params";
-import { decompressFromBase64 } from "~/utils/compression";
 import { modeShort } from "~/utils/zod";
 import { DEFAULT_TIERS } from "./tier-list-maker-constants";
 import {
@@ -19,7 +18,7 @@ const EMPTY_TIER_LIST_STATE: TierListState = {
 const tierListState = z.codec(z.string(), z.custom<TierListState>(), {
 	decode: (value, payload) => {
 		const serialized =
-			parseSerializedJson(value) ?? parseLegacySignaturelessBase64(value);
+			parseSerializedJson(value);
 		if (!serialized) {
 			payload.issues.push({
 				code: "custom",
@@ -71,12 +70,4 @@ function parseSerializedJson(value: string) {
 
 	const parsed = tierListStateSerializedSchema.safeParse(json);
 	return parsed.success ? parsed.data : null;
-}
-
-// xxx: probably legacy support not needed?
-function parseLegacySignaturelessBase64(value: string) {
-	const json = decompressFromBase64(value);
-	if (json === null) return null;
-
-	return parseSerializedJson(json);
-}
+}
\ No newline at end of file
diff --git a/app/modules/search-params/search-params.ts b/app/modules/search-params/search-params.ts
index 6e99818c5..a969713fc 100644
--- a/app/modules/search-params/search-params.ts
+++ b/app/modules/search-params/search-params.ts
@@ -3,8 +3,6 @@ import { isDeepEqual } from "remeda";
 import { z } from "zod";
 import { compressToBase64, decompressFromBase64 } from "~/utils/compression";
 
-// xxx: e2e test that loader: false indeed does not send a request
-
 const COMPRESSED_PREFIX = "lz~";
 const ESCAPED_PREFIX = "lz~~";
 const DECODE_CACHE_MAX_SIZE = 300;