From 02d92b07ae100fdceae52d6e8a188318596563a7 Mon Sep 17 00:00:00 2001
From: Kalle <38327916+Sendouc@users.noreply.github.com>
Date: Tue, 4 Mar 2025 22:04:17 +0200
Subject: [PATCH] Fix "get perms" alert not shown if no video adder perms

---
 app/features/vods/routes/vods.new.tsx | 11 +++++++++++
 locales/en/vods.json                  |  2 +-
 2 files changed, 12 insertions(+), 1 deletion(-)

diff --git a/app/features/vods/routes/vods.new.tsx b/app/features/vods/routes/vods.new.tsx
index 1e08e283c..6bc3d9d04 100644
--- a/app/features/vods/routes/vods.new.tsx
+++ b/app/features/vods/routes/vods.new.tsx
@@ -35,10 +35,12 @@ import {
 } from "~/utils/remix.server";
 import { vodVideoPage } from "~/utils/urls";
 import { actualNumber, id } from "~/utils/zod";
+import { Alert } from "../../../components/Alert";
 import { DateFormField } from "../../../components/form/DateFormField";
 import { MyForm } from "../../../components/form/MyForm";
 import { SelectFormField } from "../../../components/form/SelectFormField";
 import { TextFormField } from "../../../components/form/TextFormField";
+import { useUser } from "../../auth/core/user";
 import { createVod, updateVodByReplacing } from "../queries/createVod.server";
 import { findVodById } from "../queries/findVodById.server";
 import { videoMatchTypes } from "../vods-constants";
@@ -127,9 +129,18 @@ export const loader = async ({ request }: LoaderFunctionArgs) => {
 export type VodFormFields = z.infer<typeof videoInputSchema>;
 
 export default function NewVodPage() {
+	const user = useUser();
 	const data = useLoaderData<typeof loader>();
 	const { t } = useTranslation(["vods"]);
 
+	if (!user || !user.isVideoAdder) {
+		return (
+			<Main className="stack items-center">
+				<Alert variation="WARNING">{t("vods:gainPerms")}</Alert>
+			</Main>
+		);
+	}
+
 	return (
 		<Main halfWidth>
 			<MyForm
diff --git a/locales/en/vods.json b/locales/en/vods.json
index db6053988..967df2f2d 100644
--- a/locales/en/vods.json
+++ b/locales/en/vods.json
@@ -23,6 +23,6 @@
 	"forms.action.addMatch": "Add match",
 	"forms.action.deleteMatch": "Delete match",
 	"noVods": "No videos found matching this filter. Are we missing something? See the FAQ page on information about how to gain VoD uploading permissions.",
-	"gainPerms": "Please post on the helpdesk of our Discord to gain permissions to upload videos.",
+	"gainPerms": "Please post on the helpdesk of our Discord to gain permissions to upload videos",
 	"deleteConfirm": "Delete video with the title '{{title}}'?"
 }