From a898791a70d834fe829c50f8f9142f6236b9b358 Mon Sep 17 00:00:00 2001 From: GriffinR Date: Thu, 3 Apr 2025 16:22:26 -0400 Subject: [PATCH] Remove expensive calls to QGraphicsItemGroup::removefromGroup --- src/editor.cpp | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/editor.cpp b/src/editor.cpp index b29a47bc..08dc0146 100644 --- a/src/editor.cpp +++ b/src/editor.cpp @@ -1673,10 +1673,9 @@ void Editor::clearMapEvents() { if (events_group->scene()) { events_group->scene()->removeItem(events_group); } - for (QGraphicsItem *child : events_group->childItems()) { - events_group->removeFromGroup(child); - delete child; - } + // events_group does not own its children, the childrens' parent + // is set to the group's parent (and our group has no parent). + qDeleteAll(events_group->childItems()); delete events_group; events_group = nullptr; }