From 80a726ed9f0dc42fbe7ef2367de072e014f61d3f Mon Sep 17 00:00:00 2001
From: GriffinR <griffin.g.richards@gmail.com>
Date: Sun, 1 Mar 2026 19:50:12 -0500
Subject: [PATCH] Fix Qt5 build / warnings

---
 include/mainwindow.h                 | 21 ++++++++++-------
 include/scripting.h                  |  2 +-
 src/core/maplayout.cpp               |  1 +
 src/editor.cpp                       |  8 +++++--
 src/mainwindow.cpp                   | 35 ++++++++++++++++------------
 src/project.cpp                      |  1 +
 src/scriptapi/scripting.cpp          |  6 ++++-
 src/ui/eventframes.cpp               |  3 +++
 src/ui/mapview.cpp                   | 10 ++++----
 src/ui/shortcutseditor.cpp           |  2 +-
 src/ui/tileseteditor.cpp             | 24 +++++++------------
 src/ui/tileseteditortileselector.cpp |  2 ++
 src/ui/uintspinbox.cpp               |  6 +++--
 13 files changed, 70 insertions(+), 51 deletions(-)

diff --git a/include/mainwindow.h b/include/mainwindow.h
index ba4d173d..84bfef1b 100644
--- a/include/mainwindow.h
+++ b/include/mainwindow.h
@@ -2,15 +2,6 @@
 #ifndef MAINWINDOW_H
 #define MAINWINDOW_H
 
-#include <QString>
-#include <QModelIndex>
-#include <QMainWindow>
-#include <QStandardItemModel>
-#include <QGraphicsPixmapItem>
-#include <QGraphicsItemGroup>
-#include <QGraphicsSceneMouseEvent>
-#include <QCloseEvent>
-#include <QAbstractItemModel>
 #include "project.h"
 #include "orderedjson.h"
 #include "config.h"
@@ -36,6 +27,18 @@
 #include "resizelayoutpopup.h"
 #include "unlockableicon.h"
 
+#include <QAbstractItemModel>
+#include <QCloseEvent>
+#include <QGraphicsItemGroup>
+#include <QGraphicsPixmapItem>
+#include <QGraphicsSceneMouseEvent>
+#include <QModelIndex>
+#include <QMainWindow>
+#include <QStandardItemModel>
+#include <QStack>
+#include <QString>
+#include <QUndoView>
+
 #if __has_include(<QJSValue>)
 #include <QJSValue>
 #endif
diff --git a/include/scripting.h b/include/scripting.h
index 32fbaf7c..327ee126 100644
--- a/include/scripting.h
+++ b/include/scripting.h
@@ -152,7 +152,7 @@ public:
     static void cb_MainTabChanged(int, int) {};
     static void cb_MapViewTabChanged(int, int) {};
     static void cb_BorderVisibilityToggled(bool) {};
-    static QImage cb_EventSpriteLoading(const QString &, const QString &) {};
+    static QImage cb_EventSpriteLoading(const QString &, const QString &) {return QImage();}
 };
 
 #endif // QT_QML_LIB
diff --git a/src/core/maplayout.cpp b/src/core/maplayout.cpp
index 6cef6252..bb1f2dd9 100644
--- a/src/core/maplayout.cpp
+++ b/src/core/maplayout.cpp
@@ -8,6 +8,7 @@
 
 #include <QDir>
 #include <QRegularExpression>
+#include <QtMath>
 
 QList<int> Layout::s_globalMetatileLayerOrder;
 QList<float> Layout::s_globalMetatileLayerOpacity;
diff --git a/src/editor.cpp b/src/editor.cpp
index 8c77b0a3..9e521d78 100644
--- a/src/editor.cpp
+++ b/src/editor.cpp
@@ -14,11 +14,15 @@
 #include "validator.h"
 #include "message.h"
 #include "eventframes.h"
+
 #include <QCheckBox>
-#include <QPainter>
-#include <QMouseEvent>
+#include <QDesktopServices>
 #include <QDir>
+#include <QMouseEvent>
+#include <QPainter>
 #include <QProcess>
+#include <QTimer>
+
 #include <math.h>
 
 static bool selectNewEvents = false;
diff --git a/src/mainwindow.cpp b/src/mainwindow.cpp
index 1e03cc78..87863da2 100644
--- a/src/mainwindow.cpp
+++ b/src/mainwindow.cpp
@@ -32,23 +32,28 @@
 #include "version.h"
 
 #include <QClipboard>
-#include <QDirIterator>
-#include <QStandardItemModel>
-#include <QSpinBox>
-#include <QTextEdit>
-#include <QSpacerItem>
-#include <QFont>
-#include <QScrollBar>
-#include <QPushButton>
-#include <QDialogButtonBox>
-#include <QScroller>
-#include <math.h>
-#include <QSysInfo>
 #include <QDesktopServices>
-#include <QTransform>
-#include <QSignalBlocker>
-#include <QSet>
+#include <QDialogButtonBox>
+#include <QDirIterator>
+#include <QFont>
+#include <QJsonDocument>
 #include <QLoggingCategory>
+#include <QPushButton>
+#include <QRandomGenerator>
+#include <QScreen>
+#include <QScrollBar>
+#include <QScroller>
+#include <QSet>
+#include <QSignalBlocker>
+#include <QSpacerItem>
+#include <QSpinBox>
+#include <QSysInfo>
+#include <QStandardItemModel>
+#include <QTextEdit>
+#include <QTransform>
+#include <QWindow>
+
+#include <math.h>
 
 // We only publish release binaries for Windows and macOS.
 // This is relevant for the update promoter, which alerts users of a new release.
diff --git a/src/project.cpp b/src/project.cpp
index e32311a0..63f9f238 100644
--- a/src/project.cpp
+++ b/src/project.cpp
@@ -26,6 +26,7 @@
 #include <QRegularExpression>
 #include <QStandardItem>
 #include <QTextStream>
+#include <QtMath>
 
 #include <algorithm>
 
diff --git a/src/scriptapi/scripting.cpp b/src/scriptapi/scripting.cpp
index 5b4bca25..9dd14bba 100644
--- a/src/scriptapi/scripting.cpp
+++ b/src/scriptapi/scripting.cpp
@@ -183,7 +183,11 @@ QAction* Scripting::registerAction(const QString &functionName, const QString &a
 
     auto menu = instance->mainWindow->ui->menuTools;
     if (instance->actionScripts.isEmpty()) {
-        instance->actionScripts.append({.action = menu->addSection("Custom Actions")});
+        instance->actionScripts.append({
+            .script = nullptr,
+            .action = menu->addSection("Custom Actions"),
+            .functionName = "",
+        });
     }
 
     const int actionIndex = instance->actionScripts.size();
diff --git a/src/ui/eventframes.cpp b/src/ui/eventframes.cpp
index f812e9ca..3a7311ad 100644
--- a/src/ui/eventframes.cpp
+++ b/src/ui/eventframes.cpp
@@ -3,6 +3,9 @@
 #include "editcommands.h"
 #include "eventpixmapitem.h"
 
+#include <QCompleter>
+#include <QFileIconProvider>
+
 #include <limits>
 using std::numeric_limits;
 
diff --git a/src/ui/mapview.cpp b/src/ui/mapview.cpp
index baaebef2..23382e7f 100644
--- a/src/ui/mapview.cpp
+++ b/src/ui/mapview.cpp
@@ -46,22 +46,22 @@ void MapView::drawForeground(QPainter *painter, const QRectF&) {
         editor->cursorMapTileRect->paint(painter, &option, this);
 }
 
-void MapView::renderOverlay(QPainter *painter) {
 #ifdef QT_QML_LIB
+void MapView::renderOverlay(QPainter *painter) {
     for (auto outerIt = this->overlayMap.constBegin(); outerIt != this->overlayMap.constEnd(); outerIt++)
     for (auto innerIt = outerIt.value().constBegin(); innerIt != outerIt.value().constEnd(); innerIt++) {
         innerIt.value()->renderItems(painter);
     }
-#endif
 }
-
 void MapView::clearOverlay() {
-#ifdef QT_QML_LIB
     for (auto outerIt = this->overlayMap.constBegin(); outerIt != this->overlayMap.constEnd(); outerIt++)
     for (auto innerIt = outerIt.value().constBegin(); innerIt != outerIt.value().constEnd(); innerIt++) {
         delete innerIt.value();
     }
     this->overlayMap.clear();
     this->hashToPriority.clear();
-#endif
 }
+#else
+void MapView::renderOverlay(QPainter*) {}
+void MapView::clearOverlay() {}
+#endif
diff --git a/src/ui/shortcutseditor.cpp b/src/ui/shortcutseditor.cpp
index 77cb9c47..ce1e578d 100644
--- a/src/ui/shortcutseditor.cpp
+++ b/src/ui/shortcutseditor.cpp
@@ -201,7 +201,7 @@ QList<MultiKeyEdit *> ShortcutsEditor::siblings(MultiKeyEdit *multiKeyEdit) cons
 }
 
 void ShortcutsEditor::promptUserOnDuplicateFound(MultiKeyEdit *sender, MultiKeyEdit *sibling) {
-    const auto duplicateKeySequence = sender->keySequences().last();
+    const auto duplicateKeySequence = sender->keySequences().constLast();
     const auto siblingLabel = this->labels_objects.key(multiKeyEdits_objects.value(sibling));
     if (siblingLabel.isEmpty())
         return;
diff --git a/src/ui/tileseteditor.cpp b/src/ui/tileseteditor.cpp
index 01bf2760..78f72c20 100644
--- a/src/ui/tileseteditor.cpp
+++ b/src/ui/tileseteditor.cpp
@@ -383,11 +383,9 @@ void TilesetEditor::applyUserShortcuts() {
 
 void TilesetEditor::onWindowActivated() {
     // User may have made layout edits since window was last focused, so update counts
-    if (this->metatileSelector) {
-        if (this->metatileSelector->selectorShowUnused || this->metatileSelector->selectorShowCounts) {
-            countMetatileUsage();
-            this->metatileSelector->draw();
-        }
+    if (this->metatileSelector->selectorShowUnused || this->metatileSelector->selectorShowCounts) {
+        countMetatileUsage();
+        this->metatileSelector->draw();
     }
 }
 
@@ -404,18 +402,14 @@ void TilesetEditor::refresh() {
     this->metatileSelector->setTilesets(this->primaryTileset, this->secondaryTileset);
     this->metatileSelector->select(this->getSelectedMetatileId());
 
-    if (metatileSelector) {
-        if (metatileSelector->selectorShowUnused || metatileSelector->selectorShowCounts) {
-            countMetatileUsage();
-            this->metatileSelector->draw();
-        }
+    if (this->metatileSelector->selectorShowUnused || this->metatileSelector->selectorShowCounts) {
+        countMetatileUsage();
+        this->metatileSelector->draw();
     }
 
-    if (tileSelector) {
-        if (tileSelector->showUnused) {
-            countTileUsage();
-            this->tileSelector->draw();
-        }
+    if (this->tileSelector->showUnused) {
+        countTileUsage();
+        this->tileSelector->draw();
     }
 
     this->redrawTileSelector();
diff --git a/src/ui/tileseteditortileselector.cpp b/src/ui/tileseteditortileselector.cpp
index 204d99c8..74d885e9 100644
--- a/src/ui/tileseteditortileselector.cpp
+++ b/src/ui/tileseteditortileselector.cpp
@@ -1,7 +1,9 @@
 #include "tileseteditortileselector.h"
 #include "imageproviders.h"
 #include "project.h"
+
 #include <QPainter>
+#include <QtMath>
 #include <QVector>
 
 QSize TilesetEditorTileSelector::getSelectionDimensions() const {
diff --git a/src/ui/uintspinbox.cpp b/src/ui/uintspinbox.cpp
index de3c9fb8..b4da4b22 100644
--- a/src/ui/uintspinbox.cpp
+++ b/src/ui/uintspinbox.cpp
@@ -58,10 +58,12 @@ void UIntSpinBox::setRange(uint32_t min, uint32_t max) {
     m_minimum = min;
     m_maximum = max;
 
+    // Clamping to % is a little cleaner than std::clamp when dealing with masks,
+    // which is the main use case for uintspinbox.
     if (m_value < min)
-        m_value %= min;
+        m_value %= min; // min can't be 0 here
     else if (m_value > max)
-        m_value %= max;
+        m_value = max ? (m_value % max) : 0;
     this->updateEdit();
 }