From 7173503f5905dfa5c6cb04c4b8ed83952d3f31b8 Mon Sep 17 00:00:00 2001
From: GriffinR <griffin.g.richards@gmail.com>
Date: Wed, 5 Feb 2025 16:17:06 -0500
Subject: [PATCH] Fix Qt5 build, misc warnings

---
 include/core/tileset.h           | 2 +-
 include/lib/fex/array_value.h    | 1 +
 include/ui/encountertablemodel.h | 4 ++--
 include/ui/mapheaderform.h       | 4 ++--
 include/ui/newlocationdialog.h   | 2 +-
 src/core/tileset.cpp             | 3 ++-
 src/ui/wildmonchart.cpp          | 2 +-
 7 files changed, 10 insertions(+), 8 deletions(-)

diff --git a/include/core/tileset.h b/include/core/tileset.h
index 999e731d..32d18858 100644
--- a/include/core/tileset.h
+++ b/include/core/tileset.h
@@ -80,7 +80,7 @@ public:
     Metatile* metatileAt(unsigned int i) const { return m_metatiles.at(i); }
 
     void clearMetatiles();
-    void resizeMetatiles(unsigned int newNumMetatiles);
+    void resizeMetatiles(int newNumMetatiles);
     int numMetatiles() const { return m_metatiles.length(); }
 
 private:
diff --git a/include/lib/fex/array_value.h b/include/lib/fex/array_value.h
index 642cc129..3339d21a 100644
--- a/include/lib/fex/array_value.h
+++ b/include/lib/fex/array_value.h
@@ -96,6 +96,7 @@ namespace fex
             case Type::kValuePair:
                 return pair_.first + " = " + pair_.second->ToString() + "\n";
             }
+            return "";
         }
 
         static ArrayValue Empty()
diff --git a/include/ui/encountertablemodel.h b/include/ui/encountertablemodel.h
index 6fe54a91..157e0771 100644
--- a/include/ui/encountertablemodel.h
+++ b/include/ui/encountertablemodel.h
@@ -30,7 +30,7 @@ public:
 
     WildMonInfo encounterData() const { return m_monInfo; }
     EncounterField encounterField() const { return m_encounterField; }
-    QList<double> percentages() const { return m_slotPercentages; }
+    QVector<double> percentages() const { return m_slotPercentages; }
 
 private:
     int m_numRows = 0;
@@ -38,7 +38,7 @@ private:
     WildMonInfo m_monInfo;
     EncounterField m_encounterField;
     QMap<int,QString> m_groupNames;
-    QList<double> m_slotPercentages;
+    QVector<double> m_slotPercentages;
 
 signals:
     void edited();
diff --git a/include/ui/mapheaderform.h b/include/ui/mapheaderform.h
index 8f9adda8..79f4f6c8 100644
--- a/include/ui/mapheaderform.h
+++ b/include/ui/mapheaderform.h
@@ -9,9 +9,9 @@
 
 #include <QWidget>
 #include <QPointer>
-#include "mapheader.h"
 
-class Project;
+#include "mapheader.h"
+#include "project.h"
 
 namespace Ui {
 class MapHeaderForm;
diff --git a/include/ui/newlocationdialog.h b/include/ui/newlocationdialog.h
index 33af5c9c..a98b2d61 100644
--- a/include/ui/newlocationdialog.h
+++ b/include/ui/newlocationdialog.h
@@ -5,7 +5,7 @@
 #include <QAbstractButton>
 #include <QPointer>
 
-class Project;
+#include "project.h"
 
 namespace Ui {
 class NewLocationDialog;
diff --git a/src/core/tileset.cpp b/src/core/tileset.cpp
index e79e7706..20590369 100644
--- a/src/core/tileset.cpp
+++ b/src/core/tileset.cpp
@@ -83,7 +83,8 @@ void Tileset::addMetatile(Metatile* metatile) {
     m_metatiles.append(metatile);
 }
 
-void Tileset::resizeMetatiles(unsigned int newNumMetatiles) {
+void Tileset::resizeMetatiles(int newNumMetatiles) {
+    if (newNumMetatiles < 0) newNumMetatiles = 0;
     while (m_metatiles.length() > newNumMetatiles) {
         delete m_metatiles.takeLast();
     }
diff --git a/src/ui/wildmonchart.cpp b/src/ui/wildmonchart.cpp
index 80c41f81..c27e7968 100644
--- a/src/ui/wildmonchart.cpp
+++ b/src/ui/wildmonchart.cpp
@@ -109,7 +109,7 @@ void WildMonChart::readTable() {
     }
     
     // Read data from the table, combining data for duplicate entries
-    const QList<double> tableFrequencies = this->table->percentages();
+    const QVector<double> tableFrequencies = this->table->percentages();
     const QVector<WildPokemon> tablePokemon = this->table->encounterData().wildPokemon;
     const int numRows = qMin(tableFrequencies.length(), tablePokemon.length());
     const QString speciesPrefix = projectConfig.getIdentifier(ProjectIdentifier::define_species_prefix);