diff --git a/include/config.h b/include/config.h index 7f263da0..b05e4387 100644 --- a/include/config.h +++ b/include/config.h @@ -155,8 +155,8 @@ protected: virtual void setUnreadKeys() override {}; private: - QString stringFromByteArray(QByteArray); - QByteArray bytesFromString(QString); + QString stringFromByteArray(const QByteArray&); + QByteArray bytesFromString(const QString&); QStringList recentProjects; QByteArray mainWindowGeometry; diff --git a/src/config.cpp b/src/config.cpp index b22972a4..c4221d30 100644 --- a/src/config.cpp +++ b/src/config.cpp @@ -496,18 +496,18 @@ QMap PorymapConfig::getKeyValueMap() { return map; } -QString PorymapConfig::stringFromByteArray(QByteArray bytearray) { +QString PorymapConfig::stringFromByteArray(const QByteArray &bytearray) { QString ret; - for (auto ch : bytearray) { + for (const auto &ch : bytearray) { ret += QString::number(static_cast(ch)) + ":"; } return ret; } -QByteArray PorymapConfig::bytesFromString(QString in) { +QByteArray PorymapConfig::bytesFromString(const QString &in) { QByteArray ba; - QStringList split = in.split(":"); - for (auto ch : split) { + QStringList split = in.split(":", Qt::SkipEmptyParts); + for (const auto &ch : split) { ba.append(static_cast(ch.toInt())); } return ba;