Leahnaya/porymap
1
0
Fork 0
mirror of https://github.com/huderlem/porymap.git synced 2026-03-21 17:45:44 -05:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix missing error messages
Some checks failed
Build Porymap / build-linux (, 5.14.2) (push) Has been cancelled
Details
Build Porymap / build-linux (, 6.8.*) (push) Has been cancelled
Details
Build Porymap / build-linux (minimal, 5.14.2) (push) Has been cancelled
Details
Build Porymap / build-macos (macos-15-intel) (push) Has been cancelled
Details
Build Porymap / build-macos (macos-latest) (push) Has been cancelled
Details
Build Porymap / build-static-windows (push) Has been cancelled
Details

Browse Source
This commit is contained in:
GriffinR 2026-01-30 15:11:02 -05:00
parent 87e4c3fe68
commit 111a3cda9d
1 changed files with 11 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
src/scriptapi/scripting.cpp
View File

@ -200,21 +200,23 @@ QAction* Scripting::registerAction(const QString &functionName, const QString &a
void Scripting::invokeAction(int actionIndex) {
const ActionScript actionScript = this->actionScripts.value(actionIndex);
if (!actionScript.script || actionScript.functionName.isEmpty()) return;
if (!actionScript.script || !actionScript.action || actionScript.functionName.isEmpty()) return;
QJSValue callbackFunction = actionScript.script->module().property(actionScript.functionName);
if (callbackFunction.isUndefined()) {
logError(QString("Unknown custom script function '%1'").arg(actionScript.functionName));
QMessageBox messageBox(this->mainWindow);
messageBox.setText("Failed to run custom action");
messageBox.setInformativeText(getMostRecentError());
messageBox.setIcon(QMessageBox::Warning);
messageBox.addButton(QMessageBox::Ok);
messageBox.exec();
logError(QString("Function '%1' is not defined and exported in '%2'")
.arg(actionScript.functionName)
.arg(actionScript.script->filepath()));
const QString message = QString("Failed to run '%1'").arg(actionScript.action->text());
RecentErrorMessage::show(message, this->mainWindow);
return;
}
if (!callbackFunction.isCallable()) {
logError("TODO: Not callable");
logError(QString("'%1' in '%2' is not a callable function.")
.arg(actionScript.functionName)
.arg(actionScript.script->filepath()));
const QString message = QString("Failed to run '%1'").arg(actionScript.action->text());
RecentErrorMessage::show(message, this->mainWindow);
return;
}
if (tryErrorJS(callbackFunction)) return;