diff --git a/docs/translation_log.md b/docs/translation_log.md index 866b52b5..f12ae3a2 100644 --- a/docs/translation_log.md +++ b/docs/translation_log.md @@ -1850,3 +1850,27 @@ If you need to exclude RGBASM-conditional content, add a filter to the generator - **Notes:** Translated text_far and text_end macros into byte directives. --- + +## ShroudedInMistText + +- **Source:** `engine/battle/move_effects/mist.asm:ShroudedInMistText` +- **Translated:** `dos_port/src/engine/battle/move_effects/mist.asm` +- **Date:** 2026-06-23 +- **H-flag:** not involved +- **Bug tags:** none +- **Registers:** none +- **Notes:** explicit byte directives for text_far and text_end + +--- + +## OneHitKOEffect_ + +- **Source:** `engine/battle/move_effects/one_hit_ko.asm:OneHitKOEffect_` +- **Translated:** `dos_port/src/engine/battle/move_effects/one_hit_ko.asm` +- **Date:** 2026-06-23 +- **H-flag:** computed +- **Bug tags:** none +- **Registers:** HL->ESI, DE->EDI, A->AL, B->BH +- **Notes:** Translated exactly matching 8-bit operations. + +--- diff --git a/dos_port/src/engine/battle/move_effects/mist.asm b/dos_port/src/engine/battle/move_effects/mist.asm index 4428e69b..eedd0bd5 100644 --- a/dos_port/src/engine/battle/move_effects/mist.asm +++ b/dos_port/src/engine/battle/move_effects/mist.asm @@ -30,7 +30,6 @@ MistEffect_: jmp PrintButItFailedText_ ShroudedInMistText: - db 0x0A ; TX_PAUSE - db 0x17 ; TX_FAR - dd _ShroudedInMistText - db 0x50 ; TX_END + db 0x17 ; text_far + dd _ShroudedInMistText + db 0x50 ; text_end diff --git a/dos_port/src/engine/battle/move_effects/one_hit_ko.asm b/dos_port/src/engine/battle/move_effects/one_hit_ko.asm index 45a51eb3..bed2a9fa 100644 --- a/dos_port/src/engine/battle/move_effects/one_hit_ko.asm +++ b/dos_port/src/engine/battle/move_effects/one_hit_ko.asm @@ -14,39 +14,39 @@ global OneHitKOEffect_ OneHitKOEffect_: mov esi, wDamage xor al, al - mov [ebp + esi], al + mov byte [ebp + esi], al inc esi - mov [ebp + esi], al + mov byte [ebp + esi], al dec al - mov [ebp + wCriticalHitOrOHKO], al + mov byte [ebp + wCriticalHitOrOHKO], al mov esi, wBattleMonSpeed + 1 mov edi, wEnemyMonSpeed + 1 - mov al, [ebp + hWhoseTurn] - and al, al + mov al, byte [ebp + hWhoseTurn] + test al, al jz .compareSpeed mov esi, wEnemyMonSpeed + 1 mov edi, wBattleMonSpeed + 1 .compareSpeed: - mov al, [ebp + edi] + mov al, byte [ebp + edi] dec edi - mov bl, al - mov al, [ebp + esi] + mov bh, al + mov al, byte [ebp + esi] dec esi - sub al, bl - mov al, [ebp + edi] - mov bl, al - mov al, [ebp + esi] - sbb al, bl + sub al, bh + mov al, byte [ebp + edi] + mov bh, al + mov al, byte [ebp + esi] + sbb al, bh jc .userIsSlower mov esi, wDamage mov al, 0xff - mov [ebp + esi], al + mov byte [ebp + esi], al inc esi - mov [ebp + esi], al - mov al, 0x2 - mov [ebp + wCriticalHitOrOHKO], al + mov byte [ebp + esi], al + mov al, 0x02 + mov byte [ebp + wCriticalHitOrOHKO], al ret .userIsSlower: - mov al, 0x1 - mov [ebp + wMoveMissed], al + mov al, 0x01 + mov byte [ebp + wMoveMissed], al ret