Commit Graph

574 Commits

Author SHA1 Message Date
mdraves91
790c5022ab fix: bank1calls to functions that were not yet disassembled were generating Func_xxx labels that did not point to bank1 2025-11-05 10:39:38 -06:00
earthoul
8f3db0ab88
Fix tileset labels + refactoring 2025-11-05 21:39:40 +09:00
earthoul
31130185df
Fix GR Blimp labels and file names 2025-11-05 19:02:58 +09:00
earthoul
f25a04fb76
Identify songs and slot SFXs
Also refactor song labels and files
2025-11-05 18:54:49 +09:00
earthoul
6d55435c70
Update SFX file names
Also identify TCG1 leftovers and re-organize a few labels
2025-11-05 14:48:57 +09:00
mdraves91
65c9e971c4 fix: jr opcodes being output twice 2025-11-04 21:30:05 -06:00
mdraves91
de2035f223 change the way tcg2disasm.py handles "end" offsets provided to the script, and allow multiple addresses to be passed for disassembly
This allows a more flexible script when working with or without the new recursive feature.

Also, the previous behavior was very unintuitive, and probably not that helpful.

Before, if you provided an "end" offset, the script would go AT LEAST as far as that offset, but would not terminate if it still hadn't found a ret command, and had satisfied all of the other stop conditions. This made it very easy to pass an "end" argument that caused the script to disassemble past the real end of the function, and in many cases get stuck in an infinite loop.

However, if you also provided the "dry-run" arg, it would set the "hard stop" flag, which instead made it so that the disassembler would actually stop dead when hitting the "end" offset.

Now, you must pass the stop offset to the --hard-stop arg, and it will act like the previous dry-run/hard-stop. The other behavior (that likes to get stuck in infinite loops) is no longer available.
2025-11-04 19:22:08 -06:00
mdraves91
9746b0537f adding new args to tcg2disasm.py: --recurse and --sections 2025-11-04 19:20:06 -06:00
mdraves91
2e1b001e67 chore: typo in comment 2025-11-04 19:05:09 -06:00
dannye
41404905c0 Don't append "_" to 0
fixes an error with rgbds 1.0.0
2025-11-04 17:48:11 -06:00
earthoul
b451f77d14
Update SFX headers 2025-11-04 00:16:00 +09:00
earthoul
485bf674dd
Update SFX and Duel Anim labels
TODO: Rename files and re-sort SFX functions
2025-11-03 23:18:59 +09:00
dannye
85b7d136aa Minor cleanup 2025-11-02 21:52:31 -06:00
re-cache
9492a7b88e
Label unknown fields in DeckIDData in bank09.asm (#41) 2025-11-02 21:50:23 -06:00
dannye
6a87fcba53 Replace a few script constants 2025-11-02 11:03:54 -06:00
dannye
1a5595d369 Replace a few text IDs 2025-11-02 09:54:53 -06:00
mdraves91
6fd5e6feb2 disassemble menu box params for Debug menu 2025-11-02 08:05:34 -06:00
mdraves91
c680773a65 fix: switch to new hardware.inc constants after git rebase 2025-11-02 07:44:17 -06:00
mdraves91
7ad92b20be documenting debug effect viewer 2025-11-02 07:44:13 -06:00
mdraves91
724cebb8c8 disassemble debug effect viewer 2025-11-02 07:43:17 -06:00
mdraves91
e25e6379e2 documenting debug slot machine function and debug duel function 2025-11-02 07:43:02 -06:00
mdraves91
5b710cf19e disassembling two more Startup Debug Menu functions 2025-11-02 07:41:02 -06:00
mdraves91
b1c49fd907 naming and documenting Startup Debug Menu 'config' option, and config menu functions 2025-11-02 07:41:01 -06:00
mdraves91
32f9e985ca disassembling function for Startup Debug Menu 'config' option 2025-11-02 07:41:01 -06:00
mdraves91
afe9b914ac naming and documenting StartupDebugMenu coin option 2025-11-02 07:41:00 -06:00
mdraves91
342d6ac1f2 disassembling function for Startup Debug Menu coins option 2025-11-02 07:41:00 -06:00
mdraves91
2dfe2e351a labelling the already disassembled functions for StartupDebugMenu 2025-11-02 07:41:00 -06:00
mdraves91
89d807ffae naming and documenting StartupDebugMenu functions 2025-11-02 07:40:59 -06:00
mdraves91
21052a3f91 dumping functions for start-up debug menu 2025-11-02 07:40:59 -06:00
dannye
715c09dd87
Merge pull request #40 from mdraves91/map-header-functions-full-dump
Map header functions full dump (banks b, c, d, f, 10)
2025-11-01 23:50:31 -05:00
dannye
0b5c811a1d Use NULL for npcs with no script 2025-11-01 23:44:00 -05:00
dannye
9a00ca7a6b Misc script cleanup 2025-11-01 23:30:12 -05:00
dannye
5236ffc430 Misc bank11 cleanup 2025-11-01 21:17:58 -05:00
dannye
8f80bee785 Misc bank0e cleanup 2025-11-01 21:01:03 -05:00
dannye
68c4992d9f Misc bank0a cleanup 2025-11-01 20:15:15 -05:00
dannye
1efd632441 Misc bank07 cleanup 2025-11-01 19:59:32 -05:00
dannye
e30afed737 Misc bank04 cleanup
and other minor cleanup
2025-11-01 19:10:33 -05:00
Mitchell Draves
b509bce42c
Merge branch 'pret:master' into map-header-functions-full-dump 2025-10-31 10:36:05 -05:00
dannye
df2882a7a0 Misc bank02 cleanup 2025-10-30 20:13:17 -05:00
dannye
0ed8d267c3
Merge pull request #42 from ElectroDeoxys/master
Use hardware.inc
2025-10-30 18:15:04 -05:00
mdraves91
c38a7c5c61 make OtherPromoCards its own label 2025-10-30 15:48:26 -05:00
mdraves91
fc4583d314 filling in a few more NPCs 2025-10-30 09:19:55 -05:00
mdraves91
c3b99cf6e0 two more texts that I missed 2025-10-30 09:12:34 -05:00
mdraves91
a25dbf9ed1 making two labels separate functions per PR feedback 2025-10-30 09:08:58 -05:00
mdraves91
d8195c79b0 filling in constants and coords as per PR feedback
also dropped a few erroneous .loop

targeted these functions/wram:
$d576
PrintScrollableText_WithTextBoxLabelVRAM0
BankswitchVRAM
CallPlaySFX
PrintNumber
FillBoxInBGMapWithZero
LoadScene
PrintTextInWideTextBox
2025-10-30 09:04:50 -05:00
Electro
d7d7f2558b Use hardware.inc 2025-10-30 10:45:20 +00:00
mdraves91
164563d06b filling in text constants, coords, and a few MUSIC_s
fixed up the inputs for these functions:
DrawWideTextBox_PrintText
DrawWideTextBox_PrintTextNoDelay
DrawWideTextBox_PrintTextWithYesOrNoMenu
DrawWideTextBox_WaitForInput
PrintScrollableText_NoTextBoxLabelVRAM0
YesOrNoMenuWithText
InitTextPrinting_ProcessTextFromID
Func_2c4b
Func_35af
Func_35bf
DrawRegularTextBox
DrawRegularTextBoxVRAM0
2025-10-28 21:01:45 -05:00
mdraves91
656018863c filling in more magic numbers
for these functions:
FillRectangle
RemoveCardFromCollection
2025-10-28 19:36:35 -05:00
mdraves91
adf1910950 filling in many constants, and changing many coords to use 'lb'
TILEMAP_, NPC_, PALETTE_ and directions were the main constants. I targeted these functions throughout the project, and fixed up their input params:

Func_12c0ce
LoadOWObjectInMap
SetOWObjectDirection
SetOWObjectTilePosition
GetOWObjectTilePosition
Func_10e3c
Func_336d
SetOWObjectTilePositionAndDirection
GetPalettesWithID
2025-10-28 19:24:32 -05:00
mdraves91
ce2291b33e filling in more VAR_ and music constants 2025-10-28 18:13:53 -05:00