Commit Graph

26 Commits

Author SHA1 Message Date
PikalaxALT
f5a444af5d Replace simple ewram access with battle struct, 2 2021-06-17 16:56:13 -04:00
GriffinR
5d6e7a31da
Merge pull request #788 from kazblox/master
Fix NONMATCHINGs and actual English Debug support
2020-08-19 01:04:35 -04:00
Kaz
7f94272bfa Actually fix everything. 2020-06-08 21:40:08 -04:00
Kaz
dfe734f435 Gah, handle this later when I actually add US rev1/2 debug support. 2020-06-08 11:21:47 -04:00
Kaz
2ec8ae4bec Preliminary support for English rev0 debug. Matching but still needs
cleaning up.
Rename DEBUG_TRANSLATE to DEBUG_FIX now that we have actual English
Debug ROMs.
Add Sapphire German "first edition" debug support, now that we have a
hash for it.
Fix an obvious nonmatching.
2020-06-08 04:12:23 -04:00
GriffinR
541c069857 Sync trainer_battle.inc 2020-04-27 13:48:11 -04:00
easyaspi314 (Devin)
98d87b1a47 Make DEBUG_TRANSLATE a makefile flag 2019-08-27 00:34:24 -04:00
easyaspi314 (Devin)
6eafbcabf3 Change data debug translations to use DEBUG_TRANSLATE
I'd prefer a macro, but preproc currently comes first.
2019-08-26 21:08:41 -04:00
easyaspi314 (Devin)
532e6397d5 .if ENGLISH != .ifdef ENGLISH 2019-08-24 00:11:41 -04:00
easyaspi314 (Devin)
a631973b73 [WIP] English Debug menu translations! (Plus some build system fixes)
I'm back!
                       す
Éß テ-ブ↑& ÒÛªù! (かなテーブルを捨てろよ!/Throw away the kana table!)

When compiled in English with DEBUG, instead of óじばÌ (mojibake),
you now get actual English translations!

No more switching from the game, to the kana chart, and if you don't know
Japanese, Google Translate, just to read one sentence.

Additionally, the few unknown translations should use proper encoding or
Romaji.

I decided to use a nicer macro system:

static const u8 sStrHello[] = DTR("こんにちは", "Hello");

This prevents ifdef HELL, as the mixed Japanese and English would
be messy.

Additionally, some special character issues were corrected.

Things untranslated/bugs:
 - Tomomichi's dummy functions. Of course, they don't do much.
 - The title screen battle menu. This uses a Gen 2 style tile rendering
   and the way it is rendered is incredibly overcomplicated.
 - A few phrases which I couldn't get a clear translation for. I don't know
   much Japanese lol.
 - Song names. Just tedious with the limited buffer size.
 - A few layout issues. Some dimensions should be tweaked to avoid text
   box ovetflows.
 - Potential buffer overflows, which I want to try to avoid
   - (ASan for GBA? :morphon:)
 - While I use the DEBUG_TRANSLATE flag (automatic with ENGLISH && DEBUG)
   for C code, the asm data only checks for ENGLISH && DEBUG. Additionally,
   they are ugly.
 - Haven't tested all builds yet.
 - Some code formatting issues.

I also made it so this will compile with the system preprocessor (including
Clang), and my agbcc binutils (which will attempt to be selected automatically
if you don't have DKP).

Clang needs a few flags (it can't do asm enums with line numbers and it does
trigraphs in standard mode), but it is no longer flipping out.

I am going to restart my build system project. It was getting way off track,
and ucpp was too difficult to maintain (one of the main reasons for the silence).
2019-08-23 20:44:01 -04:00
Marcus Huderle
66367c82ef Merge remote-tracking branch 'upstream/master' into btl_attrs 2018-04-05 18:41:42 -07:00
Blampharos
171dd32df8 Decompile gBattleTerrainTable
Forward declares introduced into graphics.h
2018-01-28 07:47:04 +01:00
Blampharos
5fd65682ef Remove commented out data that has been converted 2018-01-28 05:51:12 +01:00
Blampharos
0b469a6439 Decompile link battle animation data 2018-01-27 11:41:52 +01:00
Blampharos
c9f885eaa6 Decompile move names 2018-01-26 14:54:23 +01:00
Blampharos
ef4fe19cac Delete leftover include 2018-01-26 14:20:23 +01:00
Blampharos
6e8522af59 Decompile species names 2018-01-26 07:20:50 +01:00
Blampharos
0bf16dd66a Decompile trainer data
This necessitated changes in other files which access this data.

Three macro constants were migrated from trainer_constants.inc to
trainer.h

data/trainers.inc and data-de/trainers.inc have been deleted
2018-01-25 17:31:41 +01:00
Blampharos
7061864e49 Decompile trainer class names
This includes both German and English
2018-01-25 12:26:57 +01:00
Blampharos
2e61752e2c Decompile trainer party structs 2018-01-25 06:55:15 +01:00
Cameron Hall
329d9aa856 dump all remaining baseroms 2018-01-23 17:54:29 -06:00
Cameron Hall
e03633d6bc fix more false offsets 2018-01-23 16:55:48 -06:00
Cameron Hall
1685a7977a dump some debug baseroms 2018-01-22 21:42:14 -06:00
Blampharos
f9745abae0 Begin decompiling battle_1.c
Enemy backsprite data (palettes, coords, sprites) and foe elevation
data are converted in this commit
2018-01-22 11:32:52 +01:00
Cameron Hall
11a9371349 resolve merge conflicts and make it compile 2018-01-21 13:53:32 -06:00
ProjectRevoTPP
7860ce8dbe split data2a and make shop.c stuff static 2018-01-16 14:00:52 -05:00