Commit Graph

1358 Commits

Author SHA1 Message Date
h2o-DS
8f0da81c9d Merge remote-tracking branch 'upstream/main' into Pokedex_Menu_Text 2025-02-25 06:24:57 -05:00
h2o-DS
3281d4fe36 Polish
Created moved PokedexApp to pokedex_app.h
Documented some PokedexApp variable names
Decomposed PokedexOverlayData into PokedexApp double pointer
Extended PokedexBootMode names
2025-02-25 06:15:58 -05:00
Rachel
4763b753c0
Merge pull request #397 from Kuruyia/feat/document-map-prop-animation
Document map prop animation
2025-02-24 19:50:30 -08:00
Kuruyia
207f789689 Document map prop animation
This documents the `ov5_021D37AC.c` file, which is in charge of managing
the animations on map props.

The map prop animation code is actually split into two separate
managers:
* The `MapPropAnimationManager`, which is in charge of loading animation
  data from the two related NARC files, and managing long-running
  animations (e.g. Valley Windworks windmills, Fuego Ironworks furnace,
  Veilstone Game Corner lights...)
* The `MapPropOneShotAnimationManager`, which is in charge of loading
  and playing "one shot" animations (e.g. any door opening/closing, the
  Pokémon Center stairs...)

Signed-off-by: Kuruyia <github@kuruyia.net>
2025-02-24 11:53:11 +01:00
narf0708@gmail.com
4fe2b5aaf2 More PR feedback 2025-02-23 17:25:35 -05:00
narf0708@gmail.com
87a71f6728 PR feedback 2025-02-23 16:42:04 -05:00
narf0708@gmail.com
34f1d81aae Document unk_020480A8 as the JubilifeLottery 2025-02-23 16:31:42 -05:00
Rachel
dc5440a466
Merge pull request #393 from Viperio19/document-scripts
Some checks failed
build / build (push) Has been cancelled
Document lake trio cavern scripts
2025-02-23 12:38:27 -08:00
Rachel
2873d3f9e4
Merge pull request #392 from Kuruyia/feat/document-area-data
Some checks failed
build / build (push) Has been cancelled
Document area data
2025-02-22 11:32:39 -08:00
Kuruyia
be823a26bb Document area data
This documents the `ov5_021EF75C.c` file, which is in charge of loading
various "area data" NARCs that, in the end, contain the textures of
maps, the textures and models of map props, and lighting information.

Also, renamed `MapProp.id` to `MapProp.modelID` for more clarity
(especially when interacting with the new area data functions).

Signed-off-by: Kuruyia <github@kuruyia.net>
2025-02-22 13:38:54 +01:00
Gudf
bfa39b9d0d Rename FieldMenu to StartMenu 2025-02-20 21:54:54 +01:00
Rachel
a9bf501977
Merge pull request #388 from lucie-sharpe/PoketchDigitalClockApp
Some checks failed
build / build (push) Has been cancelled
Poketch digital clock app
2025-02-20 10:31:45 -08:00
Viperio19
913d67dd10 Document lake trio caverns 2025-02-20 18:14:04 +01:00
Lucie
1ba6d4ef66 renamed macros 2025-02-18 12:59:18 +00:00
Lucie
a322a18518 renamed files 2025-02-18 12:55:42 +00:00
Lucie
1f846ffa8a updated from PR review 2025-02-18 12:39:03 +00:00
RavePossum
98af4498e2
Merge pull request #384 from Kuruyia/feat/document-map-prop-matshp
Some checks failed
build / build (push) Has been cancelled
Document map prop material and shape
2025-02-17 11:21:42 -05:00
Kuruyia
96bcde71e3 Document map prop material and shape
This documents the `ov5_021D56BC.c` file, which is in charge of reading
the `build_model_matshp.dat` file from the ROM.

This file contains the material and shape IDs necessary to render the
map props that use the 1Mat1Shp rendering path from NitroSystem.

Signed-off-by: Kuruyia <github@kuruyia.net>
2025-02-17 11:53:23 +01:00
Lucie
cb954e4b48 Merge branch 'main' into PoketchDigitalClockApp
# Conflicts:
#	src/overlay026/ov26_022561C0.c
#	src/overlay026/ov26_02256404.c
2025-02-17 00:48:58 +00:00
Rachel
31dcd5a7ea
Merge pull request #387 from lucie-sharpe/Poketch
Some checks are pending
build / build (push) Waiting to run
Documented some Poketch functions
2025-02-16 16:42:19 -08:00
Lucie
ea5a361430 some task documentation 2025-02-17 00:24:59 +00:00
Lucie
45e4448c50 Merge branch 'main' into PoketchDigitalClockApp
# Conflicts:
#	src/overlay026/ov26_02256404.c
2025-02-16 23:00:01 +00:00
Lucie
ef15309bb8 renamed files 2025-02-16 22:45:57 +00:00
Lucie
1f642fcc48 document app graphics 2025-02-16 22:45:51 +00:00
Lucie
92ca6219a7 documented app manager 2025-02-16 22:45:43 +00:00
RavePossum
eb7c3f5bf6 Address PR feedback 2025-02-16 15:48:52 -05:00
RavePossum
9940057810 Start documenting how summary screen is accessed, move deleter scrcmds 2025-02-16 15:48:52 -05:00
RavePossum
5e30ca87ee Start documenting summary status constants, fix a few names in summary screen 2025-02-16 15:46:28 -05:00
RavePossum
df1c5349bc Mass rename a couple touch screen functions 2025-02-16 15:46:28 -05:00
RavePossum
da77879094 Summary button anim clean-up + misc constants 2025-02-16 15:46:28 -05:00
RavePossum
00f2fc263d More summary related constants, add PC box row/col/max constants 2025-02-16 15:46:28 -05:00
RavePossum
5630607524 Rename PokemonSummary max -> monMax, pos -> monIndex 2025-02-16 15:46:28 -05:00
RavePossum
ff412fbe76 Rename summary mode constants that could be better 2025-02-16 15:46:28 -05:00
Lucie
780b54ae5d
Merge branch 'main' into Poketch 2025-02-16 20:40:36 +00:00
Rachel
1b03304755 Address PR feedback:
- `resultVar` -> `destVarID`
- Clean up member names for `HiddenLocation` and `DistributionEvent`
- `Set/Clear` -> `Enable/Disable` for HiddenLocation script macros
- `ScrCmd_SetOrClearHiddenLocation` -> `ScrCmd_SetHiddenLocation`
- `SYSTEM_VARS_BLOCK_SIZE` -> `NUM_SYSTEM_VARS`
- Identify `scripts_unk_0412` -> `scripts_init_new_game`
- Add `SCRIPT_ID_OFFSET_INIT_NEW_GAME` constant definition
- Add `SCRIPT_ID` functional macro
- Use `SCRIPT_ID(INIT_NEW_GAME, 0)` in `FieldSystem_InitNewGameState`
- Promote `LCRNG_MULTIPLIER` in `math.c` from private to public
- Use private `LCRNG_INCREMENT` in `system_vars.c` for lottery sync
2025-02-16 12:26:47 -08:00
Rachel
5168755542 Document script commands that use system variables 2025-02-16 12:24:32 -08:00
Rachel
7d4eae3ff1 Document system_vars.c 2025-02-16 12:15:56 -08:00
Rachel
a1cade4fab Label extern routines in system_vars.c 2025-02-16 12:15:56 -08:00
Rachel
16afb2128a Identify unk_0206AFE0 -> system_vars 2025-02-16 12:15:56 -08:00
Rachel
d547039744
Merge pull request #385 from TheSylphIsIn/main
Partially document Poketch Party Status app
2025-02-16 11:23:12 -08:00
TheSylphIsIn
160efbbfe5 PR review #385 2025-02-15 22:24:59 -05:00
Rachel
decc172f34
Merge pull request #377 from Viperio19/document-scripts
Some checks are pending
build / build (push) Waiting to run
Document `scripts_pokemon_center_daily_trainers.s`
2025-02-15 18:20:01 -08:00
Lucie
029f8f48e0 updated header file 2025-02-16 01:19:15 +00:00
Lucie
a7350f0f4a Document Poketch get bgConfig func 2025-02-16 00:54:35 +00:00
h2o-DS
9d7b5d107b Resolve Merge Conflicts 2025-02-15 17:17:19 -05:00
Lucie
d1dabfe13b Document Poketch palette functions 2025-02-15 21:35:18 +00:00
h2o-DS
3a257e770a pokedex_main
ov21_021D0D80 -> pokedex_main
unk_0209ACBC-> pokedex_memory
struct_ov21_021D3320 -> pokedex_sort_data
UnkStruct_ov21_021D13FC -> PokedexGraphicData
UnkStruct_ov21_021D0F60 -> PokedexApp
enum HeapId HEAP_ID_POKEDEX
2025-02-15 16:23:46 -05:00
TheSylphIsIn
394c4e8274 formatting 2025-02-15 13:58:22 -05:00
TheSylphIsIn
a9d7eddfe6 Merge branch 'main' of https://github.com/pret/pokeplatinum 2025-02-15 13:52:06 -05:00
TheSylphIsIn
46d68181af Poketch Party Status continued
Graphics/ov25 related stuff is mostly undocumented because I feel out of my depth.
2025-02-15 13:51:30 -05:00