diff --git a/asm/macros/scrcmd.inc b/asm/macros/scrcmd.inc index df374c5562..751f9cf71b 100644 --- a/asm/macros/scrcmd.inc +++ b/asm/macros/scrcmd.inc @@ -3253,6 +3253,10 @@ CallCommonScript 0x7D2 .endm + .macro GenericVendorGreeting + CallCommonScript 0x7E3 + .endm + .macro PlayElevatorAnimation elevatorDir, loopCount .short 572 .short \elevatorDir diff --git a/res/field/scripts/scripts_canalave_city_mart.s b/res/field/scripts/scripts_canalave_city_mart.s index 06e4f09095..e7410cc761 100644 --- a/res/field/scripts/scripts_canalave_city_mart.s +++ b/res/field/scripts/scripts_canalave_city_mart.s @@ -12,7 +12,7 @@ _0012: PlayFanfare SEQ_SE_CONFIRM LockAll FacePlayer - CallCommonScript 0x7E3 + GenericVendorGreeting CloseMessageWithoutErasing PokeMartCommon ReleaseAll @@ -22,7 +22,7 @@ _0028: PlayFanfare SEQ_SE_CONFIRM LockAll FacePlayer - CallCommonScript 0x7E3 + GenericVendorGreeting CloseMessageWithoutErasing PokeMartSpecialties MART_SPECIALTIES_ID_CANALAVE ReleaseAll diff --git a/res/field/scripts/scripts_celestic_town_northwest_house.s b/res/field/scripts/scripts_celestic_town_northwest_house.s index 11b705beac..536395c53b 100644 --- a/res/field/scripts/scripts_celestic_town_northwest_house.s +++ b/res/field/scripts/scripts_celestic_town_northwest_house.s @@ -13,7 +13,7 @@ _0012: LockAll FacePlayer Message 0 - CallCommonScript 0x7E3 + GenericVendorGreeting CloseMessageWithoutErasing PokeMartCommon ReleaseAll @@ -23,7 +23,7 @@ _002B: PlayFanfare SEQ_SE_CONFIRM LockAll FacePlayer - CallCommonScript 0x7E3 + GenericVendorGreeting CloseMessageWithoutErasing PokeMartCommon ReleaseAll @@ -33,7 +33,7 @@ _0041: PlayFanfare SEQ_SE_CONFIRM LockAll FacePlayer - CallCommonScript 0x7E3 + GenericVendorGreeting CloseMessageWithoutErasing PokeMartSpecialties MART_SPECIALTIES_ID_CELESTIC ReleaseAll diff --git a/res/field/scripts/scripts_common.s b/res/field/scripts/scripts_common.s index 34126487e8..7eaa5d6708 100644 --- a/res/field/scripts/scripts_common.s +++ b/res/field/scripts/scripts_common.s @@ -1141,7 +1141,7 @@ _0FA7: End CommonScript_VendorGreetingGeneric: - Message pl_msg_00000213_00037 + Message CommonStrings_Text_VendorGreetingGeneric ReturnCommonScript End diff --git a/res/field/scripts/scripts_eterna_city_mart.s b/res/field/scripts/scripts_eterna_city_mart.s index ccabf0501d..26685bef2f 100644 --- a/res/field/scripts/scripts_eterna_city_mart.s +++ b/res/field/scripts/scripts_eterna_city_mart.s @@ -12,7 +12,7 @@ _0012: PlayFanfare SEQ_SE_CONFIRM LockAll FacePlayer - CallCommonScript 0x7E3 + GenericVendorGreeting CloseMessageWithoutErasing PokeMartCommon ReleaseAll @@ -22,7 +22,7 @@ _0028: PlayFanfare SEQ_SE_CONFIRM LockAll FacePlayer - CallCommonScript 0x7E3 + GenericVendorGreeting CloseMessageWithoutErasing PokeMartSpecialties MART_SPECIALTIES_ID_ETERNA_MART ReleaseAll diff --git a/res/field/scripts/scripts_fight_area_mart.s b/res/field/scripts/scripts_fight_area_mart.s index e7876bb8c1..aec4a3a2b6 100644 --- a/res/field/scripts/scripts_fight_area_mart.s +++ b/res/field/scripts/scripts_fight_area_mart.s @@ -12,7 +12,7 @@ _0012: PlayFanfare SEQ_SE_CONFIRM LockAll FacePlayer - CallCommonScript 0x7E3 + GenericVendorGreeting CloseMessageWithoutErasing PokeMartCommon ReleaseAll diff --git a/res/field/scripts/scripts_floaroma_town_mart.s b/res/field/scripts/scripts_floaroma_town_mart.s index 96317dcd04..dd80e85bb4 100644 --- a/res/field/scripts/scripts_floaroma_town_mart.s +++ b/res/field/scripts/scripts_floaroma_town_mart.s @@ -12,7 +12,7 @@ _0012: PlayFanfare SEQ_SE_CONFIRM LockAll FacePlayer - CallCommonScript 0x7E3 + GenericVendorGreeting CloseMessageWithoutErasing PokeMartCommon ReleaseAll @@ -22,7 +22,7 @@ _0028: PlayFanfare SEQ_SE_CONFIRM LockAll FacePlayer - CallCommonScript 0x7E3 + GenericVendorGreeting CloseMessageWithoutErasing PokeMartSpecialties MART_SPECIALTIES_ID_FLOAROMA ReleaseAll diff --git a/res/field/scripts/scripts_hearthome_city_mart.s b/res/field/scripts/scripts_hearthome_city_mart.s index ed20bc3016..9e1548a5db 100644 --- a/res/field/scripts/scripts_hearthome_city_mart.s +++ b/res/field/scripts/scripts_hearthome_city_mart.s @@ -12,7 +12,7 @@ _0012: PlayFanfare SEQ_SE_CONFIRM LockAll FacePlayer - CallCommonScript 0x7E3 + GenericVendorGreeting CloseMessageWithoutErasing PokeMartCommon ReleaseAll @@ -22,7 +22,7 @@ _0028: PlayFanfare SEQ_SE_CONFIRM LockAll FacePlayer - CallCommonScript 0x7E3 + GenericVendorGreeting CloseMessageWithoutErasing PokeMartSpecialties MART_SPECIALTIES_ID_HEARTHOME ReleaseAll diff --git a/res/field/scripts/scripts_jubilife_city_mart.s b/res/field/scripts/scripts_jubilife_city_mart.s index b5796ca9b3..5aab670b5c 100644 --- a/res/field/scripts/scripts_jubilife_city_mart.s +++ b/res/field/scripts/scripts_jubilife_city_mart.s @@ -13,7 +13,7 @@ _0016: PlayFanfare SEQ_SE_CONFIRM LockAll FacePlayer - CallCommonScript 0x7E3 + GenericVendorGreeting CloseMessageWithoutErasing PokeMartCommon ReleaseAll @@ -23,7 +23,7 @@ _002C: PlayFanfare SEQ_SE_CONFIRM LockAll FacePlayer - CallCommonScript 0x7E3 + GenericVendorGreeting CloseMessageWithoutErasing PokeMartSpecialties MART_SPECIALTIES_ID_JUBILIFE ReleaseAll diff --git a/res/field/scripts/scripts_oreburgh_city_mart.s b/res/field/scripts/scripts_oreburgh_city_mart.s index e04ff8bd5c..230313344d 100644 --- a/res/field/scripts/scripts_oreburgh_city_mart.s +++ b/res/field/scripts/scripts_oreburgh_city_mart.s @@ -12,7 +12,7 @@ _0012: PlayFanfare SEQ_SE_CONFIRM LockAll FacePlayer - CallCommonScript 0x7E3 + GenericVendorGreeting CloseMessageWithoutErasing PokeMartCommon ReleaseAll @@ -22,7 +22,7 @@ _0028: PlayFanfare SEQ_SE_CONFIRM LockAll FacePlayer - CallCommonScript 0x7E3 + GenericVendorGreeting CloseMessageWithoutErasing PokeMartSpecialties MART_SPECIALTIES_ID_OREBURGH ReleaseAll diff --git a/res/field/scripts/scripts_pastoria_city_mart.s b/res/field/scripts/scripts_pastoria_city_mart.s index c6d0f32860..cd146418c8 100644 --- a/res/field/scripts/scripts_pastoria_city_mart.s +++ b/res/field/scripts/scripts_pastoria_city_mart.s @@ -13,7 +13,7 @@ _0016: PlayFanfare SEQ_SE_CONFIRM LockAll FacePlayer - CallCommonScript 0x7E3 + GenericVendorGreeting CloseMessageWithoutErasing PokeMartCommon ReleaseAll @@ -23,7 +23,7 @@ _002C: PlayFanfare SEQ_SE_CONFIRM LockAll FacePlayer - CallCommonScript 0x7E3 + GenericVendorGreeting CloseMessageWithoutErasing PokeMartSpecialties MART_SPECIALTIES_ID_PASTORIA ReleaseAll diff --git a/res/field/scripts/scripts_pokemon_league_north_pokecenter_1f.s b/res/field/scripts/scripts_pokemon_league_north_pokecenter_1f.s index b4efaf2cc3..01d858d3b7 100644 --- a/res/field/scripts/scripts_pokemon_league_north_pokecenter_1f.s +++ b/res/field/scripts/scripts_pokemon_league_north_pokecenter_1f.s @@ -100,7 +100,7 @@ _0128: PlayFanfare SEQ_SE_CONFIRM LockAll FacePlayer - CallCommonScript 0x7E3 + GenericVendorGreeting CloseMessageWithoutErasing PokeMartCommon ReleaseAll @@ -110,7 +110,7 @@ _013E: PlayFanfare SEQ_SE_CONFIRM LockAll FacePlayer - CallCommonScript 0x7E3 + GenericVendorGreeting CloseMessageWithoutErasing PokeMartSpecialties MART_SPECIALTIES_ID_POKEMON_LEAGUE ReleaseAll diff --git a/res/field/scripts/scripts_pokemon_league_south_pokecenter_1f.s b/res/field/scripts/scripts_pokemon_league_south_pokecenter_1f.s index fa5d599a7b..7297131071 100644 --- a/res/field/scripts/scripts_pokemon_league_south_pokecenter_1f.s +++ b/res/field/scripts/scripts_pokemon_league_south_pokecenter_1f.s @@ -22,7 +22,7 @@ _002C: PlayFanfare SEQ_SE_CONFIRM LockAll FacePlayer - CallCommonScript 0x7E3 + GenericVendorGreeting CloseMessageWithoutErasing PokeMartCommon ReleaseAll @@ -32,7 +32,7 @@ _0042: PlayFanfare SEQ_SE_CONFIRM LockAll FacePlayer - CallCommonScript 0x7E3 + GenericVendorGreeting CloseMessageWithoutErasing PokeMartSpecialties MART_SPECIALTIES_ID_POKEMON_LEAGUE ReleaseAll diff --git a/res/field/scripts/scripts_resort_area_mart.s b/res/field/scripts/scripts_resort_area_mart.s index c2bf290e4b..d8191558f8 100644 --- a/res/field/scripts/scripts_resort_area_mart.s +++ b/res/field/scripts/scripts_resort_area_mart.s @@ -9,7 +9,7 @@ _000A: PlayFanfare SEQ_SE_CONFIRM LockAll FacePlayer - CallCommonScript 0x7E3 + GenericVendorGreeting CloseMessageWithoutErasing PokeMartCommon ReleaseAll diff --git a/res/field/scripts/scripts_sandgem_town_mart.s b/res/field/scripts/scripts_sandgem_town_mart.s index e297953876..3984b9afa0 100644 --- a/res/field/scripts/scripts_sandgem_town_mart.s +++ b/res/field/scripts/scripts_sandgem_town_mart.s @@ -2,40 +2,40 @@ #include "res/text/bank/sandgem_town_mart.h" - ScriptEntry _0012 - ScriptEntry _0028 - ScriptEntry _002A - ScriptEntry _003D + ScriptEntry SandgemTownMart_Vendor + ScriptEntry SandgemTownMart_Dummy + ScriptEntry SandgemTownMart_Breeder + ScriptEntry SandgemTownMart_SchoolBoy ScriptEntryEnd -_0012: +SandgemTownMart_Vendor: PlayFanfare SEQ_SE_CONFIRM LockAll FacePlayer - CallCommonScript 0x7E3 + GenericVendorGreeting CloseMessageWithoutErasing PokeMartCommon 0 ReleaseAll End -_0028: +SandgemTownMart_Dummy: End -_002A: +SandgemTownMart_Breeder: PlayFanfare SEQ_SE_CONFIRM LockAll FacePlayer - Message 0 + Message SandgemTownMart_Text_BuyLotsOfPotions WaitABXPadPress CloseMessage ReleaseAll End -_003D: +SandgemTownMart_SchoolBoy: PlayFanfare SEQ_SE_CONFIRM LockAll FacePlayer - Message 1 + Message SandgemTownMart_Text_TossAPokeBall WaitABXPadPress CloseMessage ReleaseAll diff --git a/res/field/scripts/scripts_snowpoint_city_mart.s b/res/field/scripts/scripts_snowpoint_city_mart.s index 84b8b8eb7e..dba174d113 100644 --- a/res/field/scripts/scripts_snowpoint_city_mart.s +++ b/res/field/scripts/scripts_snowpoint_city_mart.s @@ -12,7 +12,7 @@ _0012: PlayFanfare SEQ_SE_CONFIRM LockAll FacePlayer - CallCommonScript 0x7E3 + GenericVendorGreeting CloseMessageWithoutErasing PokeMartCommon ReleaseAll @@ -22,7 +22,7 @@ _0028: PlayFanfare SEQ_SE_CONFIRM LockAll FacePlayer - CallCommonScript 0x7E3 + GenericVendorGreeting CloseMessageWithoutErasing PokeMartSpecialties MART_SPECIALTIES_ID_SNOWPOINT ReleaseAll diff --git a/res/field/scripts/scripts_solaceon_town_mart.s b/res/field/scripts/scripts_solaceon_town_mart.s index 48d87ea575..5d41a5257b 100644 --- a/res/field/scripts/scripts_solaceon_town_mart.s +++ b/res/field/scripts/scripts_solaceon_town_mart.s @@ -12,7 +12,7 @@ _0012: PlayFanfare SEQ_SE_CONFIRM LockAll FacePlayer - CallCommonScript 0x7E3 + GenericVendorGreeting CloseMessageWithoutErasing PokeMartCommon ReleaseAll @@ -22,7 +22,7 @@ _0028: PlayFanfare SEQ_SE_CONFIRM LockAll FacePlayer - CallCommonScript 0x7E3 + GenericVendorGreeting CloseMessageWithoutErasing PokeMartSpecialties MART_SPECIALTIES_ID_SOLACEON ReleaseAll diff --git a/res/field/scripts/scripts_sunyshore_city.s b/res/field/scripts/scripts_sunyshore_city.s index 3d3bc4a0bb..2e800b9635 100644 --- a/res/field/scripts/scripts_sunyshore_city.s +++ b/res/field/scripts/scripts_sunyshore_city.s @@ -610,7 +610,7 @@ _0791: PlayFanfare SEQ_SE_CONFIRM LockAll FacePlayer - CallCommonScript 0x7E3 + GenericVendorGreeting CloseMessageWithoutErasing GetDayOfWeek VAR_RESULT SetVar VAR_0x8008, VAR_RESULT diff --git a/res/field/scripts/scripts_sunyshore_city_mart.s b/res/field/scripts/scripts_sunyshore_city_mart.s index a819c23720..b6be0e9197 100644 --- a/res/field/scripts/scripts_sunyshore_city_mart.s +++ b/res/field/scripts/scripts_sunyshore_city_mart.s @@ -12,7 +12,7 @@ _0012: PlayFanfare SEQ_SE_CONFIRM LockAll FacePlayer - CallCommonScript 0x7E3 + GenericVendorGreeting CloseMessageWithoutErasing PokeMartCommon ReleaseAll @@ -22,7 +22,7 @@ _0028: PlayFanfare SEQ_SE_CONFIRM LockAll FacePlayer - CallCommonScript 0x7E3 + GenericVendorGreeting CloseMessageWithoutErasing PokeMartSpecialties MART_SPECIALTIES_ID_SUNYSHORE ReleaseAll diff --git a/res/field/scripts/scripts_sunyshore_market.s b/res/field/scripts/scripts_sunyshore_market.s index 42a5b461c6..f47e3aed8b 100644 --- a/res/field/scripts/scripts_sunyshore_market.s +++ b/res/field/scripts/scripts_sunyshore_market.s @@ -70,7 +70,7 @@ SunyshoreMarket_SealShop: CheckItem ITEM_SEAL_CASE, 1, VAR_RESULT GoToIfEq VAR_RESULT, FALSE, SunyshoreMarket_NoSealCase Message SunyshoreMarket_Text_ALittleTimeIfYouWill - CallCommonScript 0x7E3 + GenericVendorGreeting CloseMessageWithoutErasing Call SunyshoreMarket_OpenSealShopMenu ReleaseAll diff --git a/res/field/scripts/scripts_survival_area_mart.s b/res/field/scripts/scripts_survival_area_mart.s index b2e9bc6988..d4bd7d6716 100644 --- a/res/field/scripts/scripts_survival_area_mart.s +++ b/res/field/scripts/scripts_survival_area_mart.s @@ -12,7 +12,7 @@ _0012: PlayFanfare SEQ_SE_CONFIRM LockAll FacePlayer - CallCommonScript 0x7E3 + GenericVendorGreeting CloseMessageWithoutErasing PokeMartCommon ReleaseAll diff --git a/res/field/scripts/scripts_unk_1087.s b/res/field/scripts/scripts_unk_1087.s index e8702dc101..907bda07ad 100644 --- a/res/field/scripts/scripts_unk_1087.s +++ b/res/field/scripts/scripts_unk_1087.s @@ -9,7 +9,7 @@ _000A: PlayFanfare SEQ_SE_CONFIRM LockAll FacePlayer - CallCommonScript 0x7E3 + GenericVendorGreeting CloseMessageWithoutErasing PokeMartCommon ReleaseAll @@ -19,7 +19,7 @@ _0020: PlayFanfare SEQ_SE_CONFIRM LockAll FacePlayer - CallCommonScript 0x7E3 + GenericVendorGreeting CloseMessageWithoutErasing PokeMartSpecialties MART_SPECIALTIES_ID_CELESTIC ReleaseAll diff --git a/res/field/scripts/scripts_veilstone_store_1f.s b/res/field/scripts/scripts_veilstone_store_1f.s index 0bfbf2afc2..ee30697c31 100644 --- a/res/field/scripts/scripts_veilstone_store_1f.s +++ b/res/field/scripts/scripts_veilstone_store_1f.s @@ -46,7 +46,7 @@ _005B: PlayFanfare SEQ_SE_CONFIRM LockAll FacePlayer - CallCommonScript 0x7E3 + GenericVendorGreeting CloseMessageWithoutErasing PokeMartSpecialties MART_SPECIALTIES_ID_VEILSTONE_1F_RIGHT ReleaseAll @@ -56,7 +56,7 @@ _0071: PlayFanfare SEQ_SE_CONFIRM LockAll FacePlayer - CallCommonScript 0x7E3 + GenericVendorGreeting CloseMessageWithoutErasing PokeMartSpecialties MART_SPECIALTIES_ID_VEILSTONE_1F_LEFT ReleaseAll diff --git a/res/field/scripts/scripts_veilstone_store_2f.s b/res/field/scripts/scripts_veilstone_store_2f.s index 1b10465a6c..1d130dc6af 100644 --- a/res/field/scripts/scripts_veilstone_store_2f.s +++ b/res/field/scripts/scripts_veilstone_store_2f.s @@ -150,7 +150,7 @@ _0198: PlayFanfare SEQ_SE_CONFIRM LockAll FacePlayer - CallCommonScript 0x7E3 + GenericVendorGreeting CloseMessageWithoutErasing PokeMartSpecialties MART_SPECIALTIES_ID_VEILSTONE_2F_UP ReleaseAll @@ -160,7 +160,7 @@ _01AE: PlayFanfare SEQ_SE_CONFIRM LockAll FacePlayer - CallCommonScript 0x7E3 + GenericVendorGreeting CloseMessageWithoutErasing PokeMartSpecialties MART_SPECIALTIES_ID_VEILSTONE_2F_MID ReleaseAll diff --git a/res/field/scripts/scripts_veilstone_store_3f.s b/res/field/scripts/scripts_veilstone_store_3f.s index 61a9e1515e..da479b34bb 100644 --- a/res/field/scripts/scripts_veilstone_store_3f.s +++ b/res/field/scripts/scripts_veilstone_store_3f.s @@ -108,7 +108,7 @@ _0127: PlayFanfare SEQ_SE_CONFIRM LockAll FacePlayer - CallCommonScript 0x7E3 + GenericVendorGreeting CloseMessageWithoutErasing PokeMartSpecialties MART_SPECIALTIES_ID_VEILSTONE_3F_UP ReleaseAll @@ -118,7 +118,7 @@ _013D: PlayFanfare SEQ_SE_CONFIRM LockAll FacePlayer - CallCommonScript 0x7E3 + GenericVendorGreeting CloseMessageWithoutErasing PokeMartSpecialties MART_SPECIALTIES_ID_VEILSTONE_3F_DOWN ReleaseAll diff --git a/res/field/scripts/scripts_veilstone_store_4f.s b/res/field/scripts/scripts_veilstone_store_4f.s index 4231b6e424..38ede80168 100644 --- a/res/field/scripts/scripts_veilstone_store_4f.s +++ b/res/field/scripts/scripts_veilstone_store_4f.s @@ -108,7 +108,7 @@ _0127: PlayFanfare SEQ_SE_CONFIRM LockAll FacePlayer - CallCommonScript 0x7E3 + GenericVendorGreeting CloseMessageWithoutErasing PokeMartDecor MART_DECOR_ID_VEILSTONE_4F_UP ReleaseAll @@ -118,7 +118,7 @@ _013D: PlayFanfare SEQ_SE_CONFIRM LockAll FacePlayer - CallCommonScript 0x7E3 + GenericVendorGreeting CloseMessageWithoutErasing PokeMartDecor MART_DECOR_ID_VEILSTONE_4F_DOWN ReleaseAll diff --git a/res/field/scripts/scripts_veilstone_store_b1f.s b/res/field/scripts/scripts_veilstone_store_b1f.s index 8ba8868d48..7336bf3a2b 100644 --- a/res/field/scripts/scripts_veilstone_store_b1f.s +++ b/res/field/scripts/scripts_veilstone_store_b1f.s @@ -106,7 +106,7 @@ _00E8: PlayFanfare SEQ_SE_CONFIRM LockAll FacePlayer - CallCommonScript 0x7E3 + GenericVendorGreeting CloseMessageWithoutErasing PokeMartSpecialties MART_SPECIALTIES_ID_VEILSTONE_B1F ReleaseAll diff --git a/res/text/common_strings.json b/res/text/common_strings.json index f155800dbf..9abf9b2fe9 100644 --- a/res/text/common_strings.json +++ b/res/text/common_strings.json @@ -256,7 +256,7 @@ ] }, { - "id": "pl_msg_00000213_00037", + "id": "CommonStrings_Text_VendorGreetingGeneric", "en_US": [ "Welcome!\n", "What do you need?" diff --git a/res/text/sandgem_town_mart.json b/res/text/sandgem_town_mart.json index 26998e6d23..b29ad63970 100644 --- a/res/text/sandgem_town_mart.json +++ b/res/text/sandgem_town_mart.json @@ -2,7 +2,7 @@ "key": 53008, "messages": [ { - "id": "pl_msg_00000562_00000", + "id": "SandgemTownMart_Text_BuyLotsOfPotions", "en_US": [ "If a Pokémon loses all its HP,\n", "it can’t battle anymore.\r", @@ -11,7 +11,7 @@ ] }, { - "id": "pl_msg_00000562_00001", + "id": "SandgemTownMart_Text_TossAPokeBall", "en_US": [ "If you come across a Pokémon you’ve\n", "just gotta have, toss a Poké Ball!\r",