mirror of
https://github.com/smogon/pokemon-showdown.git
synced 2026-04-19 17:17:22 -05:00
a65faf263f
It turns out that when I switched us from `assert` to `assert.strict`,
I didn't actually update any existing tests or tell anyone:
0df0d234f2
So apparently everyone else just kept on using `strictEqual`.
This will be a PR and also throw an error if people continue trying to
use it, which should make it much clearer what PS policy is on this.
A lot of the problem may be that TypeScript marks assert.strict.equal
as deprecated when it's not. This was fixed 4 days ago:
https://github.com/DefinitelyTyped/DefinitelyTyped/pull/48452
But this probably hasn't made it to a thing yet. Until then, you'll
have to deal with TS marking your tests as deprecated, but it shouldn't
be too long.
Accidentally using `assert` instead of `assert.strict` should now show
an error. This protects against the probably much worse mistake of
accidentally using `assert.equal` rather than `assert.strict.equal`.
`assert.ok` is also deprecated now.
59 lines
1.7 KiB
JavaScript
59 lines
1.7 KiB
JavaScript
'use strict';
|
|
|
|
const assert = require('./../../assert');
|
|
const common = require('./../../common');
|
|
|
|
let battle;
|
|
|
|
describe('Fainting', function () {
|
|
afterEach(function () {
|
|
battle.destroy();
|
|
});
|
|
|
|
it('should end the turn in Gen 1', function () {
|
|
// Gen 1 has no end-of-turn effects
|
|
battle = common.gen(1).createBattle([
|
|
[
|
|
{species: 'Electrode', moves: ['explosion']},
|
|
{species: 'Pikachu', moves: ['growl']},
|
|
],
|
|
[
|
|
{species: 'Haunter', moves: ['substitute']},
|
|
],
|
|
]);
|
|
battle.makeChoices('move Explosion', 'move Substitute');
|
|
battle.makeChoices('switch Pikachu', '');
|
|
assert.equal(battle.p2.active[0].hp, battle.p2.active[0].maxhp);
|
|
});
|
|
|
|
it('should end the turn in Gen 3', function () {
|
|
battle = common.gen(3).createBattle([
|
|
[
|
|
{species: 'Electrode', ability: 'soundproof', moves: ['explosion']},
|
|
{species: 'Pikachu', ability: 'lightningrod', moves: ['growl']},
|
|
],
|
|
[
|
|
{species: 'Haunter', ability: 'levitate', moves: ['substitute']},
|
|
],
|
|
]);
|
|
battle.makeChoices('move Explosion', 'move Substitute');
|
|
battle.makeChoices('switch Pikachu', '');
|
|
assert.equal(battle.p2.active[0].hp, battle.p2.active[0].maxhp);
|
|
});
|
|
|
|
it('should not end the turn in Gen 4', function () {
|
|
battle = common.gen(4).createBattle([
|
|
[
|
|
{species: 'Electrode', ability: 'soundproof', moves: ['explosion']},
|
|
{species: 'Pikachu', ability: 'lightningrod', moves: ['growl']},
|
|
],
|
|
[
|
|
{species: 'Haunter', ability: 'levitate', moves: ['substitute']},
|
|
],
|
|
]);
|
|
battle.makeChoices('move Explosion', 'move Substitute');
|
|
battle.makeChoices('switch Pikachu', '');
|
|
assert.notEqual(battle.p2.active[0].hp, battle.p2.active[0].maxhp);
|
|
});
|
|
});
|