mirror of
https://github.com/smogon/pokemon-showdown.git
synced 2026-04-16 22:46:47 -05:00
a65faf263f
It turns out that when I switched us from `assert` to `assert.strict`,
I didn't actually update any existing tests or tell anyone:
0df0d234f2
So apparently everyone else just kept on using `strictEqual`.
This will be a PR and also throw an error if people continue trying to
use it, which should make it much clearer what PS policy is on this.
A lot of the problem may be that TypeScript marks assert.strict.equal
as deprecated when it's not. This was fixed 4 days ago:
https://github.com/DefinitelyTyped/DefinitelyTyped/pull/48452
But this probably hasn't made it to a thing yet. Until then, you'll
have to deal with TS marking your tests as deprecated, but it shouldn't
be too long.
Accidentally using `assert` instead of `assert.strict` should now show
an error. This protects against the probably much worse mistake of
accidentally using `assert.equal` rather than `assert.strict.equal`.
`assert.ok` is also deprecated now.
53 lines
2.1 KiB
JavaScript
53 lines
2.1 KiB
JavaScript
'use strict';
|
|
|
|
const assert = require('./../../assert');
|
|
const common = require('./../../common');
|
|
|
|
let battle;
|
|
|
|
describe('Ring Target', function () {
|
|
afterEach(function () {
|
|
battle.destroy();
|
|
});
|
|
|
|
it('should negate natural immunities and deal normal type effectiveness with the other type(s)', function () {
|
|
battle = common.createBattle();
|
|
battle.setPlayer('p1', {team: [{species: "Smeargle", ability: 'owntempo', moves: ['earthquake', 'vitalthrow', 'shadowball', 'psychic']}]});
|
|
battle.setPlayer('p2', {team: [
|
|
{species: "Thundurus", ability: 'prankster', item: 'ringtarget', moves: ['rest']},
|
|
{species: "Drifblim", ability: 'unburden', item: 'ringtarget', moves: ['rest']},
|
|
{species: "Girafarig", ability: 'innerfocus', item: 'ringtarget', moves: ['rest']},
|
|
{species: "Absol", ability: 'superluck', item: 'ringtarget', moves: ['rest']},
|
|
]});
|
|
battle.makeChoices('move earthquake', 'move rest');
|
|
assert(battle.log[battle.lastMoveLine + 1].startsWith('|-supereffective|'));
|
|
assert.false.fullHP(battle.p2.active[0]);
|
|
|
|
battle.makeChoices('move vitalthrow', 'switch 2'); // Drifblim
|
|
assert(battle.log[battle.lastMoveLine + 1].startsWith('|-resisted|'));
|
|
assert.false.fullHP(battle.p2.active[0]);
|
|
|
|
battle.makeChoices('move shadowball', 'switch 3'); // Girafarig
|
|
assert(battle.log[battle.lastMoveLine + 1].startsWith('|-supereffective|'));
|
|
assert.false.fullHP(battle.p2.active[0]);
|
|
|
|
battle.makeChoices('move psychic', 'switch 4'); // Absol
|
|
assert.false.fullHP(battle.p2.active[0]);
|
|
});
|
|
|
|
it('should not affect ability-based immunities', function () {
|
|
battle = common.createBattle();
|
|
battle.setPlayer('p1', {team: [{species: "Hariyama", ability: 'guts', moves: ['earthquake']}]});
|
|
battle.setPlayer('p2', {team: [
|
|
{species: "Mismagius", ability: 'levitate', item: 'ringtarget', moves: ['shadowsneak']},
|
|
{species: "Rotom-Fan", ability: 'levitate', item: 'ringtarget', moves: ['snore']},
|
|
]});
|
|
battle.makeChoices('move earthquake', 'move shadowsneak');
|
|
assert.fullHP(battle.p2.active[0]);
|
|
|
|
// even if Rotom-Fan
|
|
battle.makeChoices('move earthquake', 'switch 2');
|
|
assert.fullHP(battle.p2.active[0]);
|
|
});
|
|
});
|