mirror of
https://github.com/smogon/pokemon-showdown.git
synced 2026-03-28 20:55:52 -05:00
a65faf263f
It turns out that when I switched us from `assert` to `assert.strict`,
I didn't actually update any existing tests or tell anyone:
0df0d234f2
So apparently everyone else just kept on using `strictEqual`.
This will be a PR and also throw an error if people continue trying to
use it, which should make it much clearer what PS policy is on this.
A lot of the problem may be that TypeScript marks assert.strict.equal
as deprecated when it's not. This was fixed 4 days ago:
https://github.com/DefinitelyTyped/DefinitelyTyped/pull/48452
But this probably hasn't made it to a thing yet. Until then, you'll
have to deal with TS marking your tests as deprecated, but it shouldn't
be too long.
Accidentally using `assert` instead of `assert.strict` should now show
an error. This protects against the probably much worse mistake of
accidentally using `assert.equal` rather than `assert.strict.equal`.
`assert.ok` is also deprecated now.
45 lines
1.4 KiB
JavaScript
45 lines
1.4 KiB
JavaScript
'use strict';
|
|
|
|
const assert = require('./../../assert');
|
|
const common = require('./../../common');
|
|
|
|
let battle;
|
|
|
|
describe('Shell Armor', function () {
|
|
afterEach(function () {
|
|
battle.destroy();
|
|
});
|
|
|
|
it('should prevent moves from dealing critical hits', function () {
|
|
battle = common.createBattle([
|
|
[{species: 'Slowbro', ability: 'shellarmor', moves: ['quickattack']}],
|
|
[{species: 'Cryogonal', ability: 'noguard', moves: ['frostbreath']}],
|
|
]);
|
|
let successfulEvent = false;
|
|
battle.onEvent('ModifyDamage', battle.format, function (damage, attacker, defender, move) {
|
|
if (move.id === 'frostbreath') {
|
|
successfulEvent = true;
|
|
assert.false(defender.getMoveHitData(move).crit);
|
|
}
|
|
});
|
|
battle.makeChoices('move quickattack', 'move frostbreath');
|
|
assert(successfulEvent);
|
|
});
|
|
|
|
it('should be suppressed by Mold Breaker', function () {
|
|
battle = common.createBattle([
|
|
[{species: 'Slowbro', ability: 'shellarmor', moves: ['quickattack']}],
|
|
[{species: 'Cryogonal', ability: 'moldbreaker', item: 'zoomlens', moves: ['frostbreath']}],
|
|
]);
|
|
let successfulEvent = false;
|
|
battle.onEvent('ModifyDamage', battle.format, function (damage, attacker, defender, move) {
|
|
if (move.id === 'frostbreath') {
|
|
successfulEvent = true;
|
|
assert(defender.getMoveHitData(move).crit);
|
|
}
|
|
});
|
|
battle.makeChoices('move quickattack', 'move frostbreath');
|
|
assert(successfulEvent);
|
|
});
|
|
});
|