mirror of
https://github.com/smogon/pokemon-showdown.git
synced 2026-04-07 01:26:16 -05:00
a65faf263f
It turns out that when I switched us from `assert` to `assert.strict`,
I didn't actually update any existing tests or tell anyone:
0df0d234f2
So apparently everyone else just kept on using `strictEqual`.
This will be a PR and also throw an error if people continue trying to
use it, which should make it much clearer what PS policy is on this.
A lot of the problem may be that TypeScript marks assert.strict.equal
as deprecated when it's not. This was fixed 4 days ago:
https://github.com/DefinitelyTyped/DefinitelyTyped/pull/48452
But this probably hasn't made it to a thing yet. Until then, you'll
have to deal with TS marking your tests as deprecated, but it shouldn't
be too long.
Accidentally using `assert` instead of `assert.strict` should now show
an error. This protects against the probably much worse mistake of
accidentally using `assert.equal` rather than `assert.strict.equal`.
`assert.ok` is also deprecated now.
40 lines
1.6 KiB
JavaScript
40 lines
1.6 KiB
JavaScript
/**
|
|
* Tests for the Youtube room plugin.
|
|
* Written by Mia.
|
|
* @author mia-pi-git
|
|
*/
|
|
'use strict';
|
|
const YoutubeInterface = require('../../../.server-dist/chat-plugins/youtube').YoutubeInterface;
|
|
const assert = require('../../assert');
|
|
|
|
describe(`Youtube features`, function () {
|
|
it.skip(`should correctly add channels to the database`, async function () {
|
|
if (!Config.youtubeKey) return true;
|
|
const Youtube = new YoutubeInterface({});
|
|
const url = 'https://www.youtube.com/channel/UCuAXFkgsw1L7xaCfnd5JJOw';
|
|
await Youtube.getChannelData(url, undefined);
|
|
assert(Youtube.data['UCuAXFkgsw1L7xaCfnd5JJOw']);
|
|
});
|
|
|
|
it.skip(`should correctly handle PS names and channel names`, async function () {
|
|
if (!Config.youtubeKey) return true;
|
|
const Youtube = new YoutubeInterface({});
|
|
const url = 'https://www.youtube.com/channel/UCuAXFkgsw1L7xaCfnd5JJOw';
|
|
const channelId = 'UCuAXFkgsw1L7xaCfnd5JJOw';
|
|
await Youtube.getChannelData(url, 'Pickle Rick');
|
|
assert.equal(channelId, Youtube.channelSearch('Pickle Rick'));
|
|
assert.equal(channelId, Youtube.channelSearch('Official Rick Astley'));
|
|
});
|
|
|
|
it.skip(`should correctly parse channel links`, function () {
|
|
if (!Config.youtubeKey) return true;
|
|
const videoUrl = 'https://www.youtube.com/watch?v=dQw4w9WgXcQ';
|
|
const channelUrl = 'https://www.youtube.com/channel/UCuAXFkgsw1L7xaCfnd5JJOw';
|
|
const Youtube = new YoutubeInterface({});
|
|
const videoId = Youtube.getId(videoUrl);
|
|
assert.equal(videoId, 'dQw4w9WgXcQ');
|
|
const channelId = Youtube.getId(channelUrl);
|
|
assert.equal(channelId, 'UCuAXFkgsw1L7xaCfnd5JJOw');
|
|
});
|
|
});
|