mirror of
https://github.com/smogon/pokemon-showdown.git
synced 2026-05-17 18:51:43 -05:00
a65faf263f
It turns out that when I switched us from `assert` to `assert.strict`,
I didn't actually update any existing tests or tell anyone:
0df0d234f2
So apparently everyone else just kept on using `strictEqual`.
This will be a PR and also throw an error if people continue trying to
use it, which should make it much clearer what PS policy is on this.
A lot of the problem may be that TypeScript marks assert.strict.equal
as deprecated when it's not. This was fixed 4 days ago:
https://github.com/DefinitelyTyped/DefinitelyTyped/pull/48452
But this probably hasn't made it to a thing yet. Until then, you'll
have to deal with TS marking your tests as deprecated, but it shouldn't
be too long.
Accidentally using `assert` instead of `assert.strict` should now show
an error. This protects against the probably much worse mistake of
accidentally using `assert.equal` rather than `assert.strict.equal`.
`assert.ok` is also deprecated now.
138 lines
6.7 KiB
JavaScript
138 lines
6.7 KiB
JavaScript
'use strict';
|
|
|
|
const assert = require('./../../assert');
|
|
const common = require('./../../common');
|
|
|
|
let battle;
|
|
|
|
describe('Substitute', function () {
|
|
afterEach(function () {
|
|
battle.destroy();
|
|
});
|
|
|
|
it('should deduct 25% of max HP, rounded down', function () {
|
|
battle = common.createBattle();
|
|
battle.setPlayer('p1', {team: [{species: 'Mewtwo', ability: 'pressure', moves: ['substitute']}]});
|
|
battle.setPlayer('p2', {team: [{species: 'Mewtwo', ability: 'pressure', moves: ['recover']}]});
|
|
battle.makeChoices('move substitute', 'move recover');
|
|
const pokemon = battle.p1.active[0];
|
|
assert.equal(pokemon.maxhp - pokemon.hp, Math.floor(pokemon.maxhp / 4));
|
|
});
|
|
|
|
it('should not block the user\'s own moves from targetting itself', function () {
|
|
battle = common.createBattle();
|
|
battle.setPlayer('p1', {team: [{species: 'Mewtwo', ability: 'pressure', moves: ['substitute', 'calmmind']}]});
|
|
battle.setPlayer('p2', {team: [{species: 'Mewtwo', ability: 'pressure', moves: ['recover']}]});
|
|
battle.makeChoices('move substitute', 'move recover');
|
|
battle.makeChoices('move calmmind', 'move recover');
|
|
assert.equal(battle.p1.active[0].boosts['spa'], 1);
|
|
assert.equal(battle.p1.active[0].boosts['spd'], 1);
|
|
});
|
|
|
|
it('should block damage from most moves', function () {
|
|
battle = common.createBattle();
|
|
battle.setPlayer('p1', {team: [{species: 'Mewtwo', ability: 'pressure', moves: ['substitute']}]});
|
|
battle.setPlayer('p2', {team: [{species: 'Mewtwo', ability: 'pressure', item: 'laggingtail', moves: ['psystrike']}]});
|
|
battle.makeChoices('move substitute', 'move psystrike');
|
|
const pokemon = battle.p1.active[0];
|
|
assert.equal(pokemon.maxhp - pokemon.hp, Math.floor(pokemon.maxhp / 4));
|
|
});
|
|
|
|
it('should not block recoil damage', function () {
|
|
battle = common.createBattle();
|
|
battle.setPlayer('p1', {team: [{species: 'Mewtwo', ability: 'pressure', moves: ['substitute', 'doubleedge']}]});
|
|
battle.setPlayer('p2', {team: [{species: 'Mewtwo', ability: 'pressure', moves: ['nastyplot']}]});
|
|
battle.makeChoices('move substitute', 'move nastyplot');
|
|
battle.makeChoices('move doubleedge', 'move nastyplot');
|
|
const pokemon = battle.p1.active[0];
|
|
assert.notEqual(pokemon.maxhp - pokemon.hp, Math.floor(pokemon.maxhp / 4));
|
|
});
|
|
|
|
it('should take specific recoil damage in Gen 1', function () {
|
|
battle = common.gen(1).createBattle({seed: [0, 1, 0, 1]});
|
|
battle.setPlayer('p1', {team: [{species: 'Hitmonlee', moves: ['substitute', 'highjumpkick']}]});
|
|
battle.setPlayer('p2', {team: [{species: 'Hitmonchan', moves: ['substitute', 'agility']}]});
|
|
battle.makeChoices('move substitute', 'move substitute');
|
|
|
|
const subhp = battle.p1.active[0].volatiles['substitute'].hp;
|
|
assert.equal(subhp, battle.p2.active[0].volatiles['substitute'].hp);
|
|
|
|
battle.resetRNG(); // Make Hi Jump Kick miss and cause recoil.
|
|
battle.makeChoices('move highjumpkick', 'move agility');
|
|
|
|
// Both Pokemon had a substitute, so the *target* Substitute takes recoil damage.
|
|
let pokemon = battle.p1.active[0];
|
|
assert.equal(pokemon.maxhp - pokemon.hp, Math.floor(pokemon.maxhp / 4));
|
|
assert.equal(pokemon.volatiles['substitute'].hp, subhp);
|
|
pokemon = battle.p2.active[0];
|
|
assert.equal(pokemon.maxhp - pokemon.hp, Math.floor(pokemon.maxhp / 4));
|
|
assert.equal(pokemon.volatiles['substitute'].hp, subhp - 1);
|
|
|
|
// Hi Jump Kick hits and breaks the Substitite.
|
|
battle.makeChoices('move highjumpkick', 'move agility');
|
|
battle.resetRNG(); // Make Hi Jump Kick miss and cause recoil.
|
|
battle.makeChoices('move highjumpkick', 'move agility');
|
|
|
|
// Only P1 has a substitute, so no one takes recoil damage.
|
|
pokemon = battle.p1.active[0];
|
|
assert.equal(pokemon.maxhp - pokemon.hp, Math.floor(pokemon.maxhp / 4));
|
|
assert.equal(pokemon.volatiles['substitute'].hp, subhp);
|
|
pokemon = battle.p2.active[0];
|
|
assert.equal(pokemon.maxhp - pokemon.hp, Math.floor(pokemon.maxhp / 4));
|
|
});
|
|
|
|
it('should cause recoil damage from an opponent\'s moves to be based on damage dealt to the substitute', function () {
|
|
battle = common.createBattle();
|
|
battle.setPlayer('p1', {team: [{species: 'Mewtwo', ability: 'pressure', moves: ['substitute']}]});
|
|
battle.setPlayer('p2', {team: [{species: 'Mewtwo', ability: 'noguard', moves: ['nastyplot', 'lightofruin']}]});
|
|
battle.makeChoices('move substitute', 'move nastyplot');
|
|
battle.makeChoices('move substitute', 'move lightofruin');
|
|
const pokemon = battle.p2.active[0];
|
|
assert.equal(pokemon.maxhp - pokemon.hp, Math.ceil(Math.floor(battle.p1.active[0].maxhp / 4) / 2));
|
|
});
|
|
|
|
it('should cause recovery from an opponent\'s draining moves to be based on damage dealt to the substitute', function () {
|
|
battle = common.createBattle();
|
|
battle.setPlayer('p1', {team: [{species: 'Zangoose', ability: 'pressure', moves: ['substitute']}]});
|
|
battle.setPlayer('p2', {team: [{species: 'Zangoose', ability: 'noguard', moves: ['bellydrum', 'drainpunch']}]});
|
|
battle.makeChoices('move substitute', 'move bellydrum');
|
|
const hp = battle.p2.active[0].hp;
|
|
battle.makeChoices('move substitute', 'move drainpunch');
|
|
assert.equal(battle.p2.active[0].hp - hp, Math.ceil(Math.floor(battle.p1.active[0].maxhp / 4) / 2));
|
|
});
|
|
|
|
it('should block most status moves targetting the user', function () {
|
|
battle = common.createBattle();
|
|
battle.setPlayer('p1', {team: [{species: 'Mewtwo', ability: 'noguard', moves: ['substitute']}]});
|
|
battle.setPlayer('p2', {team: [{species: 'Mewtwo', ability: 'pressure', item: 'laggingtail', moves: ['hypnosis', 'toxic', 'poisongas', 'thunderwave', 'willowisp']}]});
|
|
for (let i = 1; i <= 5; i++) {
|
|
battle.makeChoices('move substitute', 'move ' + i);
|
|
assert.equal(battle.p1.active[0].status, '');
|
|
}
|
|
});
|
|
|
|
it('should allow multi-hit moves to continue after the substitute fades', function () {
|
|
battle = common.createBattle();
|
|
battle.setPlayer('p1', {team: [{species: 'Dragonite', ability: 'noguard', item: 'focussash', moves: ['substitute', 'roost']}]});
|
|
battle.setPlayer('p2', {team: [{species: 'Dragonite', ability: 'hugepower', item: 'laggingtail', moves: ['roost', 'dualchop']}]});
|
|
battle.makeChoices('move substitute', 'move roost');
|
|
battle.makeChoices('move roost', 'move dualchop');
|
|
assert.notEqual(battle.p1.active[0].hp, battle.p1.active[0].maxhp);
|
|
});
|
|
|
|
it('should track what the actual damage would have been without the substitute in Gen 1', function () {
|
|
battle = common.gen(1).createBattle([
|
|
[{species: 'Ponyta', moves: ['substitute', 'growl'], evs: {hp: 252, spd: 252}}],
|
|
[{species: 'Cloyster', moves: ['clamp'], evs: {spa: 252}}],
|
|
]);
|
|
|
|
const pokemon = battle.p1.active[0];
|
|
battle.makeChoices('move substitute', 'move clamp');
|
|
assert.equal(pokemon.maxhp - pokemon.hp, Math.floor(pokemon.maxhp / 4));
|
|
|
|
const hp = pokemon.hp;
|
|
battle.makeChoices('move growl', 'move clamp');
|
|
assert.bounded(hp - pokemon.hp, [91, 108]);
|
|
});
|
|
});
|