mirror of
https://github.com/smogon/pokemon-showdown.git
synced 2026-05-18 03:01:00 -05:00
a65faf263f
It turns out that when I switched us from `assert` to `assert.strict`,
I didn't actually update any existing tests or tell anyone:
0df0d234f2
So apparently everyone else just kept on using `strictEqual`.
This will be a PR and also throw an error if people continue trying to
use it, which should make it much clearer what PS policy is on this.
A lot of the problem may be that TypeScript marks assert.strict.equal
as deprecated when it's not. This was fixed 4 days ago:
https://github.com/DefinitelyTyped/DefinitelyTyped/pull/48452
But this probably hasn't made it to a thing yet. Until then, you'll
have to deal with TS marking your tests as deprecated, but it shouldn't
be too long.
Accidentally using `assert` instead of `assert.strict` should now show
an error. This protects against the probably much worse mistake of
accidentally using `assert.equal` rather than `assert.strict.equal`.
`assert.ok` is also deprecated now.
45 lines
1.7 KiB
JavaScript
45 lines
1.7 KiB
JavaScript
'use strict';
|
|
|
|
const assert = require('./../../assert');
|
|
const common = require('./../../common');
|
|
|
|
let battle;
|
|
|
|
describe('Quash', function () {
|
|
afterEach(function () {
|
|
battle.destroy();
|
|
});
|
|
|
|
it('should cause the target to move last if it has not moved yet', function () {
|
|
battle = common.createBattle({gameType: 'doubles'});
|
|
battle.setPlayer('p1', {team: [
|
|
{species: "Sableye", ability: 'prankster', moves: ['quash']},
|
|
{species: "Aggron", ability: 'sturdy', moves: ['earthquake']},
|
|
]});
|
|
battle.setPlayer('p2', {team: [
|
|
{species: "Arceus", ability: 'multitype', moves: ['voltswitch']},
|
|
{species: "Aerodactyl", ability: 'unnerve', moves: ['swift']},
|
|
{species: "Rotom", ability: 'levitate', moves: ['thunderbolt']},
|
|
]});
|
|
battle.makeChoices('move quash 2, move earthquake', 'move voltswitch 2, move swift');
|
|
battle.makeChoices('', 'switch 3, pass'); // Volt Switch
|
|
assert.equal(battle.log[battle.lastMoveLine].split('|')[3], 'Swift');
|
|
});
|
|
|
|
it('should not cause the target to move again if it has already moved', function () {
|
|
battle = common.createBattle({gameType: 'doubles'});
|
|
battle.setPlayer('p1', {team: [
|
|
{species: "Sableye", ability: 'prankster', moves: ['quash']},
|
|
{species: "Aggron", ability: 'sturdy', moves: ['earthquake']},
|
|
]});
|
|
battle.setPlayer('p2', {team: [
|
|
{species: "Arceus", ability: 'multitype', moves: ['voltswitch']},
|
|
{species: "Aerodactyl", ability: 'unnerve', moves: ['extremespeed']},
|
|
{species: "Rotom", ability: 'levitate', moves: ['thunderbolt']},
|
|
]});
|
|
battle.makeChoices('move quash 2, move earthquake', 'move voltswitch 2, move extremespeed 1');
|
|
battle.makeChoices('', 'switch 3, pass'); // Volt Switch
|
|
assert.notEqual(battle.log[battle.lastMoveLine].split('|')[3], 'Extremespeed');
|
|
});
|
|
});
|