mirror of
https://github.com/smogon/pokemon-showdown.git
synced 2026-05-17 18:51:43 -05:00
It turns out that when I switched us from `assert` to `assert.strict`,
I didn't actually update any existing tests or tell anyone:
0df0d234f2
So apparently everyone else just kept on using `strictEqual`.
This will be a PR and also throw an error if people continue trying to
use it, which should make it much clearer what PS policy is on this.
A lot of the problem may be that TypeScript marks assert.strict.equal
as deprecated when it's not. This was fixed 4 days ago:
https://github.com/DefinitelyTyped/DefinitelyTyped/pull/48452
But this probably hasn't made it to a thing yet. Until then, you'll
have to deal with TS marking your tests as deprecated, but it shouldn't
be too long.
Accidentally using `assert` instead of `assert.strict` should now show
an error. This protects against the probably much worse mistake of
accidentally using `assert.equal` rather than `assert.strict.equal`.
`assert.ok` is also deprecated now.
52 lines
1.7 KiB
JavaScript
52 lines
1.7 KiB
JavaScript
'use strict';
|
|
|
|
const assert = require('./../../assert');
|
|
const common = require('./../../common');
|
|
|
|
let battle;
|
|
|
|
describe('Miracle Eye', function () {
|
|
afterEach(function () {
|
|
battle.destroy();
|
|
});
|
|
|
|
it('should negate Psychic immunities', function () {
|
|
battle = common.createBattle({seed: [1, 2, 3, 4]}, [[
|
|
{species: "Smeargle", moves: ['miracleeye', 'psychic']},
|
|
], [
|
|
{species: "Darkrai", moves: ['nastyplot']},
|
|
]]);
|
|
battle.makeChoices('move miracle eye', 'move nasty plot');
|
|
battle.makeChoices('move psychic', 'move nasty plot');
|
|
assert.notEqual(battle.p2.active[0].hp, battle.p2.active[0].maxhp);
|
|
});
|
|
|
|
it('should ignore the effect of positive evasion stat stages', function () {
|
|
battle = common.createBattle({seed: [1, 2, 3, 4]}, [[
|
|
{species: "Smeargle", moves: ['avalanche', 'miracleeye']},
|
|
], [
|
|
{species: "Forretress", moves: ['synthesis']},
|
|
]]);
|
|
battle.makeChoices('move miracle eye', 'move synthesis');
|
|
battle.boost({evasion: 6}, battle.p2.active[0]);
|
|
for (let i = 0; i < 3; i++) {
|
|
battle.makeChoices('move avalanche', 'move synthesis');
|
|
assert.notEqual(battle.p2.active[0].hp, battle.p2.active[0].maxhp);
|
|
}
|
|
});
|
|
|
|
it('should not ignore the effect of negative evasion stat stages', function () {
|
|
battle = common.createBattle({seed: [1, 2, 3, 4]}, [[
|
|
{species: "Smeargle", moves: ['zapcannon', 'miracleeye']},
|
|
], [
|
|
{species: "Zapdos", moves: ['roost']},
|
|
]]);
|
|
battle.makeChoices('move miracle eye', 'move roost');
|
|
battle.boost({spe: 6, evasion: -6}, battle.p2.active[0]);
|
|
for (let i = 0; i < 3; i++) {
|
|
battle.makeChoices('move zap cannon', 'move roost');
|
|
assert.notEqual(battle.p2.active[0].hp, battle.p2.active[0].maxhp);
|
|
}
|
|
});
|
|
});
|